Change in ...coreboot[master]: nb/intel/pineview/raminit.c: Remove variable set but not used

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32941

Change subject: nb/intel/pineview/raminit.c: Remove variable set but not used
......................................................................

nb/intel/pineview/raminit.c: Remove variable set but not used

Change-Id: I4faf698e904c461803e867d212c31958119cc0ca
Signed-off-by: Elyes HAOUAS 
---
M src/northbridge/intel/pineview/raminit.c
1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/32941/1

diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c
index 282765e..72063cb 100644
--- a/src/northbridge/intel/pineview/raminit.c
+++ b/src/northbridge/intel/pineview/raminit.c
@@ -1835,7 +1835,6 @@

static u8 sampledqs(u32 dqshighaddr, u32 strobeaddr, u8 highlow, u8 count)
 {
-	volatile u32 strobedata;
    u8 dqsmatches = 1;
    while (count--) {
    	MCHBAR8(0x5d8) = MCHBAR8(0x5d8) & ~0x2;
@@ -1843,7 +1842,7 @@
    	MCHBAR8(0x5d8) = MCHBAR8(0x5d8) | 0x2;
    	hpet_udelay(1);
    	barrier();
-		strobedata = read32((void *)strobeaddr);
+		read32((void *)strobeaddr);
    	barrier();
    	hpet_udelay(1);

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32941 )

Change subject: nb/intel/pineview/raminit.c: Remove variable set but not used
......................................................................

Patch Set 1: Code-Review-1

"volatile" prevents the compiler from optimizing out the "unused" read value. It seems to be intended here. Also see CB:32948 CB:32939 CB:32938

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32941 )

Change subject: nb/intel/pineview/raminit.c: Remove variable set but not used
......................................................................

Patch Set 1: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32941 )

Change subject: nb/intel/pineview/raminit.c: Remove variable set but not used
......................................................................

Patch Set 1: -Code-Review
> Patch Set 1: Code-Review-1
>
> "volatile" prevents the compiler from optimizing out the "unused" read value. It seems to be intended here. Also see CB:32948 CB:32939 CB:32938

Shouldn't be an issue because read32() has a "volatile" in it already.

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32941 )

Change subject: nb/intel/pineview/raminit.c: Remove variable set but not used
......................................................................

Patch Set 3: Code-Review+2

[Felix Held (Code Review)]

Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32941 )

Change subject: nb/intel/pineview/raminit.c: Remove variable set but not used
......................................................................

nb/intel/pineview/raminit.c: Remove variable set but not used

Change-Id: I4faf698e904c461803e867d212c31958119cc0ca
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32941
Reviewed-by: Felix Held 
Reviewed-by: Kyösti Mälkki 
Tested-by: build bot (Jenkins) 
---
M src/northbridge/intel/pineview/raminit.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, but someone else must approve
  Felix Held: Looks good to me, approved

diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c
index 282765e..72063cb 100644
--- a/src/northbridge/intel/pineview/raminit.c
+++ b/src/northbridge/intel/pineview/raminit.c
@@ -1835,7 +1835,6 @@

static u8 sampledqs(u32 dqshighaddr, u32 strobeaddr, u8 highlow, u8 count)
 {
-	volatile u32 strobedata;
    u8 dqsmatches = 1;
    while (count--) {
    	MCHBAR8(0x5d8) = MCHBAR8(0x5d8) & ~0x2;
@@ -1843,7 +1842,7 @@
    	MCHBAR8(0x5d8) = MCHBAR8(0x5d8) | 0x2;
    	hpet_udelay(1);
    	barrier();
-		strobedata = read32((void *)strobeaddr);
+		read32((void *)strobeaddr);
    	barrier();
    	hpet_udelay(1);