Patch Set 1: Code-Review-1
"volatile" prevents the compiler from optimizing out the "unused" read value. It seems to be intended here. Also see CB:32948 CB:32939 CB:32938
Shouldn't be an issue because read32() has a "volatile" in it already.
Patch set 1:-Code-Review
View Change
To view, visit change 32941. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4faf698e904c461803e867d212c31958119cc0ca
Gerrit-Change-Number: 32941
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Comment-Date: Fri, 24 May 2019 14:20:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment