Change in coreboot[master]: include/acpi/acpi.h: Convert to 96 characters line length

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43056 )

Change subject: include/acpi/acpi.h: Convert to 96 characters line length
......................................................................

include/acpi/acpi.h: Convert to 96 characters line length

Change-Id: I087126579d253b7873ffdae87c9f14892166d1f7
Signed-off-by: Elyes HAOUAS 
---
M src/include/acpi/acpi.h
1 file changed, 34 insertions(+), 54 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/43056/1

diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h
index 05d2197..cab656c 100644
--- a/src/include/acpi/acpi.h
+++ b/src/include/acpi/acpi.h
@@ -916,38 +916,30 @@
 void acpi_add_table(acpi_rsdp_t *rsdp, void *table);

int acpi_create_madt_lapic(acpi_madt_lapic_t *lapic, u8 cpu, u8 apic);
-int acpi_create_madt_ioapic(acpi_madt_ioapic_t *ioapic, u8 id, u32 addr,
-			    u32 gsi_base);
-int acpi_create_madt_irqoverride(acpi_madt_irqoverride_t *irqoverride,
-				 u8 bus, u8 source, u32 gsirq, u16 flags);
-int acpi_create_madt_lapic_nmi(acpi_madt_lapic_nmi_t *lapic_nmi, u8 cpu,
-			       u16 flags, u8 lint);
+int acpi_create_madt_ioapic(acpi_madt_ioapic_t *ioapic, u8 id, u32 addr, u32 gsi_base);
+int acpi_create_madt_irqoverride(acpi_madt_irqoverride_t *irqoverride, u8 bus, u8 source,
+				 u32 gsirq, u16 flags);
+int acpi_create_madt_lapic_nmi(acpi_madt_lapic_nmi_t *lapic_nmi, u8 cpu, u16 flags, u8 lint);
 void acpi_create_madt(acpi_madt_t *madt);
 unsigned long acpi_create_madt_lapics(unsigned long current);
-unsigned long acpi_create_madt_lapic_nmis(unsigned long current, u16 flags,
-					  u8 lint);
+unsigned long acpi_create_madt_lapic_nmis(unsigned long current, u16 flags, u8 lint);
 int acpi_create_madt_lx2apic(acpi_madt_lx2apic_t *lapic, u32 cpu, u32 apic);
-int acpi_create_madt_lx2apic_nmi(acpi_madt_lx2apic_nmi_t *lapic_nmi, u32 cpu,
-				 u16 flags, u8 lint);
+int acpi_create_madt_lx2apic_nmi(acpi_madt_lx2apic_nmi_t *lapic_nmi, u32 cpu, u16 flags,
+				 u8 lint);
 int acpi_create_srat_lapic(acpi_srat_lapic_t *lapic, u8 node, u8 apic);
-int acpi_create_srat_mem(acpi_srat_mem_t *mem, u8 node, u32 basek, u32 sizek,
-			 u32 flags);
+int acpi_create_srat_mem(acpi_srat_mem_t *mem, u8 node, u32 basek, u32 sizek, u32 flags);
 int acpi_create_srat_lx2apic(acpi_srat_lx2apic_t *lx2apic, u8 node, u8 x2apic);
 int acpi_create_srat_gicc(acpi_srat_gicc_t *gicc, u8 node, u8 cpu);
-int acpi_create_mcfg_mmconfig(acpi_mcfg_mmconfig_t *mmconfig, u32 base,
-			      u16 seg_nr, u8 start, u8 end);
+int acpi_create_mcfg_mmconfig(acpi_mcfg_mmconfig_t *mmconfig, u32 base, u16 seg_nr, u8 start,
+			      u8 end);
 unsigned long acpi_create_srat_lapics(unsigned long current);
-void acpi_create_srat(acpi_srat_t *srat,
-		      unsigned long (*acpi_fill_srat)(unsigned long current));
+void acpi_create_srat(acpi_srat_t *srat, unsigned long (*acpi_fill_srat)(unsigned long current));

-void acpi_create_slit(acpi_slit_t *slit,
-		      unsigned long (*acpi_fill_slit)(unsigned long current));
+void acpi_create_slit(acpi_slit_t *slit, unsigned long (*acpi_fill_slit)(unsigned long current));

-void acpi_create_vfct(const struct device *device,
-		      acpi_vfct_t *vfct,
+void acpi_create_vfct(const struct device *device, acpi_vfct_t *vfct,
    	      unsigned long (*acpi_fill_vfct)(const struct device *device,
-				acpi_vfct_t *vfct_struct,
-				unsigned long current));
+					acpi_vfct_t *vfct_struct, unsigned long current));

void acpi_create_ipmi(const struct device *device,
    	      struct acpi_spmi *spmi,
@@ -973,43 +965,32 @@

void acpi_create_facs(acpi_facs_t *facs);

-void acpi_create_dbg2(acpi_dbg2_header_t *dbg2_header,
-		      int port_type, int port_subtype,
-		      acpi_addr_t *address, uint32_t address_size,
-		      const char *device_path);
+void acpi_create_dbg2(acpi_dbg2_header_t *dbg2_header, int port_type, int port_subtype,
+		      acpi_addr_t *address, uint32_t address_size, const char *device_path);

unsigned long acpi_write_dbg2_pci_uart(acpi_rsdp_t *rsdp, unsigned long current,
    			const struct device *dev, uint8_t access_size);
 void acpi_create_dmar(acpi_dmar_t *dmar, enum dmar_flags flags,
    	      unsigned long (*acpi_fill_dmar)(unsigned long));
-unsigned long acpi_create_dmar_drhd(unsigned long current, u8 flags,
-				    u16 segment, u64 bar);
-unsigned long acpi_create_dmar_rmrr(unsigned long current, u16 segment,
-				    u64 bar, u64 limit);
-unsigned long acpi_create_dmar_atsr(unsigned long current, u8 flags,
-				    u16 segment);
-unsigned long acpi_create_dmar_rhsa(unsigned long current, u64 base_addr,
-				    u32 proximity_domain);
+unsigned long acpi_create_dmar_drhd(unsigned long current, u8 flags, u16 segment, u64 bar);
+unsigned long acpi_create_dmar_rmrr(unsigned long current, u16 segment, u64 bar, u64 limit);
+unsigned long acpi_create_dmar_atsr(unsigned long current, u8 flags, u16 segment);
+unsigned long acpi_create_dmar_rhsa(unsigned long current, u64 base_addr, u32 proximity_domain);
 unsigned long acpi_create_dmar_andd(unsigned long current, u8 device_number,
    			    const char *device_name);
 void acpi_dmar_drhd_fixup(unsigned long base, unsigned long current);
 void acpi_dmar_rmrr_fixup(unsigned long base, unsigned long current);
 void acpi_dmar_atsr_fixup(unsigned long base, unsigned long current);
-unsigned long acpi_create_dmar_ds_pci_br(unsigned long current,
-					   u8 bus, u8 dev, u8 fn);
-unsigned long acpi_create_dmar_ds_pci(unsigned long current,
-					   u8 bus, u8 dev, u8 fn);
-unsigned long acpi_create_dmar_ds_ioapic(unsigned long current,
-					      u8 enumeration_id,
-					      u8 bus, u8 dev, u8 fn);
-unsigned long acpi_create_dmar_ds_msi_hpet(unsigned long current,
-						u8 enumeration_id,
-						u8 bus, u8 dev, u8 fn);
-void acpi_write_hest(acpi_hest_t *hest,
-		     unsigned long (*acpi_fill_hest)(acpi_hest_t *hest));
+unsigned long acpi_create_dmar_ds_pci_br(unsigned long current, u8 bus, u8 dev, u8 fn);
+unsigned long acpi_create_dmar_ds_pci(unsigned long current, u8 bus, u8 dev, u8 fn);
+unsigned long acpi_create_dmar_ds_ioapic(unsigned long current, u8 enumeration_id, u8 bus,
+					 u8 dev, u8 fn);
+unsigned long acpi_create_dmar_ds_msi_hpet(unsigned long current, u8 enumeration_id, u8 bus,
+					   u8 dev, u8 fn);
+void acpi_write_hest(acpi_hest_t *hest, unsigned long (*acpi_fill_hest)(acpi_hest_t *hest));

-unsigned long acpi_create_hest_error_source(acpi_hest_t *hest,
-	acpi_hest_esd_t *esd, u16 type, void *data, u16 len);
+unsigned long acpi_create_hest_error_source(acpi_hest_t *hest, acpi_hest_esd_t *esd, u16 type,
+					    void *data, u16 len);

/* For ACPI S3 support. */
 void acpi_resume(void *wake_vec);
@@ -1026,8 +1007,7 @@
    ACPI_S5 = 5,
 };

-#if CONFIG(ACPI_INTEL_HARDWARE_SLEEP_VALUES) \
-		|| CONFIG(ACPI_AMD_HARDWARE_SLEEP_VALUES)
+#if CONFIG(ACPI_INTEL_HARDWARE_SLEEP_VALUES) || CONFIG(ACPI_AMD_HARDWARE_SLEEP_VALUES)
 /* Given the provided PM1 control register return the ACPI sleep type. */
 static inline int acpi_sleep_from_pm1(uint32_t pm1_cnt)
 {
@@ -1084,10 +1064,10 @@
    return ALIGN_UP(current, 16);
 }

-/* ACPI table revisions should match the revision of the ACPI spec
- * supported. This function keeps the table versions synced. This could
- * be made into a weak function if there is ever a need to override the
- * coreboot default ACPI spec version supported. */
+/* ACPI table revisions should match the revision of the ACPI spec supported. This function
+ * keeps the table versions synced. This could be made into a weak function if there is ever a
+ * need to override the coreboot default ACPI spec version supported.
+ */
 int get_acpi_table_revision(enum acpi_tables table);

#endif  // !defined(__ASSEMBLER__) && !defined(__ACPI__)

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43056 )

Change subject: include/acpi/acpi.h: Convert to 96 characters line length
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/43056/1/src/include/acpi/acpi.h 
File src/include/acpi/acpi.h:

https://review.coreboot.org/c/coreboot/+/43056/1/src/include/acpi/acpi.h@936 
PS1, Line 936: void acpi_create_srat(acpi_srat_t *srat, unsigned long (*acpi_fill_srat)(unsigned long current));
line over 96 characters

https://review.coreboot.org/c/coreboot/+/43056/1/src/include/acpi/acpi.h@938 
PS1, Line 938: void acpi_create_slit(acpi_slit_t *slit, unsigned long (*acpi_fill_slit)(unsigned long current));
line over 96 characters

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43056 )

Change subject: include/acpi/acpi.h: Convert to 96 characters line length
......................................................................

Abandoned