HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42249 )
Change subject: src: Write FADT minor version at 'acpi_create_fadt()' ......................................................................
src: Write FADT minor version at 'acpi_create_fadt()'
Change-Id: I5eb12e298bc050c629c3184eb6bb8b6f046fee2b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/acpi/acpi.c M src/soc/amd/picasso/acpi.c M src/soc/amd/stoneyridge/acpi.c M src/southbridge/amd/agesa/hudson/fadt.c M src/southbridge/amd/cimx/sb800/fadt.c M src/southbridge/amd/pi/hudson/fadt.c 6 files changed, 2 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/42249/1
diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index 47f03c8..a4ea24b 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1239,6 +1239,8 @@ memcpy(header->asl_compiler_id, ASLC, 4); header->asl_compiler_revision = asl_revision;
+ fadt->FADT_MinorVersion = 0; + fadt->firmware_ctrl = (unsigned long) facs; fadt->x_firmware_ctl_l = (unsigned long)facs; fadt->x_firmware_ctl_h = 0; diff --git a/src/soc/amd/picasso/acpi.c b/src/soc/amd/picasso/acpi.c index fe5879c..18626ff 100644 --- a/src/soc/amd/picasso/acpi.c +++ b/src/soc/amd/picasso/acpi.c @@ -149,7 +149,6 @@ fadt->reset_value = 6;
fadt->ARM_boot_arch = 0; /* MUST be 0 ACPI 3.0 */ - fadt->FADT_MinorVersion = 0; /* MUST be 0 ACPI 3.0 */
fadt->x_firmware_ctl_l = 0; /* set to 0 if firmware_ctrl is used */ fadt->x_firmware_ctl_h = 0; diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c index ea67aa3..2898704 100644 --- a/src/soc/amd/stoneyridge/acpi.c +++ b/src/soc/amd/stoneyridge/acpi.c @@ -121,7 +121,6 @@ fadt->reset_value = 6;
fadt->ARM_boot_arch = 0; /* MUST be 0 ACPI 3.0 */ - fadt->FADT_MinorVersion = 0; /* MUST be 0 ACPI 3.0 */
fadt->x_firmware_ctl_l = 0; /* set to 0 if firmware_ctrl is used */ fadt->x_firmware_ctl_h = 0; diff --git a/src/southbridge/amd/agesa/hudson/fadt.c b/src/southbridge/amd/agesa/hudson/fadt.c index 719eb54..9fd3141 100644 --- a/src/southbridge/amd/agesa/hudson/fadt.c +++ b/src/southbridge/amd/agesa/hudson/fadt.c @@ -87,7 +87,6 @@ fadt->reset_value = 6;
fadt->ARM_boot_arch = 0; /* MUST be 0 ACPI 3.0 */ - fadt->FADT_MinorVersion = 0; /* MUST be 0 ACPI 3.0 */
fadt->x_pm1a_evt_blk.space_id = ACPI_ADDRESS_SPACE_IO; fadt->x_pm1a_evt_blk.bit_width = 32; diff --git a/src/southbridge/amd/cimx/sb800/fadt.c b/src/southbridge/amd/cimx/sb800/fadt.c index ba277f9..2ecac2e 100644 --- a/src/southbridge/amd/cimx/sb800/fadt.c +++ b/src/southbridge/amd/cimx/sb800/fadt.c @@ -110,7 +110,6 @@ fadt->reset_value = 6;
fadt->ARM_boot_arch = 0; /* MUST be 0 ACPI 3.0 */ - fadt->FADT_MinorVersion = 0; /* MUST be 0 ACPI 3.0 */
fadt->x_pm1a_evt_blk.space_id = ACPI_ADDRESS_SPACE_IO; fadt->x_pm1a_evt_blk.bit_width = 32; diff --git a/src/southbridge/amd/pi/hudson/fadt.c b/src/southbridge/amd/pi/hudson/fadt.c index 8ed0330..b61ec20 100644 --- a/src/southbridge/amd/pi/hudson/fadt.c +++ b/src/southbridge/amd/pi/hudson/fadt.c @@ -87,7 +87,6 @@ fadt->reset_value = 6;
fadt->ARM_boot_arch = 0; /* MUST be 0 ACPI 3.0 */ - fadt->FADT_MinorVersion = 0; /* MUST be 0 ACPI 3.0 */
fadt->x_firmware_ctl_l = 0; /* set to 0 if firmware_ctrl is used */ fadt->x_firmware_ctl_h = 0;
Hello Kyösti Mälkki,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42249
to look at the new patch set (#2).
Change subject: src: Write FADT minor version at 'acpi_create_fadt()' ......................................................................
src: Write FADT minor version at 'acpi_create_fadt()'
Also correct the comment about minor version. For ACPI version 5.1, the FADT minor version is 1, not zero.
Change-Id: I5eb12e298bc050c629c3184eb6bb8b6f046fee2b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/acpi/acpi.c M src/include/acpi/acpi.h M src/soc/amd/picasso/acpi.c M src/soc/amd/stoneyridge/acpi.c M src/southbridge/amd/agesa/hudson/fadt.c M src/southbridge/amd/cimx/sb800/fadt.c M src/southbridge/amd/pi/hudson/fadt.c 7 files changed, 3 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/42249/2
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42249 )
Change subject: src: Write FADT minor version at 'acpi_create_fadt()' ......................................................................
Abandoned
Merge Conflict
HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/42249 )
Change subject: src: Write FADT minor version at 'acpi_create_fadt()' ......................................................................
Restored
Hello build bot (Jenkins), Kyösti Mälkki,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42249
to look at the new patch set (#3).
Change subject: src: Write FADT minor version at 'acpi_create_fadt()' ......................................................................
src: Write FADT minor version at 'acpi_create_fadt()'
Change-Id: I5eb12e298bc050c629c3184eb6bb8b6f046fee2b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/acpi/acpi.c M src/include/acpi/acpi.h M src/soc/amd/picasso/acpi.c M src/soc/amd/stoneyridge/acpi.c M src/southbridge/amd/agesa/hudson/fadt.c M src/southbridge/amd/cimx/sb800/fadt.c M src/southbridge/amd/pi/hudson/fadt.c 7 files changed, 2 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/42249/3
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42249 )
Change subject: src: Write FADT minor version at 'acpi_create_fadt()' ......................................................................
Patch Set 4: Code-Review+1
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42249 )
Change subject: src: Write FADT minor version at 'acpi_create_fadt()' ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review) -
Paul Menzel (Code Review)