Hello Seunghwan Kim,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/39126
to review the following change.
Change subject: mb/google/kohaku: Update SPD usage ......................................................................
mb/google/kohaku: Update SPD usage
To support new memory component on kohaku
BUG=b:149775711 BRANCH=firmware-hatch-12672.B TEST=emerge-hatch coreboot
Signed-off-by: Seunghwan Kim sh_.kim@samsung.com Change-Id: I856d7b361e70b657966cd4036c79f2fedfabb766 --- M src/mainboard/google/hatch/variants/kohaku/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/39126/1
diff --git a/src/mainboard/google/hatch/variants/kohaku/Makefile.inc b/src/mainboard/google/hatch/variants/kohaku/Makefile.inc index 6bd2973..3fb352d 100644 --- a/src/mainboard/google/hatch/variants/kohaku/Makefile.inc +++ b/src/mainboard/google/hatch/variants/kohaku/Makefile.inc @@ -13,6 +13,7 @@ ##
SPD_SOURCES = LP_8G_2133 # 0b000 +SPD_SOURCES += LP_16G_2133 # 0b001
romstage-y += memory.c
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39126 )
Change subject: mb/google/kohaku: Update SPD usage ......................................................................
Patch Set 1: Code-Review+2
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39126 )
Change subject: mb/google/kohaku: Update SPD usage ......................................................................
Patch Set 1: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/39126/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39126/1//COMMIT_MSG@7 PS1, Line 7: Update SPD usage Actually, can you update the message to say that you are adding LP DDR3 16G 2133 DRAM support?
Hello Seunghwan Kim, Philip Chen, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39126
to look at the new patch set (#2).
Change subject: mb/google/kohaku: Update SPD usage ......................................................................
mb/google/kohaku: Update SPD usage
To support new memory component on kohaku - LPDDR3 16G 2133
BUG=b:149775711 BRANCH=firmware-hatch-12672.B TEST=emerge-hatch coreboot
Signed-off-by: Seunghwan Kim sh_.kim@samsung.com Change-Id: I856d7b361e70b657966cd4036c79f2fedfabb766 --- M src/mainboard/google/hatch/variants/kohaku/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/39126/2
shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39126 )
Change subject: mb/google/kohaku: Update SPD usage ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39126/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39126/1//COMMIT_MSG@7 PS1, Line 7: Update SPD usage
Actually, can you update the message to say that you are adding LP DDR3 16G 2133 DRAM support?
Done
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39126 )
Change subject: mb/google/kohaku: Update SPD usage ......................................................................
Patch Set 2: Code-Review+2
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39126 )
Change subject: mb/google/kohaku: Update SPD usage ......................................................................
Patch Set 2: Code-Review+2
Thanks!
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39126 )
Change subject: mb/google/kohaku: Update SPD usage ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39126/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39126/2//COMMIT_MSG@7 PS2, Line 7: mb/google/kohaku: Update SPD usage Suggest more details in title. Suggest: Add LPDDR 16G 2133 support
Hello Seunghwan Kim, Philip Chen, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39126
to look at the new patch set (#3).
Change subject: mb/google/kohaku: Add LPDDR 16G 2133 support ......................................................................
mb/google/kohaku: Add LPDDR 16G 2133 support
BUG=b:149775711 BRANCH=firmware-hatch-12672.B TEST=emerge-hatch coreboot
Signed-off-by: Seunghwan Kim sh_.kim@samsung.com Change-Id: I856d7b361e70b657966cd4036c79f2fedfabb766 --- M src/mainboard/google/hatch/variants/kohaku/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/39126/3
shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39126 )
Change subject: mb/google/kohaku: Add LPDDR 16G 2133 support ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39126/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39126/2//COMMIT_MSG@7 PS2, Line 7: mb/google/kohaku: Update SPD usage
Suggest more details in title. […]
Done
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39126 )
Change subject: mb/google/kohaku: Add LPDDR 16G 2133 support ......................................................................
Patch Set 3: Code-Review+2
shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39126 )
Change subject: mb/google/kohaku: Add LPDDR 16G 2133 support ......................................................................
Patch Set 3:
Can we submit this change to merge?
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39126 )
Change subject: mb/google/kohaku: Add LPDDR 16G 2133 support ......................................................................
mb/google/kohaku: Add LPDDR 16G 2133 support
BUG=b:149775711 BRANCH=firmware-hatch-12672.B TEST=emerge-hatch coreboot
Signed-off-by: Seunghwan Kim sh_.kim@samsung.com Change-Id: I856d7b361e70b657966cd4036c79f2fedfabb766 Reviewed-on: https://review.coreboot.org/c/coreboot/+/39126 Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Shelley Chen shchen@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/kohaku/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Shelley Chen: Looks good to me, approved Frans Hendriks: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/kohaku/Makefile.inc b/src/mainboard/google/hatch/variants/kohaku/Makefile.inc index 6bd2973..3fb352d 100644 --- a/src/mainboard/google/hatch/variants/kohaku/Makefile.inc +++ b/src/mainboard/google/hatch/variants/kohaku/Makefile.inc @@ -13,6 +13,7 @@ ##
SPD_SOURCES = LP_8G_2133 # 0b000 +SPD_SOURCES += LP_16G_2133 # 0b001
romstage-y += memory.c
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39126 )
Change subject: mb/google/kohaku: Add LPDDR 16G 2133 support ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1014 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1013 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1012
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Frans Hendriks (Code Review)
-
Patrick Georgi (Code Review)
-
Shelley Chen (Code Review)
-
shkim (Code Review)
-
Tim Wawrzynczak (Code Review)