HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Get rid of wrong _ADR objects ......................................................................
src/mb: Get rid of wrong _ADR objects
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Change-Id: Id34af26db88b41aff2aa4f3f7b633460d8f4056a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/advansus/a785e-i/dsdt.asl M src/mainboard/amd/bimini_fam10/dsdt.asl M src/mainboard/amd/mahogany_fam10/dsdt.asl M src/mainboard/amd/tilapia_fam10/dsdt.asl M src/mainboard/amd/torpedo/dsdt.asl M src/mainboard/asus/kcma-d8/dsdt.asl M src/mainboard/asus/kfsn4-dre/dsdt.asl M src/mainboard/asus/kgpe-d16/dsdt.asl M src/mainboard/asus/m4a78-em/dsdt.asl M src/mainboard/asus/m4a785-m/dsdt.asl M src/mainboard/asus/m4a785t-m/dsdt.asl M src/mainboard/asus/m5a88-v/dsdt.asl M src/mainboard/avalue/eax-785e/dsdt.asl M src/mainboard/gigabyte/ma785gm/dsdt.asl M src/mainboard/gigabyte/ma785gmt/dsdt.asl M src/mainboard/gigabyte/ma78gm/dsdt.asl M src/mainboard/iei/kino-780am2-fam10/dsdt.asl M src/mainboard/intel/camelbackmountain_fsp/dsdt.asl M src/mainboard/jetway/pa78vm5/dsdt.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl M src/mainboard/lippert/toucan-af/dsdt.asl M src/mainboard/supermicro/h8scm_fam10/dsdt.asl 22 files changed, 0 insertions(+), 25 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/36317/1
diff --git a/src/mainboard/advansus/a785e-i/dsdt.asl b/src/mainboard/advansus/a785e-i/dsdt.asl index 8015ec6..2a9feb3 100644 --- a/src/mainboard/advansus/a785e-i/dsdt.asl +++ b/src/mainboard/advansus/a785e-i/dsdt.asl @@ -1125,7 +1125,6 @@ External (TOM1) External (TOM2) Name(_HID, EISAID("PNP0A03")) - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Method(_BBN, 0) { /* Bus number = 0 */ Return(0) } diff --git a/src/mainboard/amd/bimini_fam10/dsdt.asl b/src/mainboard/amd/bimini_fam10/dsdt.asl index c719622..fc58188 100644 --- a/src/mainboard/amd/bimini_fam10/dsdt.asl +++ b/src/mainboard/amd/bimini_fam10/dsdt.asl @@ -1125,7 +1125,6 @@ External (TOM1) External (TOM2) Name(_HID, EISAID("PNP0A03")) - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Method(_BBN, 0) { /* Bus number = 0 */ Return(0) } diff --git a/src/mainboard/amd/mahogany_fam10/dsdt.asl b/src/mainboard/amd/mahogany_fam10/dsdt.asl index 63748d7..7a07b05 100644 --- a/src/mainboard/amd/mahogany_fam10/dsdt.asl +++ b/src/mainboard/amd/mahogany_fam10/dsdt.asl @@ -1131,7 +1131,6 @@ External (TOM1) External (TOM2) Name(_HID, EISAID("PNP0A03")) - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Method(_BBN, 0) { /* Bus number = 0 */ Return(0) } diff --git a/src/mainboard/amd/tilapia_fam10/dsdt.asl b/src/mainboard/amd/tilapia_fam10/dsdt.asl index f9f7e18..aecc04f 100644 --- a/src/mainboard/amd/tilapia_fam10/dsdt.asl +++ b/src/mainboard/amd/tilapia_fam10/dsdt.asl @@ -1131,7 +1131,6 @@ External (TOM1) External (TOM2) /* (<real tom2> >> 20) to make it fit into 32 bit for XP */ Name(_HID, EISAID("PNP0A03")) - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Method(_BBN, 0) { /* Bus number = 0 */ Return(0) } diff --git a/src/mainboard/amd/torpedo/dsdt.asl b/src/mainboard/amd/torpedo/dsdt.asl index 48f8e1f..9b22311 100644 --- a/src/mainboard/amd/torpedo/dsdt.asl +++ b/src/mainboard/amd/torpedo/dsdt.asl @@ -773,7 +773,6 @@ External (TOM1) External (TOM2) Name(_HID, EISAID("PNP0A03")) - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Method(_BBN, 0) { /* Bus number = 0 */ Return(0) } diff --git a/src/mainboard/asus/kcma-d8/dsdt.asl b/src/mainboard/asus/kcma-d8/dsdt.asl index fedcad0..c1fa85f 100644 --- a/src/mainboard/asus/kcma-d8/dsdt.asl +++ b/src/mainboard/asus/kcma-d8/dsdt.asl @@ -126,7 +126,6 @@
Name (_HID, EisaId ("PNP0A08")) /* PCI-e root bus (SR5670) */ Name (_CID, EisaId ("PNP0A03")) /* PCI root bus (SP5100) */ - Name (_ADR, 0x00180001) Name (_UID, 0x00)
Name (HCIN, 0x00) // HC1 @@ -484,7 +483,6 @@ /* 0:14.3 SP5100 LPC */ Device (LPC) { Name (_HID, EisaId ("PNP0A05")) - Name (_ADR, 0x00140003)
/* Real Time Clock Device */ Device(RTC0) { diff --git a/src/mainboard/asus/kfsn4-dre/dsdt.asl b/src/mainboard/asus/kfsn4-dre/dsdt.asl index 4296a81..8c043ca 100644 --- a/src/mainboard/asus/kfsn4-dre/dsdt.asl +++ b/src/mainboard/asus/kfsn4-dre/dsdt.asl @@ -139,7 +139,6 @@
Name (_HID, EisaId ("PNP0A03")) Name (_ADR, 0x00180001) - Name (_UID, 0x00)
Name (HCIN, 0x00) // HC1
@@ -799,7 +798,6 @@
Device (LPC) { Name (_HID, EisaId ("PNP0A05")) - Name (_ADR, 0x00010000)
/* PS/2 keyboard (seems to be important for WinXP install) */ Device (KBD) diff --git a/src/mainboard/asus/kgpe-d16/dsdt.asl b/src/mainboard/asus/kgpe-d16/dsdt.asl index efb67a5..4eb7907 100644 --- a/src/mainboard/asus/kgpe-d16/dsdt.asl +++ b/src/mainboard/asus/kgpe-d16/dsdt.asl @@ -128,7 +128,6 @@
Name (_HID, EisaId ("PNP0A08")) /* PCI-e root bus (SR5690) */ Name (_CID, EisaId ("PNP0A03")) /* PCI root bus (SP5100) */ - Name (_ADR, 0x00180001) Name (_UID, 0x00)
Name (HCIN, 0x00) // HC1 @@ -484,7 +483,6 @@ /* 0:14.3 SP5100 LPC */ Device (LPC) { Name (_HID, EisaId ("PNP0A05")) - Name (_ADR, 0x00140003)
/* Real Time Clock Device */ Device(RTC0) { diff --git a/src/mainboard/asus/m4a78-em/dsdt.asl b/src/mainboard/asus/m4a78-em/dsdt.asl index eec3093..612c5da 100644 --- a/src/mainboard/asus/m4a78-em/dsdt.asl +++ b/src/mainboard/asus/m4a78-em/dsdt.asl @@ -1131,7 +1131,6 @@ External (TOM1) External (TOM2) /* (<real tom2> >> 20) to make it fit into 32 bit for XP */ Name(_HID, EISAID("PNP0A03")) - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Method(_BBN, 0) { /* Bus number = 0 */ Return(0) } diff --git a/src/mainboard/asus/m4a785-m/dsdt.asl b/src/mainboard/asus/m4a785-m/dsdt.asl index eec3093..612c5da 100644 --- a/src/mainboard/asus/m4a785-m/dsdt.asl +++ b/src/mainboard/asus/m4a785-m/dsdt.asl @@ -1131,7 +1131,6 @@ External (TOM1) External (TOM2) /* (<real tom2> >> 20) to make it fit into 32 bit for XP */ Name(_HID, EISAID("PNP0A03")) - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Method(_BBN, 0) { /* Bus number = 0 */ Return(0) } diff --git a/src/mainboard/asus/m4a785t-m/dsdt.asl b/src/mainboard/asus/m4a785t-m/dsdt.asl index 20d74d0..da6f7a4 100644 --- a/src/mainboard/asus/m4a785t-m/dsdt.asl +++ b/src/mainboard/asus/m4a785t-m/dsdt.asl @@ -1131,7 +1131,6 @@ External (TOM1) External (TOM2) /* (<real tom2> >> 20) to make it fit into 32 bit for XP */ Name(_HID, EISAID("PNP0A03")) - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Method(_BBN, 0) { /* Bus number = 0 */ Return(0) } diff --git a/src/mainboard/asus/m5a88-v/dsdt.asl b/src/mainboard/asus/m5a88-v/dsdt.asl index 3d2a781..b999c0b 100644 --- a/src/mainboard/asus/m5a88-v/dsdt.asl +++ b/src/mainboard/asus/m5a88-v/dsdt.asl @@ -1125,7 +1125,6 @@ External (TOM1) External (TOM2) Name(_HID, EISAID("PNP0A03")) - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Method(_BBN, 0) { /* Bus number = 0 */ Return(0) } diff --git a/src/mainboard/avalue/eax-785e/dsdt.asl b/src/mainboard/avalue/eax-785e/dsdt.asl index 8015ec6..2a9feb3 100644 --- a/src/mainboard/avalue/eax-785e/dsdt.asl +++ b/src/mainboard/avalue/eax-785e/dsdt.asl @@ -1125,7 +1125,6 @@ External (TOM1) External (TOM2) Name(_HID, EISAID("PNP0A03")) - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Method(_BBN, 0) { /* Bus number = 0 */ Return(0) } diff --git a/src/mainboard/gigabyte/ma785gm/dsdt.asl b/src/mainboard/gigabyte/ma785gm/dsdt.asl index eec3093..612c5da 100644 --- a/src/mainboard/gigabyte/ma785gm/dsdt.asl +++ b/src/mainboard/gigabyte/ma785gm/dsdt.asl @@ -1131,7 +1131,6 @@ External (TOM1) External (TOM2) /* (<real tom2> >> 20) to make it fit into 32 bit for XP */ Name(_HID, EISAID("PNP0A03")) - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Method(_BBN, 0) { /* Bus number = 0 */ Return(0) } diff --git a/src/mainboard/gigabyte/ma785gmt/dsdt.asl b/src/mainboard/gigabyte/ma785gmt/dsdt.asl index eec3093..612c5da 100644 --- a/src/mainboard/gigabyte/ma785gmt/dsdt.asl +++ b/src/mainboard/gigabyte/ma785gmt/dsdt.asl @@ -1131,7 +1131,6 @@ External (TOM1) External (TOM2) /* (<real tom2> >> 20) to make it fit into 32 bit for XP */ Name(_HID, EISAID("PNP0A03")) - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Method(_BBN, 0) { /* Bus number = 0 */ Return(0) } diff --git a/src/mainboard/gigabyte/ma78gm/dsdt.asl b/src/mainboard/gigabyte/ma78gm/dsdt.asl index eec3093..612c5da 100644 --- a/src/mainboard/gigabyte/ma78gm/dsdt.asl +++ b/src/mainboard/gigabyte/ma78gm/dsdt.asl @@ -1131,7 +1131,6 @@ External (TOM1) External (TOM2) /* (<real tom2> >> 20) to make it fit into 32 bit for XP */ Name(_HID, EISAID("PNP0A03")) - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Method(_BBN, 0) { /* Bus number = 0 */ Return(0) } diff --git a/src/mainboard/iei/kino-780am2-fam10/dsdt.asl b/src/mainboard/iei/kino-780am2-fam10/dsdt.asl index ffbe3ac..043332e 100644 --- a/src/mainboard/iei/kino-780am2-fam10/dsdt.asl +++ b/src/mainboard/iei/kino-780am2-fam10/dsdt.asl @@ -1131,7 +1131,6 @@ External (TOM1) External (TOM2) Name(_HID, EISAID("PNP0A03")) - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Method(_BBN, 0) { /* Bus number = 0 */ Return(0) } diff --git a/src/mainboard/intel/camelbackmountain_fsp/dsdt.asl b/src/mainboard/intel/camelbackmountain_fsp/dsdt.asl index 1248703..76845f5 100644 --- a/src/mainboard/intel/camelbackmountain_fsp/dsdt.asl +++ b/src/mainboard/intel/camelbackmountain_fsp/dsdt.asl @@ -261,7 +261,6 @@ Return (0xff) }
- Name (_ADR, 0x00) Method (_STA, 0, NotSerialized) { Return (0xf) diff --git a/src/mainboard/jetway/pa78vm5/dsdt.asl b/src/mainboard/jetway/pa78vm5/dsdt.asl index 89120c7..96eafe1 100644 --- a/src/mainboard/jetway/pa78vm5/dsdt.asl +++ b/src/mainboard/jetway/pa78vm5/dsdt.asl @@ -1131,7 +1131,6 @@ External (TOM1) External (TOM2) /* (<real tom2> >> 20) to make it fit into 32 bit for XP */ Name(_HID, EISAID("PNP0A03")) - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Method(_BBN, 0) { /* Bus number = 0 */ Return(0) } diff --git a/src/mainboard/lippert/frontrunner-af/dsdt.asl b/src/mainboard/lippert/frontrunner-af/dsdt.asl index 07b5071..9fcc7ae 100644 --- a/src/mainboard/lippert/frontrunner-af/dsdt.asl +++ b/src/mainboard/lippert/frontrunner-af/dsdt.asl @@ -1124,7 +1124,6 @@ External (TOM2) Name(_HID, EISAID("PNP0A08")) /* PCI Express Root Bridge */ Name(_CID, EISAID("PNP0A03")) /* PCI Root Bridge */ - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */
/* Operating System Capabilities Method */ Method (_OSC, 4) diff --git a/src/mainboard/lippert/toucan-af/dsdt.asl b/src/mainboard/lippert/toucan-af/dsdt.asl index 347f1a1..4e36c2b 100644 --- a/src/mainboard/lippert/toucan-af/dsdt.asl +++ b/src/mainboard/lippert/toucan-af/dsdt.asl @@ -1123,7 +1123,6 @@ External (TOM2) Name(_HID, EISAID("PNP0A08")) /* PCI Express Root Bridge */ Name(_CID, EISAID("PNP0A03")) /* PCI Root Bridge */ - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */
/* Operating System Capabilities Method */ Method (_OSC, 4) diff --git a/src/mainboard/supermicro/h8scm_fam10/dsdt.asl b/src/mainboard/supermicro/h8scm_fam10/dsdt.asl index 4dfa999..c61a7f3 100644 --- a/src/mainboard/supermicro/h8scm_fam10/dsdt.asl +++ b/src/mainboard/supermicro/h8scm_fam10/dsdt.asl @@ -1141,7 +1141,6 @@ External (TOM1) External (TOM2) /* (<real tom2> >> 20) to make it fit into 32 bit for XP */ Name(_HID, EISAID("PNP0A03")) - Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Method(_BBN, 0) { /* Bus number = 0 */ Return(0) }
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Get rid of wrong _ADR objects ......................................................................
Patch Set 1: Code-Review+2
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Get rid of wrong _ADR objects ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36317/1/src/mainboard/asus/kfsn4-dr... File src/mainboard/asus/kfsn4-dre/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/36317/1/src/mainboard/asus/kfsn4-dr... PS1, Line 141: Name (_ADR, 0x00180001) Did you mean to delete this line instead?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Get rid of wrong _ADR objects ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36317/1/src/mainboard/asus/kfsn4-dr... File src/mainboard/asus/kfsn4-dre/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/36317/1/src/mainboard/asus/kfsn4-dr... PS1, Line 141: Name (_ADR, 0x00180001)
Did you mean to delete this line instead?
Thank you
Hello Philipp Deppenwiese, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36317
to look at the new patch set (#2).
Change subject: src/mb: Get rid of wrong _ADR objects ......................................................................
src/mb: Get rid of wrong _ADR objects
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Change-Id: Id34af26db88b41aff2aa4f3f7b633460d8f4056a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/advansus/a785e-i/dsdt.asl M src/mainboard/amd/bimini_fam10/dsdt.asl M src/mainboard/amd/mahogany_fam10/dsdt.asl M src/mainboard/amd/tilapia_fam10/dsdt.asl M src/mainboard/amd/torpedo/dsdt.asl M src/mainboard/asus/kcma-d8/dsdt.asl M src/mainboard/asus/kfsn4-dre/dsdt.asl M src/mainboard/asus/kgpe-d16/dsdt.asl M src/mainboard/asus/m4a78-em/dsdt.asl M src/mainboard/asus/m4a785-m/dsdt.asl M src/mainboard/asus/m4a785t-m/dsdt.asl M src/mainboard/asus/m5a88-v/dsdt.asl M src/mainboard/avalue/eax-785e/dsdt.asl M src/mainboard/gigabyte/ma785gm/dsdt.asl M src/mainboard/gigabyte/ma785gmt/dsdt.asl M src/mainboard/gigabyte/ma78gm/dsdt.asl M src/mainboard/iei/kino-780am2-fam10/dsdt.asl M src/mainboard/intel/camelbackmountain_fsp/dsdt.asl M src/mainboard/jetway/pa78vm5/dsdt.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl M src/mainboard/lippert/toucan-af/dsdt.asl M src/mainboard/supermicro/h8scm_fam10/dsdt.asl 22 files changed, 0 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/36317/2
Hello Philipp Deppenwiese, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36317
to look at the new patch set (#3).
Change subject: src/mb: Get rid of wrong _ADR objects ......................................................................
src/mb: Get rid of wrong _ADR objects
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Change-Id: Id34af26db88b41aff2aa4f3f7b633460d8f4056a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/advansus/a785e-i/dsdt.asl M src/mainboard/amd/bimini_fam10/dsdt.asl M src/mainboard/amd/mahogany_fam10/dsdt.asl M src/mainboard/amd/tilapia_fam10/dsdt.asl M src/mainboard/amd/torpedo/dsdt.asl M src/mainboard/asus/kcma-d8/dsdt.asl M src/mainboard/asus/kfsn4-dre/dsdt.asl M src/mainboard/asus/kgpe-d16/dsdt.asl M src/mainboard/asus/m4a78-em/dsdt.asl M src/mainboard/asus/m4a785-m/dsdt.asl M src/mainboard/asus/m4a785t-m/dsdt.asl M src/mainboard/asus/m5a88-v/dsdt.asl M src/mainboard/avalue/eax-785e/dsdt.asl M src/mainboard/gigabyte/ma785gm/dsdt.asl M src/mainboard/gigabyte/ma785gmt/dsdt.asl M src/mainboard/gigabyte/ma78gm/dsdt.asl M src/mainboard/iei/kino-780am2-fam10/dsdt.asl M src/mainboard/intel/camelbackmountain_fsp/dsdt.asl M src/mainboard/jetway/pa78vm5/dsdt.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl M src/mainboard/lippert/toucan-af/dsdt.asl M src/mainboard/supermicro/h8scm_fam10/dsdt.asl 22 files changed, 0 insertions(+), 25 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/36317/3
Hello Philipp Deppenwiese, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36317
to look at the new patch set (#4).
Change subject: src/mb: Get rid of wrong _ADR objects ......................................................................
src/mb: Get rid of wrong _ADR objects
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Change-Id: Id34af26db88b41aff2aa4f3f7b633460d8f4056a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/advansus/a785e-i/dsdt.asl M src/mainboard/amd/bimini_fam10/dsdt.asl M src/mainboard/amd/mahogany_fam10/dsdt.asl M src/mainboard/amd/tilapia_fam10/dsdt.asl M src/mainboard/amd/torpedo/dsdt.asl M src/mainboard/asus/kcma-d8/dsdt.asl M src/mainboard/asus/kfsn4-dre/dsdt.asl M src/mainboard/asus/kgpe-d16/dsdt.asl M src/mainboard/asus/m4a78-em/dsdt.asl M src/mainboard/asus/m4a785-m/dsdt.asl M src/mainboard/asus/m4a785t-m/dsdt.asl M src/mainboard/asus/m5a88-v/dsdt.asl M src/mainboard/avalue/eax-785e/dsdt.asl M src/mainboard/gigabyte/ma785gm/dsdt.asl M src/mainboard/gigabyte/ma785gmt/dsdt.asl M src/mainboard/gigabyte/ma78gm/dsdt.asl M src/mainboard/iei/kino-780am2-fam10/dsdt.asl M src/mainboard/intel/camelbackmountain_fsp/dsdt.asl M src/mainboard/jetway/pa78vm5/dsdt.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl M src/mainboard/lippert/toucan-af/dsdt.asl M src/mainboard/ocp/monolake/dsdt.asl M src/mainboard/ocp/wedge100s/dsdt.asl M src/mainboard/siemens/mc_bdx1/dsdt.asl M src/mainboard/supermicro/h8scm_fam10/dsdt.asl 25 files changed, 0 insertions(+), 28 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/36317/4
Hello Werner Zeh, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36317
to look at the new patch set (#5).
Change subject: src/mb: Get rid of wrong _ADR objects ......................................................................
src/mb: Get rid of wrong _ADR objects
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Change-Id: Id34af26db88b41aff2aa4f3f7b633460d8f4056a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/advansus/a785e-i/dsdt.asl M src/mainboard/amd/bimini_fam10/dsdt.asl M src/mainboard/amd/mahogany_fam10/dsdt.asl M src/mainboard/amd/tilapia_fam10/dsdt.asl M src/mainboard/amd/torpedo/dsdt.asl M src/mainboard/asus/kcma-d8/dsdt.asl M src/mainboard/asus/kfsn4-dre/dsdt.asl M src/mainboard/asus/kgpe-d16/dsdt.asl M src/mainboard/asus/m4a78-em/dsdt.asl M src/mainboard/asus/m4a785-m/dsdt.asl M src/mainboard/asus/m4a785t-m/dsdt.asl M src/mainboard/asus/m5a88-v/dsdt.asl M src/mainboard/avalue/eax-785e/dsdt.asl M src/mainboard/gigabyte/ma785gm/dsdt.asl M src/mainboard/gigabyte/ma785gmt/dsdt.asl M src/mainboard/gigabyte/ma78gm/dsdt.asl M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl M src/mainboard/iei/kino-780am2-fam10/dsdt.asl M src/mainboard/intel/camelbackmountain_fsp/dsdt.asl M src/mainboard/intel/strago/acpi/mainboard.asl M src/mainboard/jetway/pa78vm5/dsdt.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl M src/mainboard/lippert/toucan-af/dsdt.asl M src/mainboard/ocp/monolake/dsdt.asl M src/mainboard/ocp/wedge100s/dsdt.asl M src/mainboard/siemens/mc_bdx1/dsdt.asl M src/mainboard/supermicro/h8scm_fam10/dsdt.asl 27 files changed, 0 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/36317/5
Hello Werner Zeh, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36317
to look at the new patch set (#6).
Change subject: src/mb: Get rid of wrong _ADR objects ......................................................................
src/mb: Get rid of wrong _ADR objects
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Change-Id: Id34af26db88b41aff2aa4f3f7b633460d8f4056a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/advansus/a785e-i/dsdt.asl M src/mainboard/amd/bimini_fam10/dsdt.asl M src/mainboard/amd/mahogany_fam10/dsdt.asl M src/mainboard/amd/tilapia_fam10/dsdt.asl M src/mainboard/amd/torpedo/dsdt.asl M src/mainboard/aopen/dxplplusu/acpi/p64h2.asl M src/mainboard/asus/kcma-d8/dsdt.asl M src/mainboard/asus/kfsn4-dre/dsdt.asl M src/mainboard/asus/kgpe-d16/dsdt.asl M src/mainboard/asus/m4a78-em/dsdt.asl M src/mainboard/asus/m4a785-m/dsdt.asl M src/mainboard/asus/m4a785t-m/dsdt.asl M src/mainboard/asus/m5a88-v/dsdt.asl M src/mainboard/avalue/eax-785e/dsdt.asl M src/mainboard/gigabyte/ma785gm/dsdt.asl M src/mainboard/gigabyte/ma785gmt/dsdt.asl M src/mainboard/gigabyte/ma78gm/dsdt.asl M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl M src/mainboard/iei/kino-780am2-fam10/dsdt.asl M src/mainboard/intel/camelbackmountain_fsp/dsdt.asl M src/mainboard/intel/strago/acpi/mainboard.asl M src/mainboard/jetway/pa78vm5/dsdt.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl M src/mainboard/lippert/toucan-af/dsdt.asl M src/mainboard/ocp/monolake/dsdt.asl M src/mainboard/ocp/wedge100s/dsdt.asl M src/mainboard/siemens/mc_bdx1/dsdt.asl M src/mainboard/supermicro/h8scm_fam10/dsdt.asl 28 files changed, 0 insertions(+), 32 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/36317/6
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Get rid of wrong _ADR objects ......................................................................
Patch Set 6: Code-Review+2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Get rid of wrong _ADR objects ......................................................................
Patch Set 6:
Why did you choose to get rid of the _ADR objects instead of the _HID? I'm not saying it's incorrect, but it seems like _ADR is a more specific and useful description of the device than the Plug and Play Hardware ID.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Get rid of wrong _ADR objects ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36317/6/src/mainboard/advansus/a785... File src/mainboard/advansus/a785e-i/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/36317/6/src/mainboard/advansus/a785... PS6, Line 1128: Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Why did you choose to get rid of the _ADR objects instead of the _HID? I'm not saying it's incorrect, but it seems like _ADR is a more specific and useful description of the device than the Plug and Play Hardware ID.
Top level question moved into the source to prevent accidental merging before it's looked at.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Get rid of wrong _ADR objects ......................................................................
Patch Set 6: Code-Review-1
(1 comment)
-1 as I'm not sure and somehow confused
https://review.coreboot.org/c/coreboot/+/36317/6/src/mainboard/advansus/a785... File src/mainboard/advansus/a785e-i/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/36317/6/src/mainboard/advansus/a785... PS6, Line 1128: Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */
Why did you choose to get rid of the _ADR objects instead of the _HID? I'm not saying it's incorrec […]
By my understanding, only some legacy devices do need an _ADR. Maybe I'm wrong, but I think that PCI0 need a _HID.
this said,I'm confused by the 'Note' at line #1123, does it mean that the PCI (slot 24) is not the PCI0? if so maybe it should be as Device(PCI0) { External (TOM1) External (TOM2) Name(_HID, EISAID("PNP0A03")) Device (PCI ??) { Name(_ADR, 0x00180000) ..... }
HAOUAS Elyes has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Get rid of wrong _ADR objects ......................................................................
Removed Code-Review-1 by HAOUAS Elyes ehaouas@noos.fr
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Get rid of wrong _ADR objects ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36317/6/src/mainboard/advansus/a785... File src/mainboard/advansus/a785e-i/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/36317/6/src/mainboard/advansus/a785... PS6, Line 1128: Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */
By my understanding, only some legacy devices do need an _ADR. […]
My understanding here: ACPI specs version 6.3 - page #346, we have to use _ADR only for objects enumerated by enumerators other than Operating System-directed configuration and Power Management.
"_HID (Hardware ID) This object is used to supply OSPM with the device’s PNP ID or ACPI ID. 1 When describing a platform, use of any _HID objects is optional. However, a _HID object must be used to describe any device that will be enumerated by OSPM. OSPM only enumerates a device when no bus enumerator can detect the device ID. For example, devices on an ISA bus are enumerated by OSPM. Use the _ADR object to describe devices enumerated by bus enumerators other than OSPM."
Hello Werner Zeh, Patrick Rudolph, Stefan Reinauer, Philipp Deppenwiese, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36317
to look at the new patch set (#7).
Change subject: src/mb: Get rid of wrong _ADR objects ......................................................................
src/mb: Get rid of wrong _ADR objects
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Change-Id: Id34af26db88b41aff2aa4f3f7b633460d8f4056a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/aopen/dxplplusu/acpi/p64h2.asl M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl M src/mainboard/intel/strago/acpi/mainboard.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl M src/mainboard/lippert/toucan-af/dsdt.asl 5 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/36317/7
Hello Werner Zeh, Patrick Rudolph, Stefan Reinauer, Philipp Deppenwiese, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36317
to look at the new patch set (#8).
Change subject: src/mb: Get rid of wrong _ADR objects ......................................................................
src/mb: Get rid of wrong _ADR objects
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Change-Id: Id34af26db88b41aff2aa4f3f7b633460d8f4056a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/aopen/dxplplusu/acpi/p64h2.asl M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl M src/mainboard/intel/strago/acpi/mainboard.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl M src/mainboard/lippert/toucan-af/dsdt.asl 5 files changed, 3 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/36317/8
Hello Werner Zeh, Patrick Rudolph, Stefan Reinauer, Philipp Deppenwiese, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36317
to look at the new patch set (#9).
Change subject: src/mb: Don't use both of _ADR and _HID ......................................................................
src/mb: Don't use both of _ADR and _HID
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Change-Id: Id34af26db88b41aff2aa4f3f7b633460d8f4056a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/aopen/dxplplusu/acpi/p64h2.asl M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl M src/mainboard/intel/strago/acpi/mainboard.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl M src/mainboard/lippert/toucan-af/dsdt.asl 5 files changed, 3 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/36317/9
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Don't use both of _ADR and _HID ......................................................................
Patch Set 10: Code-Review+2
Hello Werner Zeh, Patrick Rudolph, Stefan Reinauer, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36317
to look at the new patch set (#11).
Change subject: src/mb: Don't use both of _ADR and _HID ......................................................................
src/mb: Don't use both of _ADR and _HID
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Change-Id: Id34af26db88b41aff2aa4f3f7b633460d8f4056a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/aopen/dxplplusu/acpi/p64h2.asl M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl M src/mainboard/intel/strago/acpi/mainboard.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl M src/mainboard/lippert/toucan-af/dsdt.asl 5 files changed, 4 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/36317/11
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Don't use both of _ADR and _HID ......................................................................
Patch Set 13:
(2 comments)
Unless somebody wants to dig deeper into these 1k+ lines DSDT files, I'd prefer this to be tested before it's merged.
https://review.coreboot.org/c/coreboot/+/36317/13/src/mainboard/lippert/fron... File src/mainboard/lippert/frontrunner-af/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/36317/13/src/mainboard/lippert/fron... PS13, Line 1127: Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ This seems wrong. It should be a device below PCI0.
https://review.coreboot.org/c/coreboot/+/36317/13/src/mainboard/lippert/touc... File src/mainboard/lippert/toucan-af/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/36317/13/src/mainboard/lippert/touc... PS13, Line 1126: Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Same here.
It's hard to tell which parts below PCI0 apply to PCI0 (the root) and which apply to the PCI device 18.0. However, as most of the devices presented below are on bus 0 and not below 18.0 (see devicetree), declaring this PCI0 to be the root seems to be the safer bet.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Don't use both of _ADR and _HID ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36317/12/src/mainboard/aopen/dxplpl... File src/mainboard/aopen/dxplplusu/acpi/p64h2.asl:
https://review.coreboot.org/c/coreboot/+/36317/12/src/mainboard/aopen/dxplpl... PS12, Line 21: /* Name (_HID, "ACPI000A") */ Why not removing the _HID lines?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Don't use both of _ADR and _HID ......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36317/12/src/mainboard/aopen/dxplpl... File src/mainboard/aopen/dxplplusu/acpi/p64h2.asl:
https://review.coreboot.org/c/coreboot/+/36317/12/src/mainboard/aopen/dxplpl... PS12, Line 21: /* Name (_HID, "ACPI000A") */
Why not removing the _HID lines?
not sure if the _ADR is correct , so maybe it needs test on real hardware.
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Don't use both of _ADR and _HID ......................................................................
Abandoned
HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Don't use both of _ADR and _HID ......................................................................
Restored
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Don't use both of _ADR and _HID ......................................................................
Abandoned
-
Frans Hendriks (Code Review) -
HAOUAS Elyes (Code Review)
-
Jacob Garber (Code Review)
-
Martin Roth (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Stefan Reinauer (Code Review)