-1 as I'm not sure and somehow confused
Patch set 6:Code-Review -1
1 comment:
File src/mainboard/advansus/a785e-i/dsdt.asl:
Patch Set #6, Line 1128: Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */
Why did you choose to get rid of the _ADR objects instead of the _HID? I'm not saying it's incorrec […]
By my understanding, only some legacy devices do need an _ADR.
Maybe I'm wrong, but I think that PCI0 need a _HID.
this said,I'm confused by the 'Note' at line #1123, does it mean that the PCI (slot 24) is not the PCI0?
if so maybe it should be as
Device(PCI0) {
External (TOM1)
External (TOM2)
Name(_HID, EISAID("PNP0A03"))
Device (PCI ??) {
Name(_ADR, 0x00180000)
.....
}
To view, visit change 36317. To unsubscribe, or for help writing mail filters, visit settings.