Meng-Huan Yu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48259 )
Change subject: libpayload: Unified the type of _start, _end in ARM64 mmu.h ......................................................................
libpayload: Unified the type of _start, _end in ARM64 mmu.h
The type of _start and _end symbols in depthcharge is "uint8_t", it will cause compile error if trying to includes arm64/arch/mmu.h from depthcharge.
BUG=b:171858277 TEST=Built on arm64 board emerge-asurada libpayload depthcharge
Signed-off-by: Meng-Huan Yu menghuan@google.com Change-Id: I5756f63f5cae22ecda6873c711bef16aeabc89f6 --- M payloads/libpayload/include/arm64/arch/mmu.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/48259/1
diff --git a/payloads/libpayload/include/arm64/arch/mmu.h b/payloads/libpayload/include/arm64/arch/mmu.h index 9ead5d6..1126e76 100644 --- a/payloads/libpayload/include/arm64/arch/mmu.h +++ b/payloads/libpayload/include/arm64/arch/mmu.h @@ -46,7 +46,7 @@ * Symbols taken from linker script * They mark the start and end of the region used by payload */ -extern char _start[], _end[]; +extern uint8_t _start, _end;
/* Memory attributes for mmap regions * These attributes act as tag values for memrange regions
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48259 )
Change subject: libpayload: Unified the type of _start, _end in ARM64 mmu.h ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48259/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48259/1//COMMIT_MSG@9 PS1, Line 9: , : it . It
https://review.coreboot.org/c/coreboot/+/48259/1//COMMIT_MSG@10 PS1, Line 10: includes include
Hello build bot (Jenkins), Julius Werner, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48259
to look at the new patch set (#2).
Change subject: libpayload: Unified the type of _start, _end in ARM64 mmu.h ......................................................................
libpayload: Unified the type of _start, _end in ARM64 mmu.h
The type of _start and _end symbols in depthcharge is "uint8_t". It will cause compile error if trying to include arm64/arch/mmu.h from depthcharge.
BUG=b:171858277 TEST=Built on arm64 board emerge-asurada libpayload depthcharge
Signed-off-by: Meng-Huan Yu menghuan@google.com Change-Id: I5756f63f5cae22ecda6873c711bef16aeabc89f6 --- M payloads/libpayload/include/arm64/arch/mmu.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/48259/2
Meng-Huan Yu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48259 )
Change subject: libpayload: Unified the type of _start, _end in ARM64 mmu.h ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48259/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48259/1//COMMIT_MSG@10 PS1, Line 10: includes
include
Done
https://review.coreboot.org/c/coreboot/+/48259/1//COMMIT_MSG@9 PS1, Line 9: , : it
. It
Done
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48259 )
Change subject: libpayload: Unified the type of _start, _end in ARM64 mmu.h ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48259/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48259/2//COMMIT_MSG@9 PS2, Line 9: The type of _start and _end symbols in depthcharge is "uint8_t". Can we fix depthcharge instead? I don't care about uint8_t vs char, but generally it is better to define these as arrays so that they do the right thing with or without an address-of operator in front of them (coreboot is doing it the same way).
Meng-Huan Yu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48259 )
Change subject: libpayload: Unified the type of _start, _end in ARM64 mmu.h ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48259/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48259/2//COMMIT_MSG@9 PS2, Line 9: The type of _start and _end symbols in depthcharge is "uint8_t".
Can we fix depthcharge instead? I don't care about uint8_t vs char, but generally it is better to de […]
Created https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+...
Meng-Huan Yu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48259 )
Change subject: libpayload: Unified the type of _start, _end in ARM64 mmu.h ......................................................................
Abandoned
https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+...
-
Julius Werner (Code Review) -
Meng-Huan Yu (Code Review)
-
Yu-Ping Wu (Code Review)