View Change
1 comment:
Commit Message:
Patch Set #2, Line 9: The type of _start and _end symbols in depthcharge is "uint8_t".
Can we fix depthcharge instead? I don't care about uint8_t vs char, but generally it is better to define these as arrays so that they do the right thing with or without an address-of operator in front of them (coreboot is doing it the same way).
To view, visit change 48259. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5756f63f5cae22ecda6873c711bef16aeabc89f6
Gerrit-Change-Number: 48259
Gerrit-PatchSet: 2
Gerrit-Owner: Meng-Huan Yu <menghuan@google.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sat, 05 Dec 2020 00:17:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment