Change in coreboot[master]: Signed-off-by: John Su <john_su@compal.corp-partner.google.com> Chang...
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50279 )
Change subject: Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: Iaaceaf58906871866ee050c6fc68445731744c33 ......................................................................
Patch Set 1:
(81 comments)
File src/mainboard/google/zork/variants/vilboz/variant.c:
https://review.coreboot.org/c/coreboot/+/50279/comment/6ff20e16_98c5352f PS1, Line 27: { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/a237319a_f63b0e00 PS1, Line 27: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/e5f062ad_19f63913 PS1, Line 28: // NVME SSD code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/b919139a_bbc0c3cd PS1, Line 29: .port_present = true, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/71697c0a_0be00a8e PS1, Line 29: .port_present = true, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/82119474_298c5acc PS1, Line 30: .engine_type = PCIE_ENGINE, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/bca4c0b8_67b060df PS1, Line 30: .engine_type = PCIE_ENGINE, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/edfeda7e_a6bf2164 PS1, Line 31: .start_logical_lane = 4, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/18308345_d792b6fd PS1, Line 31: .start_logical_lane = 4, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/f6785db1_845a2796 PS1, Line 32: .end_logical_lane = 5, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/dfd3a603_42641a74 PS1, Line 32: .end_logical_lane = 5, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/7b0b9f29_99634ad3 PS1, Line 33: .device_number = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/445c655e_a92baf95 PS1, Line 33: .device_number = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/e0f7a44d_2d4a827f PS1, Line 34: .function_number = 7, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/fb1f4aad_65ebfff1 PS1, Line 34: .function_number = 7, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/b51405a3_a8dc5345 PS1, Line 35: .link_aspm = ASPM_L1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/08202edc_3c3d8674 PS1, Line 35: .link_aspm = ASPM_L1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/ed6e7848_e5d4d17e PS1, Line 36: .link_aspm_L1_1 = true, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/e1da577b_a88c3916 PS1, Line 36: .link_aspm_L1_1 = true, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/5a280bf3_d513ae1a PS1, Line 37: .link_aspm_L1_2 = true, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/69d5f943_0bcc7d08 PS1, Line 37: .link_aspm_L1_2 = true, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/e5e0030c_8c4c6b1c PS1, Line 38: .turn_off_unused_lanes = true, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/71ba591c_a4f406e9 PS1, Line 38: .turn_off_unused_lanes = true, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/eebdd3a3_27bbbb68 PS1, Line 39: .clk_req = CLK_REQ2, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/fafe16dd_565b10f0 PS1, Line 39: .clk_req = CLK_REQ2, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/674e0c1c_8899e998 PS1, Line 40: }, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/08a37a9d_b2f88d74 PS1, Line 40: }, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/8e4aae6c_6e490c79 PS1, Line 41: { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/6bce6192_fa5430ea PS1, Line 41: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/a42eca5a_9c6e29db PS1, Line 42: // WLAN code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/fb5cec54_72801d2f PS1, Line 43: .port_present = true, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/00e67304_6d0fef8d PS1, Line 43: .port_present = true, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/a7aa5ddf_7fc3cad5 PS1, Line 44: .engine_type = PCIE_ENGINE, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/48347cf4_6ad498f9 PS1, Line 44: .engine_type = PCIE_ENGINE, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/26ef1267_c00080a6 PS1, Line 45: .start_logical_lane = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/9694145d_3f28dc06 PS1, Line 45: .start_logical_lane = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/ae248c0c_059ffeb4 PS1, Line 46: .end_logical_lane = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/d396a3b7_47cf9b69 PS1, Line 46: .end_logical_lane = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/03265419_79b99db2 PS1, Line 47: .device_number = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/f3fb6866_416595f8 PS1, Line 47: .device_number = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/1df14fd4_9fc31e6e PS1, Line 48: .function_number = 2, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/8633867a_91e41f0a PS1, Line 48: .function_number = 2, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/f4ac6345_a4a802eb PS1, Line 49: .link_aspm = ASPM_L1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/6e747fc0_a73ea8ed PS1, Line 49: .link_aspm = ASPM_L1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/ad25b31e_e5400061 PS1, Line 50: .link_aspm_L1_1 = true, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/559c5202_67710572 PS1, Line 50: .link_aspm_L1_1 = true, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/88661b2b_bfe2f4c3 PS1, Line 51: .link_aspm_L1_2 = true, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/9a158d93_39557e18 PS1, Line 51: .link_aspm_L1_2 = true, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/2afe9942_77bca55a PS1, Line 52: .turn_off_unused_lanes = true, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/5cbf2ed9_726a2bb4 PS1, Line 52: .turn_off_unused_lanes = true, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/db53d7e6_d6ff14ab PS1, Line 53: .clk_req = CLK_REQ0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/395216b4_537de5e3 PS1, Line 53: .clk_req = CLK_REQ0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/2ee6d2b4_a4ce252a PS1, Line 54: }, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/9d6ddc2e_5d61db6d PS1, Line 54: }, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/d3e8df65_025656a6 PS1, Line 55: { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/6379053c_f1ebe504 PS1, Line 55: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/fdf7f66f_f2b26ee6 PS1, Line 56: // SD Reader code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/e17840aa_3572465b PS1, Line 57: .port_present = true, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/09a0e998_4539eef7 PS1, Line 57: .port_present = true, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/100bc13c_a7208eb0 PS1, Line 58: .engine_type = PCIE_ENGINE, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/b10b9b24_0c0ea381 PS1, Line 58: .engine_type = PCIE_ENGINE, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/826fe378_026e90dc PS1, Line 59: .start_logical_lane = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/4abb9607_02798e49 PS1, Line 59: .start_logical_lane = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/8aae720d_918bee61 PS1, Line 60: .end_logical_lane = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/e4715eff_cd62623d PS1, Line 60: .end_logical_lane = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/4eb1a55d_90d5dda2 PS1, Line 61: .device_number = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/01f44204_202e26eb PS1, Line 61: .device_number = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/9d6c7bce_5a5e7a1f PS1, Line 62: .function_number = 3, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/5625a937_7f9c532e PS1, Line 62: .function_number = 3, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/520418b5_382f6a12 PS1, Line 63: .link_aspm = ASPM_L1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/8cf9cb62_6439703d PS1, Line 63: .link_aspm = ASPM_L1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/8a437b6d_043676fb PS1, Line 64: .link_aspm_L1_1 = true, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/772f7b10_d75c39e2 PS1, Line 64: .link_aspm_L1_1 = true, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/7f0a49d1_7bb39191 PS1, Line 65: .link_aspm_L1_2 = false, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/ba503959_2fd54fee PS1, Line 65: .link_aspm_L1_2 = false, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/f444cba4_9556b6fa PS1, Line 66: .turn_off_unused_lanes = true, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/fa54d009_2a3f0014 PS1, Line 66: .turn_off_unused_lanes = true, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/a9a384b3_01e1f326 PS1, Line 67: .clk_req = CLK_REQ1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/01a1c74e_c12024ff PS1, Line 67: .clk_req = CLK_REQ1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50279/comment/0008bf28_45151ce9 PS1, Line 68: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50279/comment/ef5c0fc7_6ff37345 PS1, Line 68: } please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)