View Change

81 comments:

• File src/mainboard/google/zork/variants/vilboz/variant.c:

  • Patch Set #1, Line 27: {

    code indent should use tabs where possible

  • Patch Set #1, Line 27: {

    please, no spaces at the start of a line

  • Patch Set #1, Line 28: // NVME SSD

    code indent should use tabs where possible

  • Patch Set #1, Line 29: .port_present = true,

    code indent should use tabs where possible

  • Patch Set #1, Line 29: .port_present = true,

    please, no spaces at the start of a line

  • Patch Set #1, Line 30: .engine_type = PCIE_ENGINE,

    code indent should use tabs where possible

  • Patch Set #1, Line 30: .engine_type = PCIE_ENGINE,

    please, no spaces at the start of a line

  • Patch Set #1, Line 31: .start_logical_lane = 4,

    code indent should use tabs where possible

  • Patch Set #1, Line 31: .start_logical_lane = 4,

    please, no spaces at the start of a line

  • Patch Set #1, Line 32: .end_logical_lane = 5,

    code indent should use tabs where possible

  • Patch Set #1, Line 32: .end_logical_lane = 5,

    please, no spaces at the start of a line

  • Patch Set #1, Line 33: .device_number = 1,

    code indent should use tabs where possible

  • Patch Set #1, Line 33: .device_number = 1,

    please, no spaces at the start of a line

  • Patch Set #1, Line 34: .function_number = 7,

    code indent should use tabs where possible

  • Patch Set #1, Line 34: .function_number = 7,

    please, no spaces at the start of a line

  • Patch Set #1, Line 35: .link_aspm = ASPM_L1,

    code indent should use tabs where possible

  • Patch Set #1, Line 35: .link_aspm = ASPM_L1,

    please, no spaces at the start of a line

  • Patch Set #1, Line 36: .link_aspm_L1_1 = true,

    code indent should use tabs where possible

  • Patch Set #1, Line 36: .link_aspm_L1_1 = true,

    please, no spaces at the start of a line

  • Patch Set #1, Line 37: .link_aspm_L1_2 = true,

    code indent should use tabs where possible

  • Patch Set #1, Line 37: .link_aspm_L1_2 = true,

    please, no spaces at the start of a line

  • Patch Set #1, Line 38: .turn_off_unused_lanes = true,

    code indent should use tabs where possible

  • Patch Set #1, Line 38: .turn_off_unused_lanes = true,

    please, no spaces at the start of a line

  • Patch Set #1, Line 39: .clk_req = CLK_REQ2,

    code indent should use tabs where possible

  • Patch Set #1, Line 39: .clk_req = CLK_REQ2,

    please, no spaces at the start of a line

  • Patch Set #1, Line 40: },

    code indent should use tabs where possible

  • Patch Set #1, Line 40: },

    please, no spaces at the start of a line

  • Patch Set #1, Line 41: {

    code indent should use tabs where possible

  • Patch Set #1, Line 41: {

    please, no spaces at the start of a line

  • Patch Set #1, Line 42: // WLAN

    code indent should use tabs where possible

  • Patch Set #1, Line 43: .port_present = true,

    code indent should use tabs where possible

  • Patch Set #1, Line 43: .port_present = true,

    please, no spaces at the start of a line

  • Patch Set #1, Line 44: .engine_type = PCIE_ENGINE,

    code indent should use tabs where possible

  • Patch Set #1, Line 44: .engine_type = PCIE_ENGINE,

    please, no spaces at the start of a line

  • Patch Set #1, Line 45: .start_logical_lane = 0,

    code indent should use tabs where possible

  • Patch Set #1, Line 45: .start_logical_lane = 0,

    please, no spaces at the start of a line

  • Patch Set #1, Line 46: .end_logical_lane = 0,

    code indent should use tabs where possible

  • Patch Set #1, Line 46: .end_logical_lane = 0,

    please, no spaces at the start of a line

  • Patch Set #1, Line 47: .device_number = 1,

    code indent should use tabs where possible

  • Patch Set #1, Line 47: .device_number = 1,

    please, no spaces at the start of a line

  • Patch Set #1, Line 48: .function_number = 2,

    code indent should use tabs where possible

  • Patch Set #1, Line 48: .function_number = 2,

    please, no spaces at the start of a line

  • Patch Set #1, Line 49: .link_aspm = ASPM_L1,

    code indent should use tabs where possible

  • Patch Set #1, Line 49: .link_aspm = ASPM_L1,

    please, no spaces at the start of a line

  • Patch Set #1, Line 50: .link_aspm_L1_1 = true,

    code indent should use tabs where possible

  • Patch Set #1, Line 50: .link_aspm_L1_1 = true,

    please, no spaces at the start of a line

  • Patch Set #1, Line 51: .link_aspm_L1_2 = true,

    code indent should use tabs where possible

  • Patch Set #1, Line 51: .link_aspm_L1_2 = true,

    please, no spaces at the start of a line

  • Patch Set #1, Line 52: .turn_off_unused_lanes = true,

    code indent should use tabs where possible

  • Patch Set #1, Line 52: .turn_off_unused_lanes = true,

    please, no spaces at the start of a line

  • Patch Set #1, Line 53: .clk_req = CLK_REQ0,

    code indent should use tabs where possible

  • Patch Set #1, Line 53: .clk_req = CLK_REQ0,

    please, no spaces at the start of a line

  • Patch Set #1, Line 54: },

    code indent should use tabs where possible

  • Patch Set #1, Line 54: },

    please, no spaces at the start of a line

  • Patch Set #1, Line 55: {

    code indent should use tabs where possible

  • Patch Set #1, Line 55: {

    please, no spaces at the start of a line

  • Patch Set #1, Line 56: // SD Reader

    code indent should use tabs where possible

  • Patch Set #1, Line 57: .port_present = true,

    code indent should use tabs where possible

  • Patch Set #1, Line 57: .port_present = true,

    please, no spaces at the start of a line

  • Patch Set #1, Line 58: .engine_type = PCIE_ENGINE,

    code indent should use tabs where possible

  • Patch Set #1, Line 58: .engine_type = PCIE_ENGINE,

    please, no spaces at the start of a line

  • Patch Set #1, Line 59: .start_logical_lane = 1,

    code indent should use tabs where possible

  • Patch Set #1, Line 59: .start_logical_lane = 1,

    please, no spaces at the start of a line

  • Patch Set #1, Line 60: .end_logical_lane = 1,

    code indent should use tabs where possible

  • Patch Set #1, Line 60: .end_logical_lane = 1,

    please, no spaces at the start of a line

  • Patch Set #1, Line 61: .device_number = 1,

    code indent should use tabs where possible

  • Patch Set #1, Line 61: .device_number = 1,

    please, no spaces at the start of a line

  • Patch Set #1, Line 62: .function_number = 3,

    code indent should use tabs where possible

  • Patch Set #1, Line 62: .function_number = 3,

    please, no spaces at the start of a line

  • Patch Set #1, Line 63: .link_aspm = ASPM_L1,

    code indent should use tabs where possible

  • Patch Set #1, Line 63: .link_aspm = ASPM_L1,

    please, no spaces at the start of a line

  • Patch Set #1, Line 64: .link_aspm_L1_1 = true,

    code indent should use tabs where possible

  • Patch Set #1, Line 64: .link_aspm_L1_1 = true,

    please, no spaces at the start of a line

  • Patch Set #1, Line 65: .link_aspm_L1_2 = false,

    code indent should use tabs where possible

  • Patch Set #1, Line 65: .link_aspm_L1_2 = false,

    please, no spaces at the start of a line

  • Patch Set #1, Line 66: .turn_off_unused_lanes = true,

    code indent should use tabs where possible

  • Patch Set #1, Line 66: .turn_off_unused_lanes = true,

    please, no spaces at the start of a line

  • Patch Set #1, Line 67: .clk_req = CLK_REQ1,

    code indent should use tabs where possible

  • Patch Set #1, Line 67: .clk_req = CLK_REQ1,

    please, no spaces at the start of a line

  • Patch Set #1, Line 68: }

    code indent should use tabs where possible

  • Patch Set #1, Line 68: }

    please, no spaces at the start of a line

To view, visit change 50279. To unsubscribe, or for help writing mail filters, visit settings.