Change in coreboot[master]: mb/google/zork: Remove code that reconfigured the backlight GPIO
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45853 )
Change subject: mb/google/zork: Remove code that reconfigured the backlight GPIO ......................................................................
mb/google/zork: Remove code that reconfigured the backlight GPIO
The SMU code was assuming that GPIO 85 was used for a fan, which caused interesting backlight flickering. That has now been fixed, so remove the code that reconfigured it to a GPIO on resume.
BUG=b:155667589 TEST=Verify the screen does not flicker on resume from S3 BRANCH=Zork
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I6d4f9d98e9df52fefab9b20d0ab0f0b67512d356 --- M src/mainboard/google/zork/mainboard.c 1 file changed, 0 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/45853/1
diff --git a/src/mainboard/google/zork/mainboard.c b/src/mainboard/google/zork/mainboard.c index 4206fdf..f0d9a28 100644 --- a/src/mainboard/google/zork/mainboard.c +++ b/src/mainboard/google/zork/mainboard.c @@ -188,25 +188,12 @@ dev->ops->acpi_inject_dsdt = chromeos_dsdt_generator; }
-static const struct soc_amd_gpio gpio_set_bl[] = { - PAD_GPO(GPIO_85, LOW), -}; - -static void reset_backlight_gpio(void *unused) -{ - printk(BIOS_DEBUG, "Reset backlight GPIO\n"); - /* Re-Enable backlight - GPIO 85 active low */ - /* TODO: Remove this after AGESA stops enabling the fan - b/155667589 */ - program_gpios(gpio_set_bl, ARRAY_SIZE(gpio_set_bl)); /* APU_EDP_BL_DISABLE */ -} - static void mainboard_final(void *chip_info) { struct global_nvs *gnvs;
gnvs = acpi_get_gnvs();
- reset_backlight_gpio(NULL);
if (gnvs) { gnvs->tmps = CTL_TDP_SENSOR_ID; @@ -231,5 +218,3 @@ *size = 0; return NULL; } - -BOOT_STATE_INIT_ENTRY(BS_OS_RESUME, BS_ON_ENTRY, reset_backlight_gpio, NULL);
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45853 )
Change subject: mb/google/zork: Remove code that reconfigured the backlight GPIO ......................................................................
Patch Set 1: Code-Review+2
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45853 )
Change subject: mb/google/zork: Remove code that reconfigured the backlight GPIO ......................................................................
Patch Set 1: Code-Review+2
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45853 )
Change subject: mb/google/zork: Remove code that reconfigured the backlight GPIO ......................................................................
Patch Set 1: Code-Review+1
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45853 )
Change subject: mb/google/zork: Remove code that reconfigured the backlight GPIO ......................................................................
Patch Set 1: Code-Review+2
Paul Fagerburg has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45853 )
Change subject: mb/google/zork: Remove code that reconfigured the backlight GPIO ......................................................................
mb/google/zork: Remove code that reconfigured the backlight GPIO
The SMU code was assuming that GPIO 85 was used for a fan, which caused interesting backlight flickering. That has now been fixed, so remove the code that reconfigured it to a GPIO on resume.
BUG=b:155667589 TEST=Verify the screen does not flicker on resume from S3 BRANCH=Zork
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I6d4f9d98e9df52fefab9b20d0ab0f0b67512d356 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45853 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-by: Rob Barnes robbarnes@google.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org --- M src/mainboard/google/zork/mainboard.c 1 file changed, 0 insertions(+), 15 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Marshall Dawson: Looks good to me, approved Paul Fagerburg: Looks good to me, approved Rob Barnes: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/zork/mainboard.c b/src/mainboard/google/zork/mainboard.c index 4206fdf..f0d9a28 100644 --- a/src/mainboard/google/zork/mainboard.c +++ b/src/mainboard/google/zork/mainboard.c @@ -188,25 +188,12 @@ dev->ops->acpi_inject_dsdt = chromeos_dsdt_generator; }
-static const struct soc_amd_gpio gpio_set_bl[] = { - PAD_GPO(GPIO_85, LOW), -}; - -static void reset_backlight_gpio(void *unused) -{ - printk(BIOS_DEBUG, "Reset backlight GPIO\n"); - /* Re-Enable backlight - GPIO 85 active low */ - /* TODO: Remove this after AGESA stops enabling the fan - b/155667589 */ - program_gpios(gpio_set_bl, ARRAY_SIZE(gpio_set_bl)); /* APU_EDP_BL_DISABLE */ -} - static void mainboard_final(void *chip_info) { struct global_nvs *gnvs;
gnvs = acpi_get_gnvs();
- reset_backlight_gpio(NULL);
if (gnvs) { gnvs->tmps = CTL_TDP_SENSOR_ID; @@ -231,5 +218,3 @@ *size = 0; return NULL; } - -BOOT_STATE_INIT_ENTRY(BS_OS_RESUME, BS_ON_ENTRY, reset_backlight_gpio, NULL);
-
Felix Held (Code Review) -
Marshall Dawson (Code Review)
-
Martin Roth (Code Review)
-
Paul Fagerburg (Code Review)
-
Rob Barnes (Code Review)