HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32807
Change subject: src/{ec,vendorcode}: Add missing 'include <types.h> ......................................................................
src/{ec,vendorcode}: Add missing 'include <types.h>
<types.h> is supposed to provide <stdint.h> and <stddef.h>. So when <types.h> is included, <stdint.h> and/or <stddef.h> is removed.
Change-Id: I1eb4163fb36a47b584f1fc9dd3c012e2930e9866 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/ec/lenovo/h8/h8.c M src/ec/lenovo/h8/wwan.c M src/ec/lenovo/pmh7/pmh7.c M src/vendorcode/siemens/hwilib/hwilib.c 4 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/32807/1
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c index de4f2c2..f707014c 100644 --- a/src/ec/lenovo/h8/h8.c +++ b/src/ec/lenovo/h8/h8.c @@ -23,6 +23,7 @@ #include <smbios.h> #include <pc80/mc146818rtc.h> #include <pc80/keyboard.h> +#include <types.h>
#include "h8.h" #include "chip.h" diff --git a/src/ec/lenovo/h8/wwan.c b/src/ec/lenovo/h8/wwan.c index cf3c8f7..e79cb61 100644 --- a/src/ec/lenovo/h8/wwan.c +++ b/src/ec/lenovo/h8/wwan.c @@ -18,6 +18,7 @@ #include <device/device.h> #include <ec/acpi/ec.h> #include <option.h> +#include <types.h>
#include "h8.h" #include "chip.h" diff --git a/src/ec/lenovo/pmh7/pmh7.c b/src/ec/lenovo/pmh7/pmh7.c index 986abb5..ef505cd1 100644 --- a/src/ec/lenovo/pmh7/pmh7.c +++ b/src/ec/lenovo/pmh7/pmh7.c @@ -20,6 +20,7 @@ #include <stdlib.h> #include <pc80/mc146818rtc.h> #include <delay.h> +#include <types.h>
#include "pmh7.h" #include "chip.h" diff --git a/src/vendorcode/siemens/hwilib/hwilib.c b/src/vendorcode/siemens/hwilib/hwilib.c index 1213dce..a4d87ad 100644 --- a/src/vendorcode/siemens/hwilib/hwilib.c +++ b/src/vendorcode/siemens/hwilib/hwilib.c @@ -18,8 +18,9 @@ #include <console/console.h> #include <device/mmio.h> #include <arch/early_variables.h> -#include "hwilib.h" +#include <types.h>
+#include "hwilib.h"
#define MAX_BLOCK_NUM 4 #define LEN_HIB 0x1fd
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32807 )
Change subject: src/{ec,vendorcode}: Add missing 'include <types.h> ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32807 )
Change subject: src/{ec,vendorcode}: Add missing 'include <types.h> ......................................................................
src/{ec,vendorcode}: Add missing 'include <types.h>
<types.h> is supposed to provide <stdint.h> and <stddef.h>. So when <types.h> is included, <stdint.h> and/or <stddef.h> is removed.
Change-Id: I1eb4163fb36a47b584f1fc9dd3c012e2930e9866 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32807 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Lijian Zhao lijian.zhao@intel.com --- M src/ec/lenovo/h8/h8.c M src/ec/lenovo/h8/wwan.c M src/ec/lenovo/pmh7/pmh7.c M src/vendorcode/siemens/hwilib/hwilib.c 4 files changed, 5 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Lijian Zhao: Looks good to me, approved
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c index de4f2c2..f707014c 100644 --- a/src/ec/lenovo/h8/h8.c +++ b/src/ec/lenovo/h8/h8.c @@ -23,6 +23,7 @@ #include <smbios.h> #include <pc80/mc146818rtc.h> #include <pc80/keyboard.h> +#include <types.h>
#include "h8.h" #include "chip.h" diff --git a/src/ec/lenovo/h8/wwan.c b/src/ec/lenovo/h8/wwan.c index cf3c8f7..e79cb61 100644 --- a/src/ec/lenovo/h8/wwan.c +++ b/src/ec/lenovo/h8/wwan.c @@ -18,6 +18,7 @@ #include <device/device.h> #include <ec/acpi/ec.h> #include <option.h> +#include <types.h>
#include "h8.h" #include "chip.h" diff --git a/src/ec/lenovo/pmh7/pmh7.c b/src/ec/lenovo/pmh7/pmh7.c index 986abb5..ef505cd1 100644 --- a/src/ec/lenovo/pmh7/pmh7.c +++ b/src/ec/lenovo/pmh7/pmh7.c @@ -20,6 +20,7 @@ #include <stdlib.h> #include <pc80/mc146818rtc.h> #include <delay.h> +#include <types.h>
#include "pmh7.h" #include "chip.h" diff --git a/src/vendorcode/siemens/hwilib/hwilib.c b/src/vendorcode/siemens/hwilib/hwilib.c index 1213dce..a4d87ad 100644 --- a/src/vendorcode/siemens/hwilib/hwilib.c +++ b/src/vendorcode/siemens/hwilib/hwilib.c @@ -18,8 +18,9 @@ #include <console/console.h> #include <device/mmio.h> #include <arch/early_variables.h> -#include "hwilib.h" +#include <types.h>
+#include "hwilib.h"
#define MAX_BLOCK_NUM 4 #define LEN_HIB 0x1fd
-
HAOUAS Elyes (Code Review) -
Lijian Zhao (Code Review)
-
Patrick Georgi (Code Review)