Patrick Georgi merged this change.

View Change

Approvals: build bot (Jenkins): Verified Lijian Zhao: Looks good to me, approved
src/{ec,vendorcode}: Add missing 'include <types.h>

<types.h> is supposed to provide <stdint.h> and <stddef.h>.
So when <types.h> is included, <stdint.h> and/or <stddef.h> is removed.

Change-Id: I1eb4163fb36a47b584f1fc9dd3c012e2930e9866
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32807
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Lijian Zhao <lijian.zhao@intel.com>
---
M src/ec/lenovo/h8/h8.c
M src/ec/lenovo/h8/wwan.c
M src/ec/lenovo/pmh7/pmh7.c
M src/vendorcode/siemens/hwilib/hwilib.c
4 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index de4f2c2..f707014c 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -23,6 +23,7 @@
#include <smbios.h>
#include <pc80/mc146818rtc.h>
#include <pc80/keyboard.h>
+#include <types.h>

#include "h8.h"
#include "chip.h"
diff --git a/src/ec/lenovo/h8/wwan.c b/src/ec/lenovo/h8/wwan.c
index cf3c8f7..e79cb61 100644
--- a/src/ec/lenovo/h8/wwan.c
+++ b/src/ec/lenovo/h8/wwan.c
@@ -18,6 +18,7 @@
#include <device/device.h>
#include <ec/acpi/ec.h>
#include <option.h>
+#include <types.h>

#include "h8.h"
#include "chip.h"
diff --git a/src/ec/lenovo/pmh7/pmh7.c b/src/ec/lenovo/pmh7/pmh7.c
index 986abb5..ef505cd1 100644
--- a/src/ec/lenovo/pmh7/pmh7.c
+++ b/src/ec/lenovo/pmh7/pmh7.c
@@ -20,6 +20,7 @@
#include <stdlib.h>
#include <pc80/mc146818rtc.h>
#include <delay.h>
+#include <types.h>

#include "pmh7.h"
#include "chip.h"
diff --git a/src/vendorcode/siemens/hwilib/hwilib.c b/src/vendorcode/siemens/hwilib/hwilib.c
index 1213dce..a4d87ad 100644
--- a/src/vendorcode/siemens/hwilib/hwilib.c
+++ b/src/vendorcode/siemens/hwilib/hwilib.c
@@ -18,8 +18,9 @@
#include <console/console.h>
#include <device/mmio.h>
#include <arch/early_variables.h>
-#include "hwilib.h"
+#include <types.h>

+#include "hwilib.h"

#define MAX_BLOCK_NUM 4
#define LEN_HIB 0x1fd

To view, visit change 32807. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1eb4163fb36a47b584f1fc9dd3c012e2930e9866
Gerrit-Change-Number: 32807
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged