Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40142 )
Change subject: mb/google/gru: Use the fmap with vboot ......................................................................
mb/google/gru: Use the fmap with vboot
Otherwise, the build process will fail when vboot is selected.
Change-Id: Ie7b5d0be9ed0621eb4a9c9117f4f5b7d3cdfe741 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/gru/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/40142/1
diff --git a/src/mainboard/google/gru/Kconfig b/src/mainboard/google/gru/Kconfig index 819c448..e933780 100644 --- a/src/mainboard/google/gru/Kconfig +++ b/src/mainboard/google/gru/Kconfig @@ -94,6 +94,10 @@ depends on DRIVERS_UART default 0xFF1A0000
+config FMDFILE + string + default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos.fmd" if VBOOT + ########################################################## #### Update below when adding a new derivative board. #### ##########################################################
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40142 )
Change subject: mb/google/gru: Use the fmap with vboot ......................................................................
Patch Set 3: Code-Review+1
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40142 )
Change subject: mb/google/gru: Use the fmap with vboot ......................................................................
Patch Set 4: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40142 )
Change subject: mb/google/gru: Use the fmap with vboot ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40142/4/src/mainboard/google/gru/Kc... File src/mainboard/google/gru/Kconfig:
https://review.coreboot.org/c/coreboot/+/40142/4/src/mainboard/google/gru/Kc... PS4, Line 99: default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos.fmd" if VBOOT What makes this board specific? it's already in src/Kconfig with `if CHROMEOS`. I'd prefer to have a sane default for all boards and no special treatment. Maybe `if MAINBOARD_HAS_CHROMEOS && VBOOT`?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40142 )
Change subject: mb/google/gru: Use the fmap with vboot ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40142/4/src/mainboard/google/gru/Kc... File src/mainboard/google/gru/Kconfig:
https://review.coreboot.org/c/coreboot/+/40142/4/src/mainboard/google/gru/Kc... PS4, Line 99: default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos.fmd" if VBOOT
What makes this board specific? it's already in src/Kconfig with […]
I need to retest again, but I think the fmap was not selected when switching to vboot. It could have been a mistake on my end though.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40142 )
Change subject: mb/google/gru: Use the fmap with vboot ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40142/4/src/mainboard/google/gru/Kc... File src/mainboard/google/gru/Kconfig:
https://review.coreboot.org/c/coreboot/+/40142/4/src/mainboard/google/gru/Kc... PS4, Line 99: default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos.fmd" if VBOOT
I need to retest again, but I think the fmap was not selected when switching to vboot. […]
The current defaults only work if you select CHROMEOS. If you select VBOOT && !CHROMEOS, FMDFILE defaults to nothing. So there is a real issue. I just don't want it handled at the mainboard level, as it's not mainboard specific, AFAICT.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40142 )
Change subject: mb/google/gru: Use the fmap with vboot ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40142/4/src/mainboard/google/gru/Kc... File src/mainboard/google/gru/Kconfig:
https://review.coreboot.org/c/coreboot/+/40142/4/src/mainboard/google/gru/Kc... PS4, Line 99: default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos.fmd" if VBOOT
The current defaults only work if you select CHROMEOS. If you select […]
Well, not every board has a fmdfile named "chromeos.fmd" to use with VBOOT && !CHROMEOS.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40142 )
Change subject: mb/google/gru: Use the fmap with vboot ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40142/4/src/mainboard/google/gru/Kc... File src/mainboard/google/gru/Kconfig:
https://review.coreboot.org/c/coreboot/+/40142/4/src/mainboard/google/gru/Kc... PS4, Line 99: default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos.fmd" if VBOOT
Well, not every board has a fmdfile named "chromeos.fmd" to use with VBOOT && !CHROMEOS.
Yes. I guess that's why nobody suggested to make it a default.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40142 )
Change subject: mb/google/gru: Use the fmap with vboot ......................................................................
Patch Set 4: Code-Review-1
Not really sure why we're doing this now, only for the Gru board? This is a general problem that affects all boards -- you always need to provide a custom FMAP to build with vboot (or is this somehow different for the x86 boards?). The correct general solution would probably be to expand the automatic FMAP generation mechanism (util/cbfstool/default.fmd and friends) to generate vboot-compatible FMAPs when CONFIG_VBOOT is enabled.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40142 )
Change subject: mb/google/gru: Use the fmap with vboot ......................................................................
Patch Set 4:
Patch Set 4: Code-Review-1
Not really sure why we're doing this now, only for the Gru board? This is a general problem that affects all boards -- you always need to provide a custom FMAP to build with vboot (or is this somehow different for the x86 boards?). The correct general solution would probably be to expand the automatic FMAP generation mechanism (util/cbfstool/default.fmd and friends) to generate vboot-compatible FMAPs when CONFIG_VBOOT is enabled.
Agreed. I only did this for gru because it was the one where the dead_code macro was misbehaving. Figured out it would be *marginally* better to let this change rot in here than to discard it.
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40142 )
Change subject: mb/google/gru: Use the fmap with vboot ......................................................................
Abandoned
Not a good solution
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
Julius Werner (Code Review)
-
Nico Huber (Code Review)
-
Paul Menzel (Code Review)