Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40142 )
Change subject: mb/google/gru: Use the fmap with vboot ......................................................................
Patch Set 4:
Patch Set 4: Code-Review-1
Not really sure why we're doing this now, only for the Gru board? This is a general problem that affects all boards -- you always need to provide a custom FMAP to build with vboot (or is this somehow different for the x86 boards?). The correct general solution would probably be to expand the automatic FMAP generation mechanism (util/cbfstool/default.fmd and friends) to generate vboot-compatible FMAPs when CONFIG_VBOOT is enabled.
Agreed. I only did this for gru because it was the one where the dead_code macro was misbehaving. Figured out it would be *marginally* better to let this change rot in here than to discard it.