Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40142 )
Change subject: mb/google/gru: Use the fmap with vboot
......................................................................
Patch Set 4: Code-Review-1
Not really sure why we're doing this now, only for the Gru board? This is a general problem that affects all boards -- you always need to provide a custom FMAP to build with vboot (or is this somehow different for the x86 boards?). The correct general solution would probably be to expand the automatic FMAP generation mechanism (util/cbfstool/default.fmd and friends) to generate vboot-compatible FMAPs when CONFIG_VBOOT is enabled.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40142
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7b5d0be9ed0621eb4a9c9117f4f5b7d3cdfe741
Gerrit-Change-Number: 40142
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 06 Apr 2020 22:09:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment