Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40142 )
Change subject: mb/google/gru: Use the fmap with vboot ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40142/4/src/mainboard/google/gru/Kc... File src/mainboard/google/gru/Kconfig:
https://review.coreboot.org/c/coreboot/+/40142/4/src/mainboard/google/gru/Kc... PS4, Line 99: default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos.fmd" if VBOOT What makes this board specific? it's already in src/Kconfig with `if CHROMEOS`. I'd prefer to have a sane default for all boards and no special treatment. Maybe `if MAINBOARD_HAS_CHROMEOS && VBOOT`?