Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/42359 )
Change subject: Add Bay Trail support ......................................................................
Patch Set 34:
(4 comments)
https://review.coreboot.org/c/libgfxinit/+/42359/31/common/hw-gfx-gma-config... File common/hw-gfx-gma-config.ads.template:
https://review.coreboot.org/c/libgfxinit/+/42359/31/common/hw-gfx-gma-config... PS31, Line 336: Maximum_Scalable_Width : <hswvar> Width_Per_Pipe := -- HELL FIXME: check
If we didn't figure this out for G45, I guess it is not really known. […]
I might want to use something where the tertiary pipe has a valid value. Otherwise, CHV won't really work I think
https://review.coreboot.org/c/libgfxinit/+/42359/8/common/hw-gfx-gma-pipe_se... File common/hw-gfx-gma-pipe_setup.adb:
https://review.coreboot.org/c/libgfxinit/+/42359/8/common/hw-gfx-gma-pipe_se... PS8, Line 659: True
`False` (I assume then the other scaler functions wouldn't be called)
Ack
https://review.coreboot.org/c/libgfxinit/+/42359/31/common/hw-gfx-gma-regist... File common/hw-gfx-gma-registers.ads:
PS31:
Not sure anymore what we discussed yet. If we get rid of the representation […]
Yes. The current approach of redefining all the registers worked well to identify the places I needed to look into. I think I can get rid of it at some point now.
https://review.coreboot.org/c/libgfxinit/+/42359/31/common/valleyview/hw-gfx... File common/valleyview/hw-gfx-gma-power_and_clocks.adb:
https://review.coreboot.org/c/libgfxinit/+/42359/31/common/valleyview/hw-gfx... PS31, Line 120: Registers.Write (Registers.VLV_DPIO_CTL, 1);
Shouldn't this be part of the Init sequence? […]
Done
-
Angel Pons (Code Review)