View Change

4 comments:

• File common/hw-gfx-gma-config.ads.template:

  • Patch Set #31, Line 336: Maximum_Scalable_Width : <hswvar> Width_Per_Pipe := -- HELL FIXME: check

    If we didn't figure this out for G45, I guess it is not really known. […]

    I might want to use something where the tertiary pipe has a valid value. Otherwise, CHV won't really work I think

• File common/hw-gfx-gma-pipe_setup.adb:

  • Patch Set #8, Line 659: True

    `False` (I assume then the other scaler functions wouldn't be called)

    Ack

• File common/hw-gfx-gma-registers.ads:

  • Patch Set #31:

    Not sure anymore what we discussed yet. If we get rid of the representation […]

    Yes. The current approach of redefining all the registers worked well to identify the places I needed to look into. I think I can get rid of it at some point now.

• File common/valleyview/hw-gfx-gma-power_and_clocks.adb:

  • Patch Set #31, Line 120: Registers.Write (Registers.VLV_DPIO_CTL, 1);

    Shouldn't this be part of the Init sequence? […]

    Done

To view, visit change 42359. To unsubscribe, or for help writing mail filters, visit settings.