Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200214

List overview All Threads
Download

newer

older

Change in coreboot[4.11_branch]:...

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

14 Feb 2020 14 Feb '20

8:04 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200214 ......................................................................

crossgcc: Upgrade IASL to version 20200214

Change: https://acpica.org/node/177

Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20200214_iasl.patch D util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20200214.tar.gz.cksum 4 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/38907/1

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 150e616..b1c930b 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -54,7 +54,7 @@ GCC_AUTOCONF_VERSION=2.69 BINUTILS_VERSION=2.33.1 GDB_VERSION=8.3.1 -IASL_VERSION=20200110 +IASL_VERSION=20200214 PYTHON_VERSION=3.8.1 EXPAT_VERSION=2.2.9 # CLANG version number diff --git a/util/crossgcc/patches/acpica-unix2-20200110_iasl.patch b/util/crossgcc/patches/acpica-unix2-20200214_iasl.patch similarity index 100% rename from util/crossgcc/patches/acpica-unix2-20200110_iasl.patch rename to util/crossgcc/patches/acpica-unix2-20200214_iasl.patch diff --git a/util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum deleted file mode 100644 index 48c0a2f..0000000 --- a/util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -50c163d965aa2cbee9a3a5d9244d1a0d16c06ec0 tarballs/acpica-unix2-20200110.tar.gz diff --git a/util/crossgcc/sum/acpica-unix2-20200214.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20200214.tar.gz.cksum new file mode 100644 index 0000000..97ef41e --- /dev/null +++ b/util/crossgcc/sum/acpica-unix2-20200214.tar.gz.cksum @@ -0,0 +1 @@ +70f4e47590c82553287b2f301020352c59db7589 tarballs/acpica-unix2-20200214.tar.gz

Attachments:

attachment.htm (text/html — 3.7 KB)

Show replies by date

Idwer Vollering (Code Review)

14 Feb 14 Feb

8:32 p.m.

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200214 ......................................................................

Patch Set 2: Code-Review-2

No. A version bump (to 20200110) was submitted literally earlier this month: https://review.coreboot.org/c/coreboot/+/38347 If this has introduced bugs or broken the tree, feel free to remove my score.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 14 Feb 2020 20:32:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

19 Feb 19 Feb

10:53 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200214 ......................................................................

Patch Set 3:

...

Patch Set 2: Code-Review-2

No. A version bump (to 20200110) was submitted literally earlier this month: https://review.coreboot.org/c/coreboot/+/38347 If this has introduced bugs or broken the tree, feel free to remove my score.

Please start a discussion on the mailing list if you oppose the current strategy to make use of the latest and greatest releases for the coreboot toolchain.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 19 Feb 2020 10:53:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

4:49 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200214 ......................................................................

Patch Set 3:

...

Patch Set 2: Code-Review-2

No. A version bump (to 20200110) was submitted literally earlier this month: https://review.coreboot.org/c/coreboot/+/38347 If this has introduced bugs or broken the tree, feel free to remove my score.

That earlier version bump was delayed for months (before 20200110 there were a few more versions we skipped) because we had to fix up our tree first.

Since you seem to feel strongly about this: what's the cut-off we should follow in your opinion? Monthly updates?

And why?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 19 Feb 2020 16:49:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Martin Roth (Code Review)

7:58 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200214 ......................................................................

Patch Set 3:

...

Patch Set 3:

...
Patch Set 2: Code-Review-2

No. A version bump (to 20200110) was submitted literally earlier this month: https://review.coreboot.org/c/coreboot/+/38347 If this has introduced bugs or broken the tree, feel free to remove my score.

That earlier version bump was delayed for months (before 20200110 there were a few more versions we skipped) because we had to fix up our tree first.

Since you seem to feel strongly about this: what's the cut-off we should follow in your opinion? Monthly updates?

And why?

Personally, I'm in favor of quarterly updates for most of the toolchain unless there's an issue that requires an update sooner than that.

I think we should do GCC updates every 6 months, preferably immediately after a release so that there's plenty of time to find and fix any issues created before the next release.

I've got a builder set up to do daily testing with the updated IASL. I could expand that to do the full toolchain update on a daily basis.

And it looks like we're failing to build GDB with the new jenkins image. I'll work to fix that this weekend and probably need to update all the builders to a new coreboot-sdk docker image again. I hadn't been testing building the toolchain on the new docker image, so it seems like I need to add that. I didn't think it was needed because when the image is created, the first thing it does is build the toolchain, but it doesn't build GDB. :(

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 19 Feb 2020 19:58:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Idwer Vollering (Code Review)

11:37 p.m.

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200214 ......................................................................

Patch Set 3: Code-Review-1

Since I don't represent a company, I can live with quarterly updates.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 19 Feb 2020 23:37:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

20 Feb 20 Feb

7:32 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200214 ......................................................................

Patch Set 3:

...

Personally, I'm in favor of quarterly updates for most of the toolchain unless there's an issue that requires an update sooner than that.

I think we should do GCC updates every 6 months, preferably immediately after a release so that there's plenty of time to find and fix any issues created before the next release.

Right, that used to be the plan (with an optional update around the midpoint, which would result in a ~quarterly schedule). Various issues with updates led us away from that, but let's go back to it.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 20 Feb 2020 07:32:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

27 Feb 27 Feb

11:47 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200214 ......................................................................

Patch Set 4:

This change is ready for review.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 27 Feb 2020 11:47:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

11:47 a.m.

New subject: Change in coreboot[master]: [WIP]crossgcc: Upgrade IASL to version 20200214

Hello Idwer Vollering, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38907

to look at the new patch set (#5).

Change subject: [WIP]crossgcc: Upgrade IASL to version 20200214 ......................................................................

[WIP]crossgcc: Upgrade IASL to version 20200214

Change: https://acpica.org/node/177

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/38907/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

26 Mar 26 Mar

9:57 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200326

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200326 ......................................................................

Patch Set 6:

This change is ready for review.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 26 Mar 2020 21:57:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

27 Mar 27 Mar

9:07 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200326

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200326 ......................................................................

Patch Set 6:

https://acpica.org/node/178 : "iASL: table compiler: Implemented IVRS IVHD type 11h parsing. The AMD IVRS table parsing supported only IVHD type 10h structures. Parsing an IVHD type 11h caused the iasl to report unknown subtable type. Add necessary structure definition for IVHD type 11h and apply correct parsing method based on subtable type."

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 27 Mar 2020 09:07:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

9:07 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200326

Hello build bot (Jenkins), Michał Żygowski, Patrick Georgi, Martin Roth, Idwer Vollering,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38907

to look at the new patch set (#7).

Change subject: crossgcc: Upgrade IASL to version 20200326 ......................................................................

crossgcc: Upgrade IASL to version 20200326

Changes: https://acpica.org/node/177 https://acpica.org/node/178

Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20200326_iasl.patch D util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20200326.tar.gz.cksum 4 files changed, 5 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/38907/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Michał Żygowski (Code Review)

9:27 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200326

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200326 ......................................................................

Patch Set 7:

Patrick, Martin, is there any particular environment/distro that is verified to build the crossgcc? I remember having issues to build it some time ago. I would like to test these toolchain updates on the mainboards I have at hand to help with review.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 27 Mar 2020 09:27:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

30 Mar 30 Mar

4:27 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200326

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200326 ......................................................................

Patch Set 8:

...

Patch Set 7:

Patrick, Martin, is there any particular environment/distro that is verified to build the crossgcc? I remember having issues to build it some time ago. I would like to test these toolchain updates on the mainboards I have at hand to help with review.

The jenkins build is on a debian based system (the jenkins node docker container defined in util/docker). Depending on how the GSoC project for packaging crossgcc turns out, we might be able to increase our build test coverage.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 30 Mar 2020 16:27:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

30 Apr 30 Apr

7:02 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200430

Hello build bot (Jenkins), Patrick Georgi, Michał Żygowski, Martin Roth, Idwer Vollering,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38907

to look at the new patch set (#9).

Change subject: crossgcc: Upgrade IASL to version 20200430 ......................................................................

crossgcc: Upgrade IASL to version 20200430

Changes: https://acpica.org/node/177 https://acpica.org/node/178 https://acpica.org/node/179

Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20200430_iasl.patch D util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20200430.tar.gz.cksum 4 files changed, 5 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/38907/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 9 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Paul Menzel (Code Review)

12 May 12 May

9:36 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200430

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200430 ......................................................................

Patch Set 10: Code-Review+1

Boot tested on one device?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 10 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 12 May 2020 21:36:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

29 May 29 May

8:21 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200528

Hello build bot (Jenkins), Patrick Georgi, Michał Żygowski, Martin Roth, Idwer Vollering, Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38907

to look at the new patch set (#12).

Change subject: crossgcc: Upgrade IASL to version 20200528 ......................................................................

crossgcc: Upgrade IASL to version 20200528

Changes: https://acpica.org/node/177 https://acpica.org/node/178 https://acpica.org/node/179 https://acpica.org/node/181

Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/patches/acpica-unix2-20200110_iasl.patch D util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20200528.tar.gz.cksum 4 files changed, 2 insertions(+), 29 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/38907/12

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 12 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

6:17 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200528

Hello build bot (Jenkins), Patrick Georgi, Michał Żygowski, Martin Roth, Idwer Vollering, Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38907

to look at the new patch set (#14).

Change subject: crossgcc: Upgrade IASL to version 20200528 ......................................................................

crossgcc: Upgrade IASL to version 20200528

Changes: https://acpica.org/node/177 https://acpica.org/node/178 https://acpica.org/node/179 https://acpica.org/node/181

Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20200528_iasl.patch D util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20200528.tar.gz.cksum 4 files changed, 5 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/38907/14

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 14 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

7:26 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200528

Hello build bot (Jenkins), Patrick Georgi, Michał Żygowski, Martin Roth, Idwer Vollering, Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38907

to look at the new patch set (#15).

Change subject: crossgcc: Upgrade IASL to version 20200528 ......................................................................

crossgcc: Upgrade IASL to version 20200528

Changes: https://acpica.org/node/177 https://acpica.org/node/178 https://acpica.org/node/179 https://acpica.org/node/181

acpinames utility removed: "Removed support for the acpinames utility. The acpinames was a simple utility used to populate and display the ACPI namespace without executing any AML code. However, ACPICA now supports executable opcodes outside of control methods. This means that executable AML opcodes such as If and Store opcodes need to be executed during table load. Therefore, acpinames would need to be updated to match the same behavior as the acpiexec utility and since acpiexec can already dump the entire namespace (via the 'namespace' command), we no longer have the need to maintain acpinames."

Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20200528_iasl.patch D util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20200528.tar.gz.cksum 4 files changed, 7 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/38907/15

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 15 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

8:55 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200528

Hello build bot (Jenkins), Patrick Georgi, Michał Żygowski, Martin Roth, Idwer Vollering, Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38907

to look at the new patch set (#16).

Change subject: crossgcc: Upgrade IASL to version 20200528 ......................................................................

crossgcc: Upgrade IASL to version 20200528

Changes: https://acpica.org/node/177 https://acpica.org/node/178 https://acpica.org/node/179 https://acpica.org/node/181

Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20200528_iasl.patch D util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20200528.tar.gz.cksum 4 files changed, 8 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/38907/16

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 16 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

10 Jun 10 Jun

3:57 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200528

Hello build bot (Jenkins), Patrick Georgi, Michał Żygowski, Martin Roth, Idwer Vollering, Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38907

to look at the new patch set (#17).

Change subject: crossgcc: Upgrade IASL to version 20200528 ......................................................................

crossgcc: Upgrade IASL to version 20200528

Changes: https://acpica.org/node/177 https://acpica.org/node/178 https://acpica.org/node/179 https://acpica.org/node/181

Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20200528_iasl.patch D util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20200528.tar.gz.cksum 4 files changed, 8 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/38907/17

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 17 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Idwer Vollering (Code Review)

16 Jun 16 Jun

1:54 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200528

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200528 ......................................................................

Patch Set 17: Code-Review+2

I'm handing out a +2 score, on the condition that it comes in pairs.

The currently used acpica release won't build on archlinux and its derivates.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 17 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 16 Jun 2020 13:54:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

3:41 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200528

Hello build bot (Jenkins), Patrick Georgi, Michał Żygowski, Martin Roth, Idwer Vollering, Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38907

to look at the new patch set (#18).

Change subject: crossgcc: Upgrade IASL to version 20200528 ......................................................................

crossgcc: Upgrade IASL to version 20200528

Changes: https://acpica.org/node/177 https://acpica.org/node/178 https://acpica.org/node/179 https://acpica.org/node/181

Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20200528_iasl.patch D util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20200528.tar.gz.cksum 4 files changed, 8 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/38907/18

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 18 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

25 Jun 25 Jun

6:02 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200528

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200528 ......................................................................

Patch Set 18:

let me try to solve the "Merge Conflict" status

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 18 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 25 Jun 2020 06:02:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

6:05 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200528

Hello build bot (Jenkins), Patrick Georgi, Michał Żygowski, Martin Roth, Idwer Vollering, Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38907

to look at the new patch set (#19).

Change subject: crossgcc: Upgrade IASL to version 20200528 ......................................................................

crossgcc: Upgrade IASL to version 20200528

Changes: https://acpica.org/node/177 https://acpica.org/node/178 https://acpica.org/node/179 https://acpica.org/node/181

Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20200528_iasl.patch D util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20200528.tar.gz.cksum 4 files changed, 8 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/38907/19

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 19 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Nico Huber (Code Review)

1 Jul 1 Jul

11:02 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200528

Nico Huber has uploaded a new patch set (#20) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200528 ......................................................................

crossgcc: Upgrade IASL to version 20200528

Update fixes build issues with host GCC 10.

Other changes: https://acpica.org/node/177 https://acpica.org/node/178 https://acpica.org/node/179 https://acpica.org/node/181

Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20200528_iasl.patch D util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20200528.tar.gz.cksum 4 files changed, 8 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/38907/20

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 20 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

11:11 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200528

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200528 ......................................................................

Patch Set 20: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 20 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 01 Jul 2020 11:11:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

11:17 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200528

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200528 ......................................................................

Patch Set 20: Code-Review+1

The current IASL in crossgcc fails to build with GCC 10.x.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 20 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 01 Jul 2020 11:17:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

11:53 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200528

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200528 ......................................................................

Patch Set 20: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 20 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 01 Jul 2020 11:53:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

12:25 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200528

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200528 ......................................................................

Patch Set 20:

...

Patch Set 20: Code-Review+1

The current IASL in crossgcc fails to build with GCC 10.x.

yes. only version >= 20200326 will build with gcc-10

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 20 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 01 Jul 2020 12:25:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

12:28 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200528

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38907 )

Change subject: crossgcc: Upgrade IASL to version 20200528 ......................................................................

crossgcc: Upgrade IASL to version 20200528

Update fixes build issues with host GCC 10.

Other changes: https://acpica.org/node/177 https://acpica.org/node/178 https://acpica.org/node/179 https://acpica.org/node/181

Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/38907 Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20200528_iasl.patch D util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20200528.tar.gz.cksum 4 files changed, 8 insertions(+), 8 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 2e5b2d0..17c89e8 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -40,7 +40,7 @@ GCC_AUTOCONF_VERSION=2.69 BINUTILS_VERSION=2.33.1 GDB_VERSION=9.2 -IASL_VERSION=20200110 +IASL_VERSION=20200528 PYTHON_VERSION=3.8.1 EXPAT_VERSION=2.2.9 # CLANG version number @@ -843,9 +843,9 @@ test "$UNAME" = "Cygwin" && HOST="_CYGWIN" HOST="$HOST" CFLAGS="$CFLAGS" \ OPT_CFLAGS="-O -D_FORTIFY_SOURCE=2 -D COREBOOT_TOOLCHAIN_VERSION='"coreboot toolchain v$CROSSGCC_VERSION $CROSSGCC_DATE"' " \ - $MAKE $JOBS CC="$(hostcc host)" iasl acpibin acpidump acpiexec acpihelp acpinames acpisrc acpixtract - rm -f "$DESTDIR$TARGETDIR/bin/{iasl,acpibin,acpidump,acpiexec,acpihelp,acpinames,acpisrc,acpixtract}" || touch "$RDIR/.failed" - cp bin/{iasl,acpibin,acpidump,acpiexec,acpihelp,acpinames,acpisrc,acpixtract} "$DESTDIR$TARGETDIR/bin" || touch "$RDIR/.failed" + $MAKE $JOBS CC="$(hostcc host)" iasl acpibin acpidump acpiexec acpihelp acpisrc acpixtract + rm -f "$DESTDIR$TARGETDIR/bin/{iasl,acpibin,acpidump,acpiexec,acpihelp,acpisrc,acpixtract}" || touch "$RDIR/.failed" + cp bin/{iasl,acpibin,acpidump,acpiexec,acpihelp,acpisrc,acpixtract} "$DESTDIR$TARGETDIR/bin" || touch "$RDIR/.failed" }

build_LLVM() { diff --git a/util/crossgcc/patches/acpica-unix2-20200110_iasl.patch b/util/crossgcc/patches/acpica-unix2-20200528_iasl.patch similarity index 73% rename from util/crossgcc/patches/acpica-unix2-20200110_iasl.patch rename to util/crossgcc/patches/acpica-unix2-20200528_iasl.patch index 0f60974..3fac35d 100644 --- a/util/crossgcc/patches/acpica-unix2-20200110_iasl.patch +++ b/util/crossgcc/patches/acpica-unix2-20200528_iasl.patch @@ -1,6 +1,6 @@ -diff -Naur acpica-unix2-20190703_/source/compiler/asloptions.c acpica-unix2-20190703/source/compiler/asloptions.c > acpica-unix2-20190703_iasl.patch ---- acpica-unix2-20190703_/source/compiler/asloptions.c -+++ acpica-unix2-20190703/source/compiler/asloptions.c +diff -Naur acpica-unix2-20200528_/source/compiler/asloptions.c acpica-unix2-20200528/source/compiler/asloptions.c > acpica-unix2-20200528_iasl.patch +--- acpica-unix2-20200528_/source/compiler/asloptions.c ++++ acpica-unix2-20200528/source/compiler/asloptions.c @@ -126,6 +126,7 @@ if (Gbl_DoSignon) { diff --git a/util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum deleted file mode 100644 index 48c0a2f..0000000 --- a/util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -50c163d965aa2cbee9a3a5d9244d1a0d16c06ec0 tarballs/acpica-unix2-20200110.tar.gz diff --git a/util/crossgcc/sum/acpica-unix2-20200528.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20200528.tar.gz.cksum new file mode 100644 index 0000000..d2265e1 --- /dev/null +++ b/util/crossgcc/sum/acpica-unix2-20200528.tar.gz.cksum @@ -0,0 +1 @@ +27afd4c05c966e9390fcc30bdf1f53ddb7d69033 tarballs/acpica-unix2-20200528.tar.gz

-- To view, visit https://review.coreboot.org/c/coreboot/+/38907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6 Gerrit-Change-Number: 38907 Gerrit-PatchSet: 21 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1639

days inactive

1777

days old

coreboot-gerrit@coreboot.org

30 comments

8 participants

tags (0)

participants (8)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)
Idwer Vollering (Code Review)
Martin Roth (Code Review)
Michał Żygowski (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)