Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
crossgcc: Upgrade IASL to version 20200528

Update fixes build issues with host GCC 10.

Other changes:
https://acpica.org/node/177
https://acpica.org/node/178
https://acpica.org/node/179
https://acpica.org/node/181

acpinames utility removed:
"Removed support for the acpinames utility. The acpinames was a simple
utility used to populate and display the ACPI namespace without executing
any AML code. However, ACPICA now supports executable opcodes outside of
control methods. This means that executable AML opcodes such as If and
Store opcodes need to be executed during table load. Therefore, acpinames
would need to be updated to match the same behavior as the acpiexec
utility and since acpiexec can already dump the entire namespace (via the
'namespace' command), we no longer have the need to maintain acpinames."

Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38907
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M util/crossgcc/buildgcc
R util/crossgcc/patches/acpica-unix2-20200528_iasl.patch
D util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum
A util/crossgcc/sum/acpica-unix2-20200528.tar.gz.cksum
4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 2e5b2d0..17c89e8 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -40,7 +40,7 @@
GCC_AUTOCONF_VERSION=2.69
BINUTILS_VERSION=2.33.1
GDB_VERSION=9.2
-IASL_VERSION=20200110
+IASL_VERSION=20200528
PYTHON_VERSION=3.8.1
EXPAT_VERSION=2.2.9
# CLANG version number
@@ -843,9 +843,9 @@
test "$UNAME" = "Cygwin" && HOST="_CYGWIN"
HOST="$HOST" CFLAGS="$CFLAGS" \
OPT_CFLAGS="-O -D_FORTIFY_SOURCE=2 -D COREBOOT_TOOLCHAIN_VERSION='\"coreboot toolchain v$CROSSGCC_VERSION $CROSSGCC_DATE\"' " \
- $MAKE $JOBS CC="$(hostcc host)" iasl acpibin acpidump acpiexec acpihelp acpinames acpisrc acpixtract
- rm -f "$DESTDIR$TARGETDIR/bin/{iasl,acpibin,acpidump,acpiexec,acpihelp,acpinames,acpisrc,acpixtract}" || touch "$RDIR/.failed"
- cp bin/{iasl,acpibin,acpidump,acpiexec,acpihelp,acpinames,acpisrc,acpixtract} "$DESTDIR$TARGETDIR/bin" || touch "$RDIR/.failed"
+ $MAKE $JOBS CC="$(hostcc host)" iasl acpibin acpidump acpiexec acpihelp acpisrc acpixtract
+ rm -f "$DESTDIR$TARGETDIR/bin/{iasl,acpibin,acpidump,acpiexec,acpihelp,acpisrc,acpixtract}" || touch "$RDIR/.failed"
+ cp bin/{iasl,acpibin,acpidump,acpiexec,acpihelp,acpisrc,acpixtract} "$DESTDIR$TARGETDIR/bin" || touch "$RDIR/.failed"
}

build_LLVM() {
diff --git a/util/crossgcc/patches/acpica-unix2-20200110_iasl.patch b/util/crossgcc/patches/acpica-unix2-20200528_iasl.patch
similarity index 73%
rename from util/crossgcc/patches/acpica-unix2-20200110_iasl.patch
rename to util/crossgcc/patches/acpica-unix2-20200528_iasl.patch
index 0f60974..3fac35d 100644
--- a/util/crossgcc/patches/acpica-unix2-20200110_iasl.patch
+++ b/util/crossgcc/patches/acpica-unix2-20200528_iasl.patch
@@ -1,6 +1,6 @@
-diff -Naur acpica-unix2-20190703_/source/compiler/asloptions.c acpica-unix2-20190703/source/compiler/asloptions.c > acpica-unix2-20190703_iasl.patch
---- acpica-unix2-20190703_/source/compiler/asloptions.c
-+++ acpica-unix2-20190703/source/compiler/asloptions.c
+diff -Naur acpica-unix2-20200528_/source/compiler/asloptions.c acpica-unix2-20200528/source/compiler/asloptions.c > acpica-unix2-20200528_iasl.patch
+--- acpica-unix2-20200528_/source/compiler/asloptions.c
++++ acpica-unix2-20200528/source/compiler/asloptions.c
@@ -126,6 +126,7 @@
if (Gbl_DoSignon)
{
diff --git a/util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum
deleted file mode 100644
index 48c0a2f..0000000
--- a/util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum
+++ /dev/null
@@ -1 +0,0 @@
-50c163d965aa2cbee9a3a5d9244d1a0d16c06ec0 tarballs/acpica-unix2-20200110.tar.gz
diff --git a/util/crossgcc/sum/acpica-unix2-20200528.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20200528.tar.gz.cksum
new file mode 100644
index 0000000..d2265e1
--- /dev/null
+++ b/util/crossgcc/sum/acpica-unix2-20200528.tar.gz.cksum
@@ -0,0 +1 @@
+27afd4c05c966e9390fcc30bdf1f53ddb7d69033 tarballs/acpica-unix2-20200528.tar.gz

To view, visit change 38907. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd995561ca53458b04f87cee5693850c0d90d3d6
Gerrit-Change-Number: 38907
Gerrit-PatchSet: 21
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Idwer Vollering <vidwer@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged