Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47161 )
Change subject: mb/google/puff/var/dooly: Set default I2C0 frequency ......................................................................
mb/google/puff/var/dooly: Set default I2C0 frequency
This setting copy from puff reference board and should measure whole system after EVT build.
BUG=b:155261464 BRANCH=puff TEST=emerge-puff coreboot and check system speaker has sound output.
Change-Id: Idd5c3276e9306e81ea766d14ed1415a68dedc2ad Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/dooly/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/47161/1
diff --git a/src/mainboard/google/hatch/variants/dooly/overridetree.cb b/src/mainboard/google/hatch/variants/dooly/overridetree.cb index ee91dd3..f4b6d63 100644 --- a/src/mainboard/google/hatch/variants/dooly/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dooly/overridetree.cb @@ -125,8 +125,8 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, - .rise_time_ns = 0, - .fall_time_ns = 0, + .rise_time_ns = 60, + .fall_time_ns = 60, }, .i2c[2] = { .speed = I2C_SPEED_FAST,
Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47161 )
Change subject: mb/google/puff/var/dooly: Set default I2C0 frequency ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47161/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47161/1//COMMIT_MSG@10 PS1, Line 10: EVT Don't refer to build stages.
Hello Sam McNally, build bot (Jenkins), Edward O'Callaghan, Wisley Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47161
to look at the new patch set (#2).
Change subject: mb/google/puff/var/dooly: Set default I2C0 frequency ......................................................................
mb/google/puff/var/dooly: Set default I2C0 frequency
This setting copy from puff reference board and should measure again after whole system build.
BUG=b:155261464 BRANCH=puff TEST=emerge-puff coreboot and check system speaker has sound output.
Change-Id: Idd5c3276e9306e81ea766d14ed1415a68dedc2ad Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/dooly/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/47161/2
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47161 )
Change subject: mb/google/puff/var/dooly: Set default I2C0 frequency ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47161/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47161/1//COMMIT_MSG@10 PS1, Line 10: EVT
Don't refer to build stages.
Done, Got it. Thanks
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47161 )
Change subject: mb/google/puff/var/dooly: Set default I2C0 frequency ......................................................................
Patch Set 2:
Hi Sam, Could you help submit this CL? Thanks
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47161 )
Change subject: mb/google/puff/var/dooly: Set default I2C0 frequency ......................................................................
Patch Set 2:
Hi Sam, Could you please help merge this CL? Thanks
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47161 )
Change subject: mb/google/puff/var/dooly: Set default I2C0 frequency ......................................................................
Patch Set 2: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47161 )
Change subject: mb/google/puff/var/dooly: Set default I2C0 frequency ......................................................................
mb/google/puff/var/dooly: Set default I2C0 frequency
This setting copy from puff reference board and should measure again after whole system build.
BUG=b:155261464 BRANCH=puff TEST=emerge-puff coreboot and check system speaker has sound output.
Change-Id: Idd5c3276e9306e81ea766d14ed1415a68dedc2ad Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47161 Reviewed-by: Edward O'Callaghan quasisec@chromium.org Reviewed-by: Sam McNally sammc@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/dooly/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved Sam McNally: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/dooly/overridetree.cb b/src/mainboard/google/hatch/variants/dooly/overridetree.cb index ee91dd3..f4b6d63 100644 --- a/src/mainboard/google/hatch/variants/dooly/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dooly/overridetree.cb @@ -125,8 +125,8 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, - .rise_time_ns = 0, - .fall_time_ns = 0, + .rise_time_ns = 60, + .fall_time_ns = 60, }, .i2c[2] = { .speed = I2C_SPEED_FAST,
-
Edward O'Callaghan (Code Review) -
Sam McNally (Code Review)
-
Tony Huang (Code Review)