Edward O'Callaghan submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved Sam McNally: Looks good to me, approved
mb/google/puff/var/dooly: Set default I2C0 frequency

This setting copy from puff reference board
and should measure again after whole system build.

TEST=emerge-puff coreboot and check system speaker has sound output.

Change-Id: Idd5c3276e9306e81ea766d14ed1415a68dedc2ad
Signed-off-by: Tony Huang <tony-huang@quanta.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47161
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Sam McNally <sammc@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
M src/mainboard/google/hatch/variants/dooly/overridetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/google/hatch/variants/dooly/overridetree.cb b/src/mainboard/google/hatch/variants/dooly/overridetree.cb
index ee91dd3..f4b6d63 100644
--- a/src/mainboard/google/hatch/variants/dooly/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/dooly/overridetree.cb
@@ -125,8 +125,8 @@
.i2c[0] = {
.speed = I2C_SPEED_FAST,
- .rise_time_ns = 0,
- .fall_time_ns = 0,
+ .rise_time_ns = 60,
+ .fall_time_ns = 60,
.i2c[2] = {
.speed = I2C_SPEED_FAST,

To view, visit change 47161. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd5c3276e9306e81ea766d14ed1415a68dedc2ad
Gerrit-Change-Number: 47161
Gerrit-PatchSet: 3
Gerrit-Owner: Tony Huang <tony-huang@quanta.corp-partner.google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: Wisley Chen <wisley.chen@quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged