Divya Sasidharan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37870 )
Change subject: soc/intel/tigerlake: Add code for early tcss ......................................................................
Patch Set 22:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37870/22/src/soc/intel/tigerlake/ea... File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/37870/22/src/soc/intel/tigerlake/ea... PS22, Line 79: req_size = 2; Suggestion: Add macros for the different request size for different commands. Line 92, 127, 156 has this variable.
https://review.coreboot.org/c/coreboot/+/37870/22/src/soc/intel/tigerlake/ea... PS22, Line 169: Do you need to add condition for safe mode. If coreboot polls and reads safe mode from EC, what should be done.
-
Divya Sasidharan (Code Review)