Change in coreboot[master]: mb/google/dedede: Update Boten GPIO setting for PEN detection.

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Stanley Wu (Code Review)

4 Dec 2020 4 Dec '20

9:23 a.m.

Stanley Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48294 )

Change subject: mb/google/dedede: Update Boten GPIO setting for PEN detection. ......................................................................

mb/google/dedede: Update Boten GPIO setting for PEN detection.

AP_PEN_DET_ODL isolated by a diode and need to pull up internally.

BUG=b:160752604 BRANCH=firmware-dedede-13606.B TEST=Build and confirm waveform by google EE parter.

Signed-off-by: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Change-Id: I85f3d0209094af07891a5c0cc218443da586e6e2 --- M src/mainboard/google/dedede/variants/boten/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/48294/1

diff --git a/src/mainboard/google/dedede/variants/boten/gpio.c b/src/mainboard/google/dedede/variants/boten/gpio.c index c27daa4..0c81872 100644 --- a/src/mainboard/google/dedede/variants/boten/gpio.c +++ b/src/mainboard/google/dedede/variants/boten/gpio.c @@ -11,7 +11,7 @@ PAD_CFG_GPO(GPP_A10, 0, PLTRST),

/* C12 : AP_PEN_DET_ODL */ - PAD_CFG_GPI_SCI(GPP_C12, NONE, DEEP, EDGE_SINGLE, NONE), + PAD_CFG_GPI_SCI(GPP_C12, UP_20K, DEEP, EDGE_SINGLE, NONE), /* C18 : AP_I2C_EMR_SDA */ PAD_NC(GPP_C18, NONE), /* C19 : AP_I2C_EMR_SCL */

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Karthik Ramasubramanian (Code Review)

4 Dec 4 Dec

8:41 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48294 )

Change subject: mb/google/dedede: Update Boten GPIO setting for PEN detection. ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48294/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48294/1//COMMIT_MSG@12 PS1, Line 12: firmware-dedede-13606.B dedede

-- To view, visit https://review.coreboot.org/c/coreboot/+/48294 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85f3d0209094af07891a5c0cc218443da586e6e2 Gerrit-Change-Number: 48294 Gerrit-PatchSet: 1 Gerrit-Owner: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-Comment-Date: Fri, 04 Dec 2020 18:41:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jerry2 Huang (Code Review)

7 Dec 7 Dec

4:55 a.m.

Jerry2 Huang has uploaded a new patch set (#2) to the change originally created by Stanley Wu. ( https://review.coreboot.org/c/coreboot/+/48294 )

Change subject: mb/google/dedede: Update Boten GPIO setting for PEN detection. ......................................................................

mb/google/dedede: Update Boten GPIO setting for PEN detection.

AP_PEN_DET_ODL isolated by a diode and need to pull up internally.

BUG=b:160752604 BRANCH=dedede TEST=Build and confirm waveform by google EE parter.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/48294/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48294 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85f3d0209094af07891a5c0cc218443da586e6e2 Gerrit-Change-Number: 48294 Gerrit-PatchSet: 2 Gerrit-Owner: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-MessageType: newpatchset

Jerry2 Huang (Code Review)

4:56 a.m.

Jerry2 Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48294 )

Change subject: mb/google/dedede: Update Boten GPIO setting for PEN detection. ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48294/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48294/1//COMMIT_MSG@12 PS1, Line 12: firmware-dedede-13606.B

...

dedede

done

-- To view, visit https://review.coreboot.org/c/coreboot/+/48294 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85f3d0209094af07891a5c0cc218443da586e6e2 Gerrit-Change-Number: 48294 Gerrit-PatchSet: 2 Gerrit-Owner: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-Comment-Date: Mon, 07 Dec 2020 02:56:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

7:56 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48294 )

Change subject: mb/google/dedede: Update Boten GPIO setting for PEN detection. ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48294 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85f3d0209094af07891a5c0cc218443da586e6e2 Gerrit-Change-Number: 48294 Gerrit-PatchSet: 2 Gerrit-Owner: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-Comment-Date: Mon, 07 Dec 2020 17:56:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

9 Dec 9 Dec

3:31 p.m.

Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48294 )

Change subject: mb/google/dedede: Update Boten GPIO setting for PEN detection. ......................................................................

mb/google/dedede: Update Boten GPIO setting for PEN detection.

AP_PEN_DET_ODL isolated by a diode and need to pull up internally.

BUG=b:160752604 BRANCH=dedede TEST=Build and confirm waveform by google EE parter.

Signed-off-by: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Change-Id: I85f3d0209094af07891a5c0cc218443da586e6e2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48294 Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/variants/boten/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/48294 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85f3d0209094af07891a5c0cc218443da586e6e2 Gerrit-Change-Number: 48294 Gerrit-PatchSet: 3 Gerrit-Owner: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-MessageType: merged

1509

days inactive

1514

days old

coreboot-gerrit@coreboot.org

5 comments

4 participants

tags (0)

participants (4)

Hung-Te Lin (Code Review)
Jerry2 Huang (Code Review)
Karthik Ramasubramanian (Code Review)
Stanley Wu (Code Review)