Change in coreboot[master]: mb/google/zork/var/vliboz: update telemetry settings

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

John Su (Code Review)

3 Dec 2020 3 Dec '20

11:49 p.m.

John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48288 )

Change subject: mb/google/zork/var/vliboz: update telemetry settings ......................................................................

mb/google/zork/var/vliboz: update telemetry settings

Update telemetry settings.

VDD Slope : 32643 -> 26939 VDD Offset: 208 -> 125 SOC Slope : 22742 -> 20001 SOC Offset: -83 -> 168

BUG=b:171668654 BRANCH=zork TEST=1. emerge-zork coreboot 2. pass AMD SDLE test report

Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/48288/1

diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb index 3b3bdd4..9d6f132 100644 --- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -18,10 +18,10 @@

# End : OPN Performance Configuration

- register "telemetry_vddcr_vdd_slope_mA" = "32643" - register "telemetry_vddcr_vdd_offset" = "208" - register "telemetry_vddcr_soc_slope_mA" = "22742" - register "telemetry_vddcr_soc_offset" = "-83" + register "telemetry_vddcr_vdd_slope_mA" = "26939" + register "telemetry_vddcr_vdd_offset" = "125" + register "telemetry_vddcr_soc_slope_mA" = "20001" + register "telemetry_vddcr_soc_offset" = "168"

# USB OC pin mapping register "usb_port_overcurrent_pin[1]" = "USB_OC_NONE" # LTE instead of USB C1

Attachments:

attachment.htm (text/html — 3.6 KB)

Show replies by date

John Su (Code Review)

3 Dec 3 Dec

11:54 p.m.

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )

Change subject: mb/google/zork/var/vliboz: update telemetry settings ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/48288 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 Gerrit-Change-Number: 48288 Gerrit-PatchSet: 1 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: chris wang Chris.Wang@amd.com Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Comment-Date: Fri, 04 Dec 2020 02:54:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

EricR Lai (Code Review)

4 Dec 4 Dec

12:02 a.m.

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )

Change subject: mb/google/zork/var/vliboz: update telemetry settings ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/48288 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 Gerrit-Change-Number: 48288 Gerrit-PatchSet: 1 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: chris wang Chris.Wang@amd.com Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Comment-Date: Fri, 04 Dec 2020 03:02:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

chris wang (Code Review)

7 Dec 7 Dec

6:11 a.m.

chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )

Change subject: mb/google/zork/var/vliboz: update telemetry settings ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/48288 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 Gerrit-Change-Number: 48288 Gerrit-PatchSet: 1 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: chris wang Chris.Wang@amd.com Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Comment-Date: Mon, 07 Dec 2020 09:11:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

EricR Lai (Code Review)

6:12 a.m.

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )

Change subject: mb/google/zork/var/vliboz: update telemetry settings ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48288 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 Gerrit-Change-Number: 48288 Gerrit-PatchSet: 1 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: chris wang Chris.Wang@amd.com Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Comment-Date: Mon, 07 Dec 2020 09:12:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Peichao Wang (Code Review)

8 Dec 8 Dec

6:14 a.m.

Peichao Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )

Change subject: mb/google/zork/var/vliboz: update telemetry settings ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48288 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 Gerrit-Change-Number: 48288 Gerrit-PatchSet: 1 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Peichao Wang pwang12@lenovo.corp-partner.google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: chris wang Chris.Wang@amd.com Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Comment-Date: Tue, 08 Dec 2020 09:14:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

John Su (Code Review)

6:53 a.m.

New subject: Change in coreboot[master]: mb/google/zork/var/vilboz: update telemetry settings

Hello build bot (Jenkins), Martin Roth, Peichao Wang, Rob Barnes, chris wang, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48288

to look at the new patch set (#2).

Change subject: mb/google/zork/var/vilboz: update telemetry settings ......................................................................

mb/google/zork/var/vilboz: update telemetry settings

Update telemetry settings.

VDD Slope : 32643 -> 26939 VDD Offset: 208 -> 125 SOC Slope : 22742 -> 20001 SOC Offset: -83 -> 168

BUG=b:171668654 BRANCH=zork TEST=1. emerge-zork coreboot 2. pass AMD SDLE test report

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/48288/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48288 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 Gerrit-Change-Number: 48288 Gerrit-PatchSet: 2 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Peichao Wang pwang12@lenovo.corp-partner.google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: chris wang Chris.Wang@amd.com Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-MessageType: newpatchset

Rob Barnes (Code Review)

9:14 a.m.

New subject: Change in coreboot[master]: mb/google/zork/var/vilboz: update telemetry settings

Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )

Change subject: mb/google/zork/var/vilboz: update telemetry settings ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/48288 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 Gerrit-Change-Number: 48288 Gerrit-PatchSet: 2 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Peichao Wang pwang12@lenovo.corp-partner.google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: chris wang Chris.Wang@amd.com Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Comment-Date: Tue, 08 Dec 2020 12:14:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Peichao Wang (Code Review)

9 Dec 9 Dec

3:24 a.m.

New subject: Change in coreboot[master]: mb/google/zork/var/vilboz: update telemetry settings

Peichao Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )

Change subject: mb/google/zork/var/vilboz: update telemetry settings ......................................................................

Patch Set 2:

John, need rebase this CL to master

-- To view, visit https://review.coreboot.org/c/coreboot/+/48288 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 Gerrit-Change-Number: 48288 Gerrit-PatchSet: 2 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Peichao Wang pwang12@lenovo.corp-partner.google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: chris wang Chris.Wang@amd.com Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Comment-Date: Wed, 09 Dec 2020 06:24:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

John Su (Code Review)

6:34 a.m.

New subject: Change in coreboot[master]: mb/google/zork/var/vilboz: Update telemetry settings

Hello build bot (Jenkins), Martin Roth, Peichao Wang, Rob Barnes, chris wang, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48288

to look at the new patch set (#3).

Change subject: mb/google/zork/var/vilboz: Update telemetry settings ......................................................................

mb/google/zork/var/vilboz: Update telemetry settings

Update telemetry settings.

VDD Slope : 32643 -> 26939 VDD Offset: 208 -> 125 SOC Slope : 22742 -> 20001 SOC Offset: -83 -> 168

BUG=b:171668654 BRANCH=zork TEST=1. emerge-zork coreboot 2. pass AMD SDLE test report

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/48288/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/48288 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 Gerrit-Change-Number: 48288 Gerrit-PatchSet: 3 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Peichao Wang pwang12@lenovo.corp-partner.google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: chris wang Chris.Wang@amd.com Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-MessageType: newpatchset

John Su (Code Review)

6:35 a.m.

New subject: Change in coreboot[master]: mb/google/zork/var/vilboz: Update telemetry settings

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )

Change subject: mb/google/zork/var/vilboz: Update telemetry settings ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/48288 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 Gerrit-Change-Number: 48288 Gerrit-PatchSet: 3 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Peichao Wang pwang12@lenovo.corp-partner.google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: chris wang Chris.Wang@amd.com Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Comment-Date: Wed, 09 Dec 2020 09:35:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

John Su (Code Review)

6:35 a.m.

New subject: Change in coreboot[master]: mb/google/zork/var/vilboz: Update telemetry settings

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )

Change subject: mb/google/zork/var/vilboz: Update telemetry settings ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48288 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 Gerrit-Change-Number: 48288 Gerrit-PatchSet: 3 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Peichao Wang pwang12@lenovo.corp-partner.google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: chris wang Chris.Wang@amd.com Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Comment-Date: Wed, 09 Dec 2020 09:35:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

John Su (Code Review)

6:37 a.m.

New subject: Change in coreboot[master]: mb/google/zork/var/vilboz: Update telemetry settings

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )

Change subject: mb/google/zork/var/vilboz: Update telemetry settings ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/48288 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 Gerrit-Change-Number: 48288 Gerrit-PatchSet: 3 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Peichao Wang pwang12@lenovo.corp-partner.google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: chris wang Chris.Wang@amd.com Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Comment-Date: Wed, 09 Dec 2020 09:37:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

EricR Lai (Code Review)

6:38 a.m.

New subject: Change in coreboot[master]: mb/google/zork/var/vilboz: Update telemetry settings

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )

Change subject: mb/google/zork/var/vilboz: Update telemetry settings ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48288 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 Gerrit-Change-Number: 48288 Gerrit-PatchSet: 3 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Peichao Wang pwang12@lenovo.corp-partner.google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: chris wang Chris.Wang@amd.com Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Comment-Date: Wed, 09 Dec 2020 09:38:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

7:19 a.m.

New subject: Change in coreboot[master]: mb/google/zork/var/vilboz: Update telemetry settings

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48288 )

Change subject: mb/google/zork/var/vilboz: Update telemetry settings ......................................................................

mb/google/zork/var/vilboz: Update telemetry settings

Update telemetry settings.

VDD Slope : 32643 -> 26939 VDD Offset: 208 -> 125 SOC Slope : 22742 -> 20001 SOC Offset: -83 -> 168

BUG=b:171668654 BRANCH=zork TEST=1. emerge-zork coreboot 2. pass AMD SDLE test report

Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48288 Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 4 insertions(+), 4 deletions(-)

Approvals: build bot (Jenkins): Verified John Su: Looks good to me, but someone else must approve EricR Lai: Looks good to me, approved

diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb index a19443d..a3c2c97 100644 --- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -18,10 +18,10 @@

# End : OPN Performance Configuration

# USB OC pin mapping register "usb_port_overcurrent_pin[1]" = "USB_OC_NONE" # LTE instead of USB C1

-- To view, visit https://review.coreboot.org/c/coreboot/+/48288 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 Gerrit-Change-Number: 48288 Gerrit-PatchSet: 4 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Wang pwang12@lenovo.corp-partner.google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: chris wang Chris.Wang@amd.com Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-MessageType: merged

Peichao Wang (Code Review)

10:10 a.m.

New subject: Change in coreboot[master]: mb/google/zork/var/vilboz: Update telemetry settings

Peichao Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48288 )

Change subject: mb/google/zork/var/vilboz: Update telemetry settings ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48288 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63e069310aa4a66cd4c9058790dbed37e6967f4 Gerrit-Change-Number: 48288 Gerrit-PatchSet: 4 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Wang pwang12@lenovo.corp-partner.google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: chris wang Chris.Wang@amd.com Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Comment-Date: Wed, 09 Dec 2020 13:10:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1271

days inactive

1276

days old

coreboot-gerrit@coreboot.org

15 comments

6 participants

tags (0)

participants (6)

chris wang (Code Review)
EricR Lai (Code Review)
John Su (Code Review)
Patrick Georgi (Code Review)
Peichao Wang (Code Review)
Rob Barnes (Code Review)