[M] Change in coreboot[master]: util/cbfstool: Add a new mechanism to provide a memory mapped
Attention is currently required from: Nico Huber, Julius Werner, Maximilian Brune.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68160 )
Change subject: util/cbfstool: Add a new mechanism to provide a memory mapped ......................................................................
Patch Set 3:
(3 comments)
File src/soc/intel/common/block/fast_spi/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/68160/comment/23226dab_799b1100 PS3, Line 91: $(call int-subtract, $(CONFIG_ROM_SIZE) 0x1000000)
Can we factor this term out into a separate variable (e.g. […]
Done
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/68160/comment/d33a86e7_f3c5ab30 PS3, Line 317: static int next_window;
nit: namespace a bit better since it's a global (e.g. […]
Done
https://review.coreboot.org/c/coreboot/+/68160/comment/97cf10e1_86a45d0e PS3, Line 338: MMAP_SIZE
nit: That's a bit of an odd way to name fields in an array, particularly since these constants are g […]
Done
-
Arthur Heymans (Code Review)