Attention is currently required from: Nico Huber, Julius Werner, Maximilian Brune.
3 comments:
File src/soc/intel/common/block/fast_spi/Makefile.inc:
Patch Set #3, Line 91: $(call int-subtract, $(CONFIG_ROM_SIZE) 0x1000000)
Can we factor this term out into a separate variable (e.g. […]
Done
File util/cbfstool/cbfstool.c:
Patch Set #3, Line 317: static int next_window;
nit: namespace a bit better since it's a global (e.g. […]
Done
Patch Set #3, Line 338: MMAP_SIZE
nit: That's a bit of an odd way to name fields in an array, particularly since these constants are g […]
Done
To view, visit change 68160. To unsubscribe, or for help writing mail filters, visit settings.