Hello Marcello Sylvester Bauer,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/39161
to review the following change.
Change subject: mb/lenovo: Add additional FMAPs on 8MiB devices ......................................................................
mb/lenovo: Add additional FMAPs on 8MiB devices
* Add FMAP for measured boot only, with a single RO partition. * Add FMAP for measured boot only, with a single RO partition but where the ME has been stripped.
Tested on X220 using VBOOT+measured boot: * Used patched IFD and ME, boots into OS
Change-Id: I04c1add13198444638c669deec1e05159b1a09c9 Signed-off-by: Marcello Sylvester Bauer sylv@sylv.io Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- A src/mainboard/lenovo/t420/vboot-ro-me_clean.fmd A src/mainboard/lenovo/t420/vboot-ro.fmd A src/mainboard/lenovo/t420s/vboot-ro-me_clean.fmd A src/mainboard/lenovo/t420s/vboot-ro.fmd A src/mainboard/lenovo/t520/vboot-ro-me_clean.fmd A src/mainboard/lenovo/t520/vboot-ro.fmd A src/mainboard/lenovo/x220/vboot-ro-me_clean.fmd A src/mainboard/lenovo/x220/vboot-ro.fmd 8 files changed, 176 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/39161/1
diff --git a/src/mainboard/lenovo/t420/vboot-ro-me_clean.fmd b/src/mainboard/lenovo/t420/vboot-ro-me_clean.fmd new file mode 100644 index 0000000..d1cbff7 --- /dev/null +++ b/src/mainboard/lenovo/t420/vboot-ro-me_clean.fmd @@ -0,0 +1,22 @@ +FLASH@0xff800000 0x800000 { + SI_ALL 0x20000 { + SI_DESC 0x1000 + SI_GBE 0x2000 + SI_ME + } + SI_BIOS 0x7e0000 { + UNIFIED_MRC_CACHE 0x20000 { + RECOVERY_MRC_CACHE 0x10000 + RW_MRC_CACHE 0x10000 + } + + WP_RO { + FMAP 0x800 + RO_FRID 0x40 + RO_PADDING 0x7c0 + RO_VPD(PRESERVE) 0x1000 + GBB 0x1e000 + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/lenovo/t420/vboot-ro.fmd b/src/mainboard/lenovo/t420/vboot-ro.fmd new file mode 100644 index 0000000..51df8a5 --- /dev/null +++ b/src/mainboard/lenovo/t420/vboot-ro.fmd @@ -0,0 +1,22 @@ +FLASH@0xff800000 0x800000 { + SI_ALL 0x500000 { + SI_DESC 0x1000 + SI_GBE 0x2000 + SI_ME 0x4ed000 + } + SI_BIOS 0x300000 { + UNIFIED_MRC_CACHE 0x20000 { + RECOVERY_MRC_CACHE 0x10000 + RW_MRC_CACHE 0x10000 + } + + WP_RO { + FMAP 0x800 + RO_FRID 0x40 + RO_PADDING 0x7c0 + RO_VPD(PRESERVE) 0x1000 + GBB 0x1e000 + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/lenovo/t420s/vboot-ro-me_clean.fmd b/src/mainboard/lenovo/t420s/vboot-ro-me_clean.fmd new file mode 100644 index 0000000..d1cbff7 --- /dev/null +++ b/src/mainboard/lenovo/t420s/vboot-ro-me_clean.fmd @@ -0,0 +1,22 @@ +FLASH@0xff800000 0x800000 { + SI_ALL 0x20000 { + SI_DESC 0x1000 + SI_GBE 0x2000 + SI_ME + } + SI_BIOS 0x7e0000 { + UNIFIED_MRC_CACHE 0x20000 { + RECOVERY_MRC_CACHE 0x10000 + RW_MRC_CACHE 0x10000 + } + + WP_RO { + FMAP 0x800 + RO_FRID 0x40 + RO_PADDING 0x7c0 + RO_VPD(PRESERVE) 0x1000 + GBB 0x1e000 + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/lenovo/t420s/vboot-ro.fmd b/src/mainboard/lenovo/t420s/vboot-ro.fmd new file mode 100644 index 0000000..51df8a5 --- /dev/null +++ b/src/mainboard/lenovo/t420s/vboot-ro.fmd @@ -0,0 +1,22 @@ +FLASH@0xff800000 0x800000 { + SI_ALL 0x500000 { + SI_DESC 0x1000 + SI_GBE 0x2000 + SI_ME 0x4ed000 + } + SI_BIOS 0x300000 { + UNIFIED_MRC_CACHE 0x20000 { + RECOVERY_MRC_CACHE 0x10000 + RW_MRC_CACHE 0x10000 + } + + WP_RO { + FMAP 0x800 + RO_FRID 0x40 + RO_PADDING 0x7c0 + RO_VPD(PRESERVE) 0x1000 + GBB 0x1e000 + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/lenovo/t520/vboot-ro-me_clean.fmd b/src/mainboard/lenovo/t520/vboot-ro-me_clean.fmd new file mode 100644 index 0000000..d1cbff7 --- /dev/null +++ b/src/mainboard/lenovo/t520/vboot-ro-me_clean.fmd @@ -0,0 +1,22 @@ +FLASH@0xff800000 0x800000 { + SI_ALL 0x20000 { + SI_DESC 0x1000 + SI_GBE 0x2000 + SI_ME + } + SI_BIOS 0x7e0000 { + UNIFIED_MRC_CACHE 0x20000 { + RECOVERY_MRC_CACHE 0x10000 + RW_MRC_CACHE 0x10000 + } + + WP_RO { + FMAP 0x800 + RO_FRID 0x40 + RO_PADDING 0x7c0 + RO_VPD(PRESERVE) 0x1000 + GBB 0x1e000 + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/lenovo/t520/vboot-ro.fmd b/src/mainboard/lenovo/t520/vboot-ro.fmd new file mode 100644 index 0000000..51df8a5 --- /dev/null +++ b/src/mainboard/lenovo/t520/vboot-ro.fmd @@ -0,0 +1,22 @@ +FLASH@0xff800000 0x800000 { + SI_ALL 0x500000 { + SI_DESC 0x1000 + SI_GBE 0x2000 + SI_ME 0x4ed000 + } + SI_BIOS 0x300000 { + UNIFIED_MRC_CACHE 0x20000 { + RECOVERY_MRC_CACHE 0x10000 + RW_MRC_CACHE 0x10000 + } + + WP_RO { + FMAP 0x800 + RO_FRID 0x40 + RO_PADDING 0x7c0 + RO_VPD(PRESERVE) 0x1000 + GBB 0x1e000 + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/lenovo/x220/vboot-ro-me_clean.fmd b/src/mainboard/lenovo/x220/vboot-ro-me_clean.fmd new file mode 100644 index 0000000..d1cbff7 --- /dev/null +++ b/src/mainboard/lenovo/x220/vboot-ro-me_clean.fmd @@ -0,0 +1,22 @@ +FLASH@0xff800000 0x800000 { + SI_ALL 0x20000 { + SI_DESC 0x1000 + SI_GBE 0x2000 + SI_ME + } + SI_BIOS 0x7e0000 { + UNIFIED_MRC_CACHE 0x20000 { + RECOVERY_MRC_CACHE 0x10000 + RW_MRC_CACHE 0x10000 + } + + WP_RO { + FMAP 0x800 + RO_FRID 0x40 + RO_PADDING 0x7c0 + RO_VPD(PRESERVE) 0x1000 + GBB 0x1e000 + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/lenovo/x220/vboot-ro.fmd b/src/mainboard/lenovo/x220/vboot-ro.fmd new file mode 100644 index 0000000..51df8a5 --- /dev/null +++ b/src/mainboard/lenovo/x220/vboot-ro.fmd @@ -0,0 +1,22 @@ +FLASH@0xff800000 0x800000 { + SI_ALL 0x500000 { + SI_DESC 0x1000 + SI_GBE 0x2000 + SI_ME 0x4ed000 + } + SI_BIOS 0x300000 { + UNIFIED_MRC_CACHE 0x20000 { + RECOVERY_MRC_CACHE 0x10000 + RW_MRC_CACHE 0x10000 + } + + WP_RO { + FMAP 0x800 + RO_FRID 0x40 + RO_PADDING 0x7c0 + RO_VPD(PRESERVE) 0x1000 + GBB 0x1e000 + COREBOOT(CBFS) + } + } +}
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39161 )
Change subject: mb/lenovo: Add additional FMAPs on 8MiB devices ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Maybe it's a good idea to unify these laptops someday. I'm not confident enough to do so though, since I don't own any Thonkpad :S
https://review.coreboot.org/c/coreboot/+/39161/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39161/3//COMMIT_MSG@11 PS3, Line 11: stripped only stripped, or also shrunk?
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39161 )
Change subject: mb/lenovo: Add additional FMAPs on 8MiB devices ......................................................................
Patch Set 3: Code-Review+1
Is there a Kconfig option to use these fmaps?
Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39161 )
Change subject: mb/lenovo: Add additional FMAPs on 8MiB devices ......................................................................
Patch Set 3:
(1 comment)
Patch Set 3: Code-Review+1
Is there a Kconfig option to use these fmaps?
No, but we are working on it.
https://review.coreboot.org/c/coreboot/+/39161/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39161/3//COMMIT_MSG@11 PS3, Line 11: stripped
only stripped, or also shrunk?
stripped and shrunk. Shrunk is maybe a better choice of words.
Marcello Sylvester Bauer has uploaded a new patch set (#4) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/39161 )
Change subject: mb/lenovo: Add additional FMAPs on 8MiB devices ......................................................................
mb/lenovo: Add additional FMAPs on 8MiB devices
* Add FMAP for measured boot only, with a single RO partition. * Add FMAP for measured boot only, with a single RO partition but where the ME has been stripped and shrunken.
* Add Kconfig Option to default select FMAP and IFD for a shrunken ME.
Tested on X220 using VBOOT+measured boot: * Used patched IFD and ME, boots into OS
Change-Id: I04c1add13198444638c669deec1e05159b1a09c9 Signed-off-by: Marcello Sylvester Bauer sylv@sylv.io Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/mainboard/lenovo/t420/Kconfig A src/mainboard/lenovo/t420/minimal_me.layout A src/mainboard/lenovo/t420/vboot-ro-minimal_me.fmd A src/mainboard/lenovo/t420/vboot-ro.fmd M src/mainboard/lenovo/t420s/Kconfig A src/mainboard/lenovo/t420s/minimal_me.layout A src/mainboard/lenovo/t420s/vboot-ro-minimal_me.fmd A src/mainboard/lenovo/t420s/vboot-ro.fmd M src/mainboard/lenovo/t520/Kconfig A src/mainboard/lenovo/t520/minimal_me.layout A src/mainboard/lenovo/t520/vboot-ro-minimal_me.fmd A src/mainboard/lenovo/t520/vboot-ro.fmd M src/mainboard/lenovo/x220/Kconfig A src/mainboard/lenovo/x220/minimal_me.layout A src/mainboard/lenovo/x220/vboot-ro-minimal_me.fmd A src/mainboard/lenovo/x220/vboot-ro.fmd M src/southbridge/intel/common/firmware/Kconfig 17 files changed, 240 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/39161/4
Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39161 )
Change subject: mb/lenovo: Add additional FMAPs on 8MiB devices ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39161/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39161/3//COMMIT_MSG@11 PS3, Line 11: stripped
stripped and shrunk. Shrunk is maybe a better choice of words.
Done
Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39161 )
Change subject: mb/lenovo: Add additional FMAPs on 8MiB devices ......................................................................
Patch Set 6:
I realized it makes no sense to duplicate all fmaps, due to the fact that they are all equal exept by chip size.. Let me restructure this patchset. And i will remove the shrunk related Kconfigs.
Marcello Sylvester Bauer has uploaded a new patch set (#7) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/39161 )
Change subject: mb/lenovo: Unify vboot FMAPs on Sandy/Ivy bridge boards ......................................................................
mb/lenovo: Unify vboot FMAPs on Sandy/Ivy bridge boards
* Add FMAP for measured boot only, with a single RO partition. * Add FMAP for measured boot only, with a single RO partition but where the ME has been stripped and shrunken.
* Add Kconfig Option to default select FMAPS.
Tested on X220 using VBOOT+measured boot: * Used patched IFD and ME, boots into OS
Change-Id: I04c1add13198444638c669deec1e05159b1a09c9 Signed-off-by: Marcello Sylvester Bauer sylv@sylv.io Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- A src/mainboard/lenovo/12MiB_vboot-ro.fmd A src/mainboard/lenovo/12MiB_vboot-rwa.fmd R src/mainboard/lenovo/12MiB_vboot-rwab.fmd A src/mainboard/lenovo/8MiB_vboot-ro-minimal-me.fmd A src/mainboard/lenovo/8MiB_vboot-ro.fmd R src/mainboard/lenovo/8MiB_vboot-rwa.fmd M src/mainboard/lenovo/Kconfig M src/mainboard/lenovo/t410/Kconfig D src/mainboard/lenovo/t410/vboot-rwa.fmd M src/mainboard/lenovo/t420/Kconfig D src/mainboard/lenovo/t420/vboot-rwa.fmd M src/mainboard/lenovo/t420s/Kconfig D src/mainboard/lenovo/t420s/vboot-rwa.fmd M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430s/Kconfig D src/mainboard/lenovo/t430s/vboot-rwab.fmd M src/mainboard/lenovo/t440p/Kconfig D src/mainboard/lenovo/t440p/vboot-rwab.fmd M src/mainboard/lenovo/t520/Kconfig D src/mainboard/lenovo/t520/vboot-rwa.fmd M src/mainboard/lenovo/t530/Kconfig D src/mainboard/lenovo/t530/vboot-rwab.fmd M src/mainboard/lenovo/x131e/Kconfig D src/mainboard/lenovo/x131e/vboot-rwab.fmd M src/mainboard/lenovo/x1_carbon_gen1/Kconfig D src/mainboard/lenovo/x1_carbon_gen1/vboot-rwab.fmd M src/mainboard/lenovo/x201/Kconfig M src/mainboard/lenovo/x220/Kconfig D src/mainboard/lenovo/x220/vboot-rwa.fmd M src/mainboard/lenovo/x230/Kconfig D src/mainboard/lenovo/x230/vboot-rwab.fmd 31 files changed, 128 insertions(+), 416 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/39161/7
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39161 )
Change subject: mb/lenovo: Unify vboot FMAPs on Sandy/Ivy bridge boards ......................................................................
Patch Set 7:
Patch Set 3: Code-Review+1
(1 comment)
Maybe it's a good idea to unify these laptops someday.
We're getting there. Slowly but steadily!
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39161 )
Change subject: mb/lenovo: Unify vboot FMAPs on Sandy/Ivy bridge boards ......................................................................
Patch Set 7: Code-Review+1
Marcello Sylvester Bauer has uploaded a new patch set (#8) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/39161 )
Change subject: mb/lenovo: Add additional FMAPs on 8MiB devices ......................................................................
mb/lenovo: Add additional FMAPs on 8MiB devices
* Add FMAP for measured boot only, with a single RO partition. * Add FMAP for measured boot only, with a single RO partition but where the ME has been shrunken.
Tested on X220 using VBOOT+measured boot: * Used patched IFD and ME, boots into OS
Change-Id: I04c1add13198444638c669deec1e05159b1a09c9 Signed-off-by: Marcello Sylvester Bauer sylv@sylv.io Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- A src/mainboard/lenovo/t420/vboot-ro-me_clean.fmd A src/mainboard/lenovo/t420/vboot-ro.fmd A src/mainboard/lenovo/t420s/vboot-ro-me_clean.fmd A src/mainboard/lenovo/t420s/vboot-ro.fmd A src/mainboard/lenovo/t520/vboot-ro-me_clean.fmd A src/mainboard/lenovo/t520/vboot-ro.fmd A src/mainboard/lenovo/x220/vboot-ro-me_clean.fmd A src/mainboard/lenovo/x220/vboot-ro.fmd 8 files changed, 176 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/39161/8
Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39161 )
Change subject: mb/lenovo: Add additional FMAPs on 8MiB devices ......................................................................
Patch Set 8:
After talking with Patrick, we desided to separate the changes in to two separated commits, because we have to test all other devices first. Therefore I reversed the patchsets >3.
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39161 )
Change subject: mb/lenovo: Add additional FMAPs on 8MiB devices ......................................................................
Patch Set 8: Code-Review+1
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39161 )
Change subject: mb/lenovo: Add additional FMAPs on 8MiB devices ......................................................................
Patch Set 8: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39161 )
Change subject: mb/lenovo: Add additional FMAPs on 8MiB devices ......................................................................
mb/lenovo: Add additional FMAPs on 8MiB devices
* Add FMAP for measured boot only, with a single RO partition. * Add FMAP for measured boot only, with a single RO partition but where the ME has been shrunken.
Tested on X220 using VBOOT+measured boot: * Used patched IFD and ME, boots into OS
Change-Id: I04c1add13198444638c669deec1e05159b1a09c9 Signed-off-by: Marcello Sylvester Bauer sylv@sylv.io Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39161 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Peter Lemenkov lemenkov@gmail.com --- A src/mainboard/lenovo/t420/vboot-ro-me_clean.fmd A src/mainboard/lenovo/t420/vboot-ro.fmd A src/mainboard/lenovo/t420s/vboot-ro-me_clean.fmd A src/mainboard/lenovo/t420s/vboot-ro.fmd A src/mainboard/lenovo/t520/vboot-ro-me_clean.fmd A src/mainboard/lenovo/t520/vboot-ro.fmd A src/mainboard/lenovo/x220/vboot-ro-me_clean.fmd A src/mainboard/lenovo/x220/vboot-ro.fmd 8 files changed, 176 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Peter Lemenkov: Looks good to me, approved
diff --git a/src/mainboard/lenovo/t420/vboot-ro-me_clean.fmd b/src/mainboard/lenovo/t420/vboot-ro-me_clean.fmd new file mode 100644 index 0000000..d1cbff7 --- /dev/null +++ b/src/mainboard/lenovo/t420/vboot-ro-me_clean.fmd @@ -0,0 +1,22 @@ +FLASH@0xff800000 0x800000 { + SI_ALL 0x20000 { + SI_DESC 0x1000 + SI_GBE 0x2000 + SI_ME + } + SI_BIOS 0x7e0000 { + UNIFIED_MRC_CACHE 0x20000 { + RECOVERY_MRC_CACHE 0x10000 + RW_MRC_CACHE 0x10000 + } + + WP_RO { + FMAP 0x800 + RO_FRID 0x40 + RO_PADDING 0x7c0 + RO_VPD(PRESERVE) 0x1000 + GBB 0x1e000 + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/lenovo/t420/vboot-ro.fmd b/src/mainboard/lenovo/t420/vboot-ro.fmd new file mode 100644 index 0000000..51df8a5 --- /dev/null +++ b/src/mainboard/lenovo/t420/vboot-ro.fmd @@ -0,0 +1,22 @@ +FLASH@0xff800000 0x800000 { + SI_ALL 0x500000 { + SI_DESC 0x1000 + SI_GBE 0x2000 + SI_ME 0x4ed000 + } + SI_BIOS 0x300000 { + UNIFIED_MRC_CACHE 0x20000 { + RECOVERY_MRC_CACHE 0x10000 + RW_MRC_CACHE 0x10000 + } + + WP_RO { + FMAP 0x800 + RO_FRID 0x40 + RO_PADDING 0x7c0 + RO_VPD(PRESERVE) 0x1000 + GBB 0x1e000 + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/lenovo/t420s/vboot-ro-me_clean.fmd b/src/mainboard/lenovo/t420s/vboot-ro-me_clean.fmd new file mode 100644 index 0000000..d1cbff7 --- /dev/null +++ b/src/mainboard/lenovo/t420s/vboot-ro-me_clean.fmd @@ -0,0 +1,22 @@ +FLASH@0xff800000 0x800000 { + SI_ALL 0x20000 { + SI_DESC 0x1000 + SI_GBE 0x2000 + SI_ME + } + SI_BIOS 0x7e0000 { + UNIFIED_MRC_CACHE 0x20000 { + RECOVERY_MRC_CACHE 0x10000 + RW_MRC_CACHE 0x10000 + } + + WP_RO { + FMAP 0x800 + RO_FRID 0x40 + RO_PADDING 0x7c0 + RO_VPD(PRESERVE) 0x1000 + GBB 0x1e000 + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/lenovo/t420s/vboot-ro.fmd b/src/mainboard/lenovo/t420s/vboot-ro.fmd new file mode 100644 index 0000000..51df8a5 --- /dev/null +++ b/src/mainboard/lenovo/t420s/vboot-ro.fmd @@ -0,0 +1,22 @@ +FLASH@0xff800000 0x800000 { + SI_ALL 0x500000 { + SI_DESC 0x1000 + SI_GBE 0x2000 + SI_ME 0x4ed000 + } + SI_BIOS 0x300000 { + UNIFIED_MRC_CACHE 0x20000 { + RECOVERY_MRC_CACHE 0x10000 + RW_MRC_CACHE 0x10000 + } + + WP_RO { + FMAP 0x800 + RO_FRID 0x40 + RO_PADDING 0x7c0 + RO_VPD(PRESERVE) 0x1000 + GBB 0x1e000 + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/lenovo/t520/vboot-ro-me_clean.fmd b/src/mainboard/lenovo/t520/vboot-ro-me_clean.fmd new file mode 100644 index 0000000..d1cbff7 --- /dev/null +++ b/src/mainboard/lenovo/t520/vboot-ro-me_clean.fmd @@ -0,0 +1,22 @@ +FLASH@0xff800000 0x800000 { + SI_ALL 0x20000 { + SI_DESC 0x1000 + SI_GBE 0x2000 + SI_ME + } + SI_BIOS 0x7e0000 { + UNIFIED_MRC_CACHE 0x20000 { + RECOVERY_MRC_CACHE 0x10000 + RW_MRC_CACHE 0x10000 + } + + WP_RO { + FMAP 0x800 + RO_FRID 0x40 + RO_PADDING 0x7c0 + RO_VPD(PRESERVE) 0x1000 + GBB 0x1e000 + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/lenovo/t520/vboot-ro.fmd b/src/mainboard/lenovo/t520/vboot-ro.fmd new file mode 100644 index 0000000..51df8a5 --- /dev/null +++ b/src/mainboard/lenovo/t520/vboot-ro.fmd @@ -0,0 +1,22 @@ +FLASH@0xff800000 0x800000 { + SI_ALL 0x500000 { + SI_DESC 0x1000 + SI_GBE 0x2000 + SI_ME 0x4ed000 + } + SI_BIOS 0x300000 { + UNIFIED_MRC_CACHE 0x20000 { + RECOVERY_MRC_CACHE 0x10000 + RW_MRC_CACHE 0x10000 + } + + WP_RO { + FMAP 0x800 + RO_FRID 0x40 + RO_PADDING 0x7c0 + RO_VPD(PRESERVE) 0x1000 + GBB 0x1e000 + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/lenovo/x220/vboot-ro-me_clean.fmd b/src/mainboard/lenovo/x220/vboot-ro-me_clean.fmd new file mode 100644 index 0000000..d1cbff7 --- /dev/null +++ b/src/mainboard/lenovo/x220/vboot-ro-me_clean.fmd @@ -0,0 +1,22 @@ +FLASH@0xff800000 0x800000 { + SI_ALL 0x20000 { + SI_DESC 0x1000 + SI_GBE 0x2000 + SI_ME + } + SI_BIOS 0x7e0000 { + UNIFIED_MRC_CACHE 0x20000 { + RECOVERY_MRC_CACHE 0x10000 + RW_MRC_CACHE 0x10000 + } + + WP_RO { + FMAP 0x800 + RO_FRID 0x40 + RO_PADDING 0x7c0 + RO_VPD(PRESERVE) 0x1000 + GBB 0x1e000 + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/lenovo/x220/vboot-ro.fmd b/src/mainboard/lenovo/x220/vboot-ro.fmd new file mode 100644 index 0000000..51df8a5 --- /dev/null +++ b/src/mainboard/lenovo/x220/vboot-ro.fmd @@ -0,0 +1,22 @@ +FLASH@0xff800000 0x800000 { + SI_ALL 0x500000 { + SI_DESC 0x1000 + SI_GBE 0x2000 + SI_ME 0x4ed000 + } + SI_BIOS 0x300000 { + UNIFIED_MRC_CACHE 0x20000 { + RECOVERY_MRC_CACHE 0x10000 + RW_MRC_CACHE 0x10000 + } + + WP_RO { + FMAP 0x800 + RO_FRID 0x40 + RO_PADDING 0x7c0 + RO_VPD(PRESERVE) 0x1000 + GBB 0x1e000 + COREBOOT(CBFS) + } + } +}
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Marcello Sylvester Bauer (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Peter Lemenkov (Code Review)