HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37502 )
Change subject: superio/{aspeed,nuvoton}: Fix typo ......................................................................
superio/{aspeed,nuvoton}: Fix typo
Change-Id: I7772fadc756ceeef5988e4b1ecf8f93ad3605a84 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/aspeed/ast2400/superio.c M src/superio/nuvoton/nct6791d/superio.c 2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/37502/1
diff --git a/src/superio/aspeed/ast2400/superio.c b/src/superio/aspeed/ast2400/superio.c index c5df8b5..a41bba7 100644 --- a/src/superio/aspeed/ast2400/superio.c +++ b/src/superio/aspeed/ast2400/superio.c @@ -48,9 +48,9 @@ return NULL;
switch (dev->path.pnp.device & 0xff) { - case AST2400_SUART1: /* falltrough */ - case AST2400_SUART2: /* falltrough */ - case AST2400_SUART3: /* falltrough */ + case AST2400_SUART1: /* fallthrough */ + case AST2400_SUART2: /* fallthrough */ + case AST2400_SUART3: /* fallthrough */ case AST2400_SUART4: return ACPI_HID_COM; case AST2400_KBC: diff --git a/src/superio/nuvoton/nct6791d/superio.c b/src/superio/nuvoton/nct6791d/superio.c index 08f0bfa..ed8f5c3 100644 --- a/src/superio/nuvoton/nct6791d/superio.c +++ b/src/superio/nuvoton/nct6791d/superio.c @@ -48,7 +48,7 @@ return NULL;
switch (dev->path.pnp.device & 0xff) { - case NCT6791D_SP1: /* falltrough */ + case NCT6791D_SP1: /* fallthrough */ case NCT6791D_SP2: return ACPI_HID_COM; case NCT6791D_KBC:
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37502 )
Change subject: superio/{aspeed,nuvoton}: Fix typo ......................................................................
Patch Set 1: Code-Review+1
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37502 )
Change subject: superio/{aspeed,nuvoton}: Fix typo ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37502 )
Change subject: superio/{aspeed,nuvoton}: Fix typo ......................................................................
superio/{aspeed,nuvoton}: Fix typo
Change-Id: I7772fadc756ceeef5988e4b1ecf8f93ad3605a84 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/37502 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/superio/aspeed/ast2400/superio.c M src/superio/nuvoton/nct6791d/superio.c 2 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved
diff --git a/src/superio/aspeed/ast2400/superio.c b/src/superio/aspeed/ast2400/superio.c index c5df8b5..a41bba7 100644 --- a/src/superio/aspeed/ast2400/superio.c +++ b/src/superio/aspeed/ast2400/superio.c @@ -48,9 +48,9 @@ return NULL;
switch (dev->path.pnp.device & 0xff) { - case AST2400_SUART1: /* falltrough */ - case AST2400_SUART2: /* falltrough */ - case AST2400_SUART3: /* falltrough */ + case AST2400_SUART1: /* fallthrough */ + case AST2400_SUART2: /* fallthrough */ + case AST2400_SUART3: /* fallthrough */ case AST2400_SUART4: return ACPI_HID_COM; case AST2400_KBC: diff --git a/src/superio/nuvoton/nct6791d/superio.c b/src/superio/nuvoton/nct6791d/superio.c index 08f0bfa..ed8f5c3 100644 --- a/src/superio/nuvoton/nct6791d/superio.c +++ b/src/superio/nuvoton/nct6791d/superio.c @@ -48,7 +48,7 @@ return NULL;
switch (dev->path.pnp.device & 0xff) { - case NCT6791D_SP1: /* falltrough */ + case NCT6791D_SP1: /* fallthrough */ case NCT6791D_SP2: return ACPI_HID_COM; case NCT6791D_KBC:
-
Felix Held (Code Review) -
HAOUAS Elyes (Code Review)
-
Paul Menzel (Code Review)