Change in coreboot[master]: soc/intel/tigerlake: Don't override lpc_io_setup_comm_a_b() - coreboot-gerrit

3 Feb 2022


      Attention is currently required from: Sean Rhodes, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61552 )
Change subject: soc/intel/tigerlake: Don't override lpc_io_setup_comm_a_b()
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: 
Unless I'm missing something, I don't think it will override lpc_io_setup... 
lpc_enable_fixed_io_ranges() ORs in the bits you selected to LPC_IO_ENABLEs, therefore it shouldn't disable anything that lpc_io_setup... would have done.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/61552
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c28e8dcc1813740b2862b340c95bb80dab9d91e
Gerrit-Change-Number: 61552
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Thu, 03 Feb 2022 15:49:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment