Change in coreboot[master]: soc/amd/cezanne: Turn off gpp clock request for disabled devices
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Rob Barnes. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61259 ) Change subject: soc/amd/cezanne: Turn off gpp clock request for disabled devices ...................................................................... Patch Set 11: (9 comments) File src/soc/amd/cezanne/platform_descriptors.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139892): https://review.coreboot.org/c/coreboot/+/61259/comment/67327aba_09ae0c96 PS11, Line 9: *dxio_descs = NULL; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139892): https://review.coreboot.org/c/coreboot/+/61259/comment/2894711b_f8e75767 PS11, Line 9: *dxio_descs = NULL; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139892): https://review.coreboot.org/c/coreboot/+/61259/comment/684290e0_0fbf3517 PS11, Line 10: *dxio_num = 0; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139892): https://review.coreboot.org/c/coreboot/+/61259/comment/a588c817_60fb652f PS11, Line 10: *dxio_num = 0; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139892): https://review.coreboot.org/c/coreboot/+/61259/comment/741be26c_0dcfb80f PS11, Line 11: *ddi_descs = NULL; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139892): https://review.coreboot.org/c/coreboot/+/61259/comment/d58cc9c4_d9ae1097 PS11, Line 11: *ddi_descs = NULL; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139892): https://review.coreboot.org/c/coreboot/+/61259/comment/01a56a8d_701a6f1c PS11, Line 12: *ddi_num = 0; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139892): https://review.coreboot.org/c/coreboot/+/61259/comment/570e624a_9452fab7 PS11, Line 12: *ddi_num = 0; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139892): https://review.coreboot.org/c/coreboot/+/61259/comment/724d39a5_592ab918 PS11, Line 13: } adding a line without newline at end of file -- To view, visit https://review.coreboot.org/c/coreboot/+/61259 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I77389372c60bdec572622a3b49484d4789fd4e4c Gerrit-Change-Number: 61259 Gerrit-PatchSet: 11 Gerrit-Owner: Robert Zieba <robertzieba@google.com> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Eric Peers <epeers@google.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk@gmail.com> Gerrit-Attention: Raul Rangel <rrangel@chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd@gmail.com> Gerrit-Attention: Rob Barnes <robbarnes@google.com> Gerrit-Comment-Date: Thu, 03 Feb 2022 15:49:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
participants (1)
-
build bot (Jenkins) (Code Review)