Attention is currently required from: Elyes Haouas, Martin L Roth, Nico Huber.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79915?usp=email )
Change subject: Makefile.inc: Enable Wxor-used-as-pow command option ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79915/comment/3e5b3081_63d5c674 : PS1, Line 10: meant exponentiation. https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html says
Specifically, the warning occurs when the left-hand side is the decimal constant 2 or 10 and the right-hand side is also a decimal constant.
Which seems useless enough in actual code that I wouldn't expect any false positives. However, it also says "This warning is enabled by default.", so do we actually need to add it to the Makefile explicitly?
-
Julius Werner (Code Review)