Attention is currently required from: Elyes Haouas, Martin L Roth, Nico Huber.
View Change
1 comment:
Commit Message:
Patch Set #1, Line 10: meant exponentiation.
https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html says
Specifically, the warning occurs when the left-hand side is the decimal constant 2 or 10 and the right-hand side is also a decimal constant.
Which seems useless enough in actual code that I wouldn't expect any false positives. However, it also says "This warning is enabled by default.", so do we actually need to add it to the Makefile explicitly?
To view, visit change 79915. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6ae83c676ab347510f5dfa7d34a7b04ee439e9b6
Gerrit-Change-Number: 79915
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas@noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Julius Werner <jwerner@chromium.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Martin L Roth <gaumless@gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas@noos.fr>
Gerrit-Comment-Date: Fri, 12 Jan 2024 23:58:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment