Change in coreboot[master]: sb/intel/ibexpeak: Remove undocumented reset defaults from RCBA replay
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35760 )
Change subject: sb/intel/ibexpeak: Remove undocumented reset defaults from RCBA replay ......................................................................
sb/intel/ibexpeak: Remove undocumented reset defaults from RCBA replay
The values read back in those ranges are identical before and after this change and it still boots fine.
Change-Id: I406510e0573ac97003da7d97181abdfbfd2a872f Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/lenovo/x201/romstage.c M src/mainboard/packardbell/ms2290/romstage.c 2 files changed, 0 insertions(+), 38 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/35760/1
diff --git a/src/mainboard/lenovo/x201/romstage.c b/src/mainboard/lenovo/x201/romstage.c index 6b74cb2..04d1d79 100644 --- a/src/mainboard/lenovo/x201/romstage.c +++ b/src/mainboard/lenovo/x201/romstage.c @@ -91,25 +91,6 @@ /* 35d0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 35e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 35f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3600 */ 0x0a001f00, 0x00000000, 0x00000000, 0x00000001, - /* 3610 */ 0x00010000, 0x00000000, 0x00000000, 0x00000000, - /* 3620 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3630 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3640 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3650 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3660 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3670 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3680 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3690 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36a0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36d0 */ 0x00000000, 0x089c0018, 0x00000000, 0x00000000, - /* 36e0 */ 0x11111111, 0x00000000, 0x00000000, 0x00000000, - /* 36f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3700 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3710 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3720 */ 0x00000000, 0x4e564d49, 0x00000000, 0x00000000, }; unsigned i; for (i = 0; i < sizeof(rcba_dump3) / 4; i++) { diff --git a/src/mainboard/packardbell/ms2290/romstage.c b/src/mainboard/packardbell/ms2290/romstage.c index de318ec..b4b9755 100644 --- a/src/mainboard/packardbell/ms2290/romstage.c +++ b/src/mainboard/packardbell/ms2290/romstage.c @@ -86,25 +86,6 @@ /* 35d0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 35e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 35f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3600 */ 0x0a001f00, 0x00000000, 0x00000000, 0x00000001, - /* 3610 */ 0x00010000, 0x00000000, 0x00000000, 0x00000000, - /* 3620 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3630 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3640 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3650 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3660 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3670 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3680 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3690 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36a0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36d0 */ 0x00000000, 0x089c0018, 0x00000000, 0x00000000, - /* 36e0 */ 0x11111111, 0x00000000, 0x00000000, 0x00000000, - /* 36f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3700 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3710 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3720 */ 0x00000000, 0x4e564d49, 0x00000000, 0x00000000, }; unsigned i;
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35760 )
Change subject: sb/intel/ibexpeak: Remove undocumented reset defaults from RCBA replay ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35760/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35760/1//COMMIT_MSG@10 PS1, Line 10: this change and it still boots fine. Tested on both platforms?
Hello Alexander Couzens, Patrick Rudolph, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35760
to look at the new patch set (#2).
Change subject: sb/intel/ibexpeak: Remove undocumented reset defaults from RCBA replay ......................................................................
sb/intel/ibexpeak: Remove undocumented reset defaults from RCBA replay
The values read back in those ranges are identical before and after this change and the Lenovo Thinkpad X201 still boots fine.
Change-Id: I406510e0573ac97003da7d97181abdfbfd2a872f Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/lenovo/x201/romstage.c M src/mainboard/packardbell/ms2290/romstage.c 2 files changed, 0 insertions(+), 38 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/35760/2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35760 )
Change subject: sb/intel/ibexpeak: Remove undocumented reset defaults from RCBA replay ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35760/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35760/1//COMMIT_MSG@10 PS1, Line 10: this change and it still boots fine.
Tested on both platforms?
Only on x201. I'll update the commit message.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35760 )
Change subject: intel/ibexpeak boards: Remove undocumented reset defaults from RCBA replay ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35760/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35760/1//COMMIT_MSG@10 PS1, Line 10: this change and it still boots fine.
Tested on both platforms? […]
Done
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35760 )
Change subject: intel/ibexpeak boards: Remove undocumented reset defaults from RCBA replay ......................................................................
Patch Set 6: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35760 )
Change subject: intel/ibexpeak boards: Remove undocumented reset defaults from RCBA replay ......................................................................
Patch Set 7: Code-Review+2
Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35760 )
Change subject: intel/ibexpeak boards: Remove undocumented reset defaults from RCBA replay ......................................................................
intel/ibexpeak boards: Remove undocumented reset defaults from RCBA replay
The values read back in those ranges are identical before and after this change and the Lenovo Thinkpad X201 still boots fine.
Change-Id: I406510e0573ac97003da7d97181abdfbfd2a872f Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/35760 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Patrick Rudolph siro@das-labor.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/lenovo/x201/romstage.c M src/mainboard/packardbell/ms2290/romstage.c 2 files changed, 0 insertions(+), 38 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Patrick Rudolph: Looks good to me, approved
diff --git a/src/mainboard/lenovo/x201/romstage.c b/src/mainboard/lenovo/x201/romstage.c index 1d364b6..4f2a3da 100644 --- a/src/mainboard/lenovo/x201/romstage.c +++ b/src/mainboard/lenovo/x201/romstage.c @@ -90,25 +90,6 @@ /* 35d0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 35e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 35f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3600 */ 0x0a001f00, 0x00000000, 0x00000000, 0x00000001, - /* 3610 */ 0x00010000, 0x00000000, 0x00000000, 0x00000000, - /* 3620 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3630 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3640 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3650 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3660 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3670 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3680 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3690 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36a0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36d0 */ 0x00000000, 0x089c0018, 0x00000000, 0x00000000, - /* 36e0 */ 0x11111111, 0x00000000, 0x00000000, 0x00000000, - /* 36f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3700 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3710 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3720 */ 0x00000000, 0x4e564d49, 0x00000000, 0x00000000, }; unsigned i; for (i = 0; i < sizeof(rcba_dump3) / 4; i++) { diff --git a/src/mainboard/packardbell/ms2290/romstage.c b/src/mainboard/packardbell/ms2290/romstage.c index 00461a1..a292f7b 100644 --- a/src/mainboard/packardbell/ms2290/romstage.c +++ b/src/mainboard/packardbell/ms2290/romstage.c @@ -85,25 +85,6 @@ /* 35d0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 35e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 35f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3600 */ 0x0a001f00, 0x00000000, 0x00000000, 0x00000001, - /* 3610 */ 0x00010000, 0x00000000, 0x00000000, 0x00000000, - /* 3620 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3630 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3640 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3650 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3660 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3670 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3680 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3690 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36a0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36d0 */ 0x00000000, 0x089c0018, 0x00000000, 0x00000000, - /* 36e0 */ 0x11111111, 0x00000000, 0x00000000, 0x00000000, - /* 36f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3700 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3710 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3720 */ 0x00000000, 0x4e564d49, 0x00000000, 0x00000000, }; unsigned i;
-
Arthur Heymans (Code Review) -
Kyösti Mälkki (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)