Arthur Heymans submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Patrick Rudolph: Looks good to me, approved
intel/ibexpeak boards: Remove undocumented reset defaults from RCBA replay

The values read back in those ranges are identical before and after
this change and the Lenovo Thinkpad X201 still boots fine.

Change-Id: I406510e0573ac97003da7d97181abdfbfd2a872f
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35760
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/lenovo/x201/romstage.c
M src/mainboard/packardbell/ms2290/romstage.c
2 files changed, 0 insertions(+), 38 deletions(-)

diff --git a/src/mainboard/lenovo/x201/romstage.c b/src/mainboard/lenovo/x201/romstage.c
index 1d364b6..4f2a3da 100644
--- a/src/mainboard/lenovo/x201/romstage.c
+++ b/src/mainboard/lenovo/x201/romstage.c
@@ -90,25 +90,6 @@
/* 35d0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 35e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 35f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3600 */ 0x0a001f00, 0x00000000, 0x00000000, 0x00000001,
- /* 3610 */ 0x00010000, 0x00000000, 0x00000000, 0x00000000,
- /* 3620 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3630 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3640 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3650 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3660 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3670 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3680 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3690 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 36a0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 36b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 36c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 36d0 */ 0x00000000, 0x089c0018, 0x00000000, 0x00000000,
- /* 36e0 */ 0x11111111, 0x00000000, 0x00000000, 0x00000000,
- /* 36f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3700 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3710 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3720 */ 0x00000000, 0x4e564d49, 0x00000000, 0x00000000,
};
unsigned i;
for (i = 0; i < sizeof(rcba_dump3) / 4; i++) {
diff --git a/src/mainboard/packardbell/ms2290/romstage.c b/src/mainboard/packardbell/ms2290/romstage.c
index 00461a1..a292f7b 100644
--- a/src/mainboard/packardbell/ms2290/romstage.c
+++ b/src/mainboard/packardbell/ms2290/romstage.c
@@ -85,25 +85,6 @@
/* 35d0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 35e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 35f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3600 */ 0x0a001f00, 0x00000000, 0x00000000, 0x00000001,
- /* 3610 */ 0x00010000, 0x00000000, 0x00000000, 0x00000000,
- /* 3620 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3630 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3640 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3650 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3660 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3670 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3680 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3690 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 36a0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 36b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 36c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 36d0 */ 0x00000000, 0x089c0018, 0x00000000, 0x00000000,
- /* 36e0 */ 0x11111111, 0x00000000, 0x00000000, 0x00000000,
- /* 36f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3700 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3710 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
- /* 3720 */ 0x00000000, 0x4e564d49, 0x00000000, 0x00000000,
};
unsigned i;


To view, visit change 35760. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I406510e0573ac97003da7d97181abdfbfd2a872f
Gerrit-Change-Number: 35760
Gerrit-PatchSet: 11
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged