Hello Iru Cai,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/45576
to review the following change.
Change subject: ec/hp/kbc1126: Support using a different GPE ......................................................................
ec/hp/kbc1126: Support using a different GPE
HP EliteBook Folio 9480m uses the HP KBC1126 EC ACPI interface, but with a different GPE, so add a Kconfig option to support using a different GPE.
Change-Id: I3b78567e1387c96bf173e4370aa3c836bbddac0b Signed-off-by: Iru Cai mytbk920423@gmail.com --- M src/ec/hp/kbc1126/Kconfig M src/ec/hp/kbc1126/acpi/ec.asl 2 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/45576/1
diff --git a/src/ec/hp/kbc1126/Kconfig b/src/ec/hp/kbc1126/Kconfig index fa2414a..957fdd5 100644 --- a/src/ec/hp/kbc1126/Kconfig +++ b/src/ec/hp/kbc1126/Kconfig @@ -10,6 +10,11 @@ depends on EC_HP_KBC1126 default y
+config EC_HP_KBC1126_GPE + hex + depends on EC_HP_KBC1126 + default 0x16 + if EC_HP_KBC1126_ECFW_IN_CBFS
comment "Please select the following otherwise your laptop cannot be powered on." diff --git a/src/ec/hp/kbc1126/acpi/ec.asl b/src/ec/hp/kbc1126/acpi/ec.asl index e5752a8..81bdff9 100644 --- a/src/ec/hp/kbc1126/acpi/ec.asl +++ b/src/ec/hp/kbc1126/acpi/ec.asl @@ -4,7 +4,7 @@ { Name (_HID, EISAID("PNP0C09")) Name (_UID, 0) - Name (_GPE, 0x16) + Name (_GPE, CONFIG_EC_HP_KBC1126_GPE)
Name (_CRS, ResourceTemplate () {
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45576 )
Change subject: ec/hp/kbc1126: Support using a different GPE ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45576/1/src/ec/hp/kbc1126/Kconfig File src/ec/hp/kbc1126/Kconfig:
https://review.coreboot.org/c/coreboot/+/45576/1/src/ec/hp/kbc1126/Kconfig@1... PS1, Line 16: default 0x16 Nit, maybe move above so that the _CBFS config sticks with the if below?
Hello build bot (Jenkins), Nico Huber, Iru Cai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45576
to look at the new patch set (#2).
Change subject: ec/hp/kbc1126: Support using a different GPE ......................................................................
ec/hp/kbc1126: Support using a different GPE
HP EliteBook Folio 9480m uses the HP KBC1126 EC ACPI interface, but with a different GPE, so add a Kconfig option to support using a different GPE.
Change-Id: I3b78567e1387c96bf173e4370aa3c836bbddac0b Signed-off-by: Iru Cai mytbk920423@gmail.com --- M src/ec/hp/kbc1126/Kconfig M src/ec/hp/kbc1126/acpi/ec.asl 2 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/45576/2
Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45576 )
Change subject: ec/hp/kbc1126: Support using a different GPE ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45576/1/src/ec/hp/kbc1126/Kconfig File src/ec/hp/kbc1126/Kconfig:
https://review.coreboot.org/c/coreboot/+/45576/1/src/ec/hp/kbc1126/Kconfig@1... PS1, Line 16: default 0x16
Nit, maybe move above so that the _CBFS config sticks with the if below?
done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45576 )
Change subject: ec/hp/kbc1126: Support using a different GPE ......................................................................
Patch Set 6: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45576 )
Change subject: ec/hp/kbc1126: Support using a different GPE ......................................................................
ec/hp/kbc1126: Support using a different GPE
HP EliteBook Folio 9480m uses the HP KBC1126 EC ACPI interface, but with a different GPE, so add a Kconfig option to support using a different GPE.
Change-Id: I3b78567e1387c96bf173e4370aa3c836bbddac0b Signed-off-by: Iru Cai mytbk920423@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45576 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/ec/hp/kbc1126/Kconfig M src/ec/hp/kbc1126/acpi/ec.asl 2 files changed, 6 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/ec/hp/kbc1126/Kconfig b/src/ec/hp/kbc1126/Kconfig index fa2414a..cb4ddec 100644 --- a/src/ec/hp/kbc1126/Kconfig +++ b/src/ec/hp/kbc1126/Kconfig @@ -5,6 +5,11 @@ help Interface to SMSC KBC1126 embedded controller in HP laptops.
+config EC_HP_KBC1126_GPE + hex + depends on EC_HP_KBC1126 + default 0x16 + config EC_HP_KBC1126_ECFW_IN_CBFS bool depends on EC_HP_KBC1126 diff --git a/src/ec/hp/kbc1126/acpi/ec.asl b/src/ec/hp/kbc1126/acpi/ec.asl index e5752a8..81bdff9 100644 --- a/src/ec/hp/kbc1126/acpi/ec.asl +++ b/src/ec/hp/kbc1126/acpi/ec.asl @@ -4,7 +4,7 @@ { Name (_HID, EISAID("PNP0C09")) Name (_UID, 0) - Name (_GPE, 0x16) + Name (_GPE, CONFIG_EC_HP_KBC1126_GPE)
Name (_CRS, ResourceTemplate () {
-
Angel Pons (Code Review) -
Iru Cai (vimacs) (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)