Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
ec/hp/kbc1126: Support using a different GPE

HP EliteBook Folio 9480m uses the HP KBC1126 EC ACPI interface, but
with a different GPE, so add a Kconfig option to support using a
different GPE.

Change-Id: I3b78567e1387c96bf173e4370aa3c836bbddac0b
Signed-off-by: Iru Cai <mytbk920423@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45576
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/ec/hp/kbc1126/Kconfig
M src/ec/hp/kbc1126/acpi/ec.asl
2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/ec/hp/kbc1126/Kconfig b/src/ec/hp/kbc1126/Kconfig
index fa2414a..cb4ddec 100644
--- a/src/ec/hp/kbc1126/Kconfig
+++ b/src/ec/hp/kbc1126/Kconfig
@@ -5,6 +5,11 @@
help
Interface to SMSC KBC1126 embedded controller in HP laptops.

+config EC_HP_KBC1126_GPE
+ hex
+ depends on EC_HP_KBC1126
+ default 0x16
+
config EC_HP_KBC1126_ECFW_IN_CBFS
bool
depends on EC_HP_KBC1126
diff --git a/src/ec/hp/kbc1126/acpi/ec.asl b/src/ec/hp/kbc1126/acpi/ec.asl
index e5752a8..81bdff9 100644
--- a/src/ec/hp/kbc1126/acpi/ec.asl
+++ b/src/ec/hp/kbc1126/acpi/ec.asl
@@ -4,7 +4,7 @@
{
Name (_HID, EISAID("PNP0C09"))
Name (_UID, 0)
- Name (_GPE, 0x16)
+ Name (_GPE, CONFIG_EC_HP_KBC1126_GPE)

Name (_CRS, ResourceTemplate ()
{

To view, visit change 45576. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b78567e1387c96bf173e4370aa3c836bbddac0b
Gerrit-Change-Number: 45576
Gerrit-PatchSet: 7
Gerrit-Owner: Iru Cai (vimacs) <mytbk920423@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Iru Cai <mytbk920423@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged