Attention is currently required from: Furquan Shaikh, Chiranjeevi Rapolu, Tim Wawrzynczak, John Zhao, Duncan Laurie. Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51195 )
Change subject: mb/google/volteer: Configure tcss port information for early tcss init ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/51195/comment/a4f1c2a4_4ca7661a PS1, Line 182: mux_info
mux_info is never really allocated space. So, this code ends up writing at address 0. […]
My only thing with this is how would we define MAX_TYPE_C_PORTS? for TGL that is 4 but we are only using 2 on Chrome in most cases. That is the only reason I did it as I did cause then we can just count the ports based on each devicetree of the board.
https://review.coreboot.org/c/coreboot/+/51195/comment/a75827a5_01c7e8fd PS1, Line 186: get_connector_config
This function can be called with mux as a pointer rather than having to fetch mux pointer every time […]
Yeah that makes more sense then fetching all the devices should save some time only fetching them once