Attention is currently required from: Furquan Shaikh, Chiranjeevi Rapolu, Tim Wawrzynczak, John Zhao, Duncan Laurie.
2 comments:
File src/mainboard/google/volteer/mainboard.c:
Patch Set #1, Line 182: mux_info
mux_info is never really allocated space. So, this code ends up writing at address 0. […]
My only thing with this is how would we define MAX_TYPE_C_PORTS? for TGL that is 4 but we are only using 2 on Chrome in most cases. That is the only reason I did it as I did cause then we can just count the ports based on each devicetree of the board.
Patch Set #1, Line 186: get_connector_config
This function can be called with mux as a pointer rather than having to fetch mux pointer every time […]
Yeah that makes more sense then fetching all the devices should save some time only fetching them once
To view, visit change 51195. To unsubscribe, or for help writing mail filters, visit settings.