Attention is currently required from: Alexander Couzens, Pratikkumar V Prajapati.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75214?usp=email )
Change subject: inteltool: improve support for Elkhart Lake ......................................................................
Patch Set 5:
(2 comments)
File util/inteltool/spi.c:
https://review.coreboot.org/c/coreboot/+/75214/comment/51e96010_3538bd82 : PS5, Line 426: case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_PRE: : case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_BASE_SKL: : case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_Y_PREM_SKL: : case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_PREM_SKL: : case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_BASE_KBL: : case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_PREM_KBL: : case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_Y_PREM_KBL: : case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_IHDCP_BASE: : case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_IHDCP_PREM: : case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_Y_IHDCP_PREM: These also have a dedicated SPI device, code should be updated. But not in this patch
https://review.coreboot.org/c/coreboot/+/75214/comment/225eb1a6_88841088 : PS5, Line 450: !rcba_size Isn't this check a bit redundant?