Attention is currently required from: Alexander Couzens, Pratikkumar V Prajapati.

View Change

2 comments:

• File util/inteltool/spi.c:

  • Patch Set #5, Line 426:

    case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_PRE:
    	case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_BASE_SKL:
    	case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_Y_PREM_SKL:
    	case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_PREM_SKL:
    	case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_BASE_KBL:
    	case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_PREM_KBL:
    	case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_Y_PREM_KBL:
    	case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_IHDCP_BASE:
    	case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_IHDCP_PREM:
    	case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_Y_IHDCP_PREM:
    

    These also have a dedicated SPI device, code should be updated. But not in this patch

  • Patch Set #5, Line 450: !rcba_size

    Isn't this check a bit redundant?

To view, visit change 75214. To unsubscribe, or for help writing mail filters, visit settings.