Attention is currently required from: Jakub Czapiga. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59494 )
Change subject: libpayload/libc/fmap: Implement new FlashMap API ......................................................................
Patch Set 2:
(4 comments)
File payloads/libpayload/include/fmap.h:
https://review.coreboot.org/c/coreboot/+/59494/comment/acf2d7c0_10ac1cc1 PS2, Line 9: lib_sysinfo.fmap_offset and boot device read function I don't think we need to support the second case? lib_sysinfo.fmap_cache should always exist. (Note that CONFIG_NO_FMAP_CACHE in coreboot only refers to the pre-RAM cache... fmap_setup_cbmem_cache() still runs to create the cache in CBMEM after RAM is up even if that option is disabled. The only way this cache could not exist is if there was some error reading the FMAP in coreboot, and in that case there's probably little point trying to read it from libpayload either.)
https://review.coreboot.org/c/coreboot/+/59494/comment/e6064d5e_0ecbc705 PS2, Line 10: * nit: missing space. also maybe clarify what is returned on error.
https://review.coreboot.org/c/coreboot/+/59494/comment/b7a2845c_86bfd0d1 PS2, Line 11: int Should we use cb_err_t here?
File payloads/libpayload/libc/fmap.c:
https://review.coreboot.org/c/coreboot/+/59494/comment/becc5c44_219fb8cf PS2, Line 113: Maybe add a comment to make the line between new code and old, deprecated code here clearer.
-
Julius Werner (Code Review)