Attention is currently required from: Jakub Czapiga.

View Change

4 comments:

• File payloads/libpayload/include/fmap.h:

  • Patch Set #2, Line 9: lib_sysinfo.fmap_offset and boot device read function

    I don't think we need to support the second case? lib_sysinfo.fmap_cache should always exist. (Note that CONFIG_NO_FMAP_CACHE in coreboot only refers to the pre-RAM cache... fmap_setup_cbmem_cache() still runs to create the cache in CBMEM after RAM is up even if that option is disabled. The only way this cache could not exist is if there was some error reading the FMAP in coreboot, and in that case there's probably little point trying to read it from libpayload either.)

  • Patch Set #2, Line 10: *

    nit: missing space. also maybe clarify what is returned on error.

  • Patch Set #2, Line 11: int

    Should we use cb_err_t here?

• File payloads/libpayload/libc/fmap.c:

  • Patch Set #2, Line 113:

    Maybe add a comment to make the line between new code and old, deprecated code here clearer.

To view, visit change 59494. To unsubscribe, or for help writing mail filters, visit settings.