Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34615 )
Change subject: mb/google/hatch/variants: Set PsysPL2 and PL4 values ......................................................................
mb/google/hatch/variants: Set PsysPL2 and PL4 values
Set PsysPL2 to 51W and PL4 to 82W based for CML-U based system design.
Change-Id: I6a1f380547805d523a29c766903ffc6ba0023ac1 Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/34615/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index 6ff90f8..0b28116 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -37,6 +37,8 @@ register "dptf_enable" = "1" register "tdp_pl1_override" = "15" register "tdp_pl2_override" = "64" + register "tdp_psyspl2" = "51" + register "tdp_pl4" = "82" register "Device4Enable" = "1" # Enable eDP device register "DdiPortEdp" = "1"
Hello Aaron Durbin, Duncan Laurie, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34615
to look at the new patch set (#2).
Change subject: mb/google/hatch/variants: Set PsysPL2 and PL4 values ......................................................................
mb/google/hatch/variants: Set PsysPL2 and PL4 values
Set PsysPL2 to 70W and PL4 to 82W based for CML-U based system design.
Change-Id: I6a1f380547805d523a29c766903ffc6ba0023ac1 Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/34615/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34615 )
Change subject: mb/google/hatch/variants: Set PsysPL2 and PL4 values ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34615/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34615/2//COMMIT_MSG@9 PS2, Line 9: PsysPL2 to 70W and PL4 to 82W How were these values calculated?
https://review.coreboot.org/c/coreboot/+/34615/2//COMMIT_MSG@9 PS2, Line 9: PL4 to 82W Is this good to keep the device up when booting without battery?
https://review.coreboot.org/c/coreboot/+/34615/2//COMMIT_MSG@10 PS2, Line 10: BUG=?
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34615 )
Change subject: mb/google/hatch/variants: Set PsysPL2 and PL4 values ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34615/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34615/2//COMMIT_MSG@9 PS2, Line 9: PL4 to 82W
Is this good to keep the device up when booting without battery?
yes
https://review.coreboot.org/c/coreboot/+/34615/2//COMMIT_MSG@9 PS2, Line 9: PsysPL2 to 70W and PL4 to 82W
How were these values calculated?
Added detailed info on bug#c4. PL4 is as per the spec and PsysPL2 as per the calculated system power.
https://review.coreboot.org/c/coreboot/+/34615/2//COMMIT_MSG@10 PS2, Line 10:
BUG=?
I will add bug info as BUG=138269131.
Hello Aaron Durbin, Duncan Laurie, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34615
to look at the new patch set (#3).
Change subject: mb/google/hatch/variants: Set PsysPL2 and PL4 values ......................................................................
mb/google/hatch/variants: Set PsysPL2 and PL4 values
Set PsysPL2 to 70W and PL4 to 82W based for CML-U based system design.
BUG=138269131 BRANCH=None TEST=Built and booted the hatch system with this configuration.
Change-Id: I6a1f380547805d523a29c766903ffc6ba0023ac1 Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/34615/3
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34615 )
Change subject: mb/google/hatch/variants: Set PsysPL2 and PL4 values ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34615/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34615/3//COMMIT_MSG@11 PS3, Line 11: 138269131 b:138269131
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34615?usp=email )
Change subject: mb/google/hatch/variants: Set PsysPL2 and PL4 values ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-
Furquan Shaikh (Code Review) -
Martin L Roth (Code Review)
-
Sumeet R Pawnikar (Code Review)