Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33860
Change subject: util/ifdtool: Make internal functions static ......................................................................
util/ifdtool: Make internal functions static
These functions are only used in ifdtool, so they can be made static.
Change-Id: Ia48bfecb89a7445dbd0f140acb5ac0592da2ebe7 Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M util/ifdtool/ifdtool.c 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/33860/1
diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index a1a327f..83caa69 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -1067,7 +1067,7 @@ }
/* Set the AltMeDisable (or HAP for >= IFD_VERSION_2) */ -void fpsba_set_altmedisable(fpsba_t *fpsba, fmsba_t *fmsba, bool altmedisable) +static void fpsba_set_altmedisable(fpsba_t *fpsba, fmsba_t *fmsba, bool altmedisable) { if (ifd_version >= IFD_VERSION_2) { printf("%sting the HAP bit to %s Intel ME...\n", @@ -1107,7 +1107,7 @@ } }
-void inject_region(const char *filename, char *image, int size, +static void inject_region(const char *filename, char *image, int size, unsigned int region_type, const char *region_fname) { frba_t *frba = find_frba(image, size); @@ -1173,7 +1173,7 @@ write_image(filename, image, size); }
-unsigned int next_pow2(unsigned int x) +static unsigned int next_pow2(unsigned int x) { unsigned int y = 1; if (x == 0) @@ -1200,7 +1200,7 @@ return !(r1->limit < r2->base || r1->base > r2->limit); }
-void new_layout(const char *filename, char *image, int size, +static void new_layout(const char *filename, char *image, int size, const char *layout_fname) { FILE *romlayout;
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33860 )
Change subject: util/ifdtool: Make internal functions static ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33860 )
Change subject: util/ifdtool: Make internal functions static ......................................................................
util/ifdtool: Make internal functions static
These functions are only used in ifdtool, so they can be made static.
Change-Id: Ia48bfecb89a7445dbd0f140acb5ac0592da2ebe7 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Reviewed-on: https://review.coreboot.org/c/coreboot/+/33860 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M util/ifdtool/ifdtool.c 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index a1a327f..83caa69 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -1067,7 +1067,7 @@ }
/* Set the AltMeDisable (or HAP for >= IFD_VERSION_2) */ -void fpsba_set_altmedisable(fpsba_t *fpsba, fmsba_t *fmsba, bool altmedisable) +static void fpsba_set_altmedisable(fpsba_t *fpsba, fmsba_t *fmsba, bool altmedisable) { if (ifd_version >= IFD_VERSION_2) { printf("%sting the HAP bit to %s Intel ME...\n", @@ -1107,7 +1107,7 @@ } }
-void inject_region(const char *filename, char *image, int size, +static void inject_region(const char *filename, char *image, int size, unsigned int region_type, const char *region_fname) { frba_t *frba = find_frba(image, size); @@ -1173,7 +1173,7 @@ write_image(filename, image, size); }
-unsigned int next_pow2(unsigned int x) +static unsigned int next_pow2(unsigned int x) { unsigned int y = 1; if (x == 0) @@ -1200,7 +1200,7 @@ return !(r1->limit < r2->base || r1->base > r2->limit); }
-void new_layout(const char *filename, char *image, int size, +static void new_layout(const char *filename, char *image, int size, const char *layout_fname) { FILE *romlayout;
-
Jacob Garber (Code Review) -
Martin Roth (Code Review)