Change in ...coreboot[master]: util/ifdtool: Enable -Wmissing-prototypes
Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33861 Change subject: util/ifdtool: Enable -Wmissing-prototypes ...................................................................... util/ifdtool: Enable -Wmissing-prototypes Change-Id: Idc31144024f785a42cbad78bf2c965d08dcc5178 Signed-off-by: Jacob Garber <jgarber1@ualberta.ca> --- M util/ifdtool/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/33861/1 diff --git a/util/ifdtool/Makefile b/util/ifdtool/Makefile index e1188b2..4cddfc5 100644 --- a/util/ifdtool/Makefile +++ b/util/ifdtool/Makefile @@ -18,7 +18,7 @@ CC = gcc INSTALL = /usr/bin/env install PREFIX = /usr/local -CFLAGS = -O2 -g -Wall -W -Werror -I../../src/commonlib/include +CFLAGS = -O2 -g -Wall -W -Wmissing-prototypes -Werror -I../../src/commonlib/include LDFLAGS = OBJS = ifdtool.o -- To view, visit https://review.coreboot.org/c/coreboot/+/33861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc31144024f785a42cbad78bf2c965d08dcc5178 Gerrit-Change-Number: 33861 Gerrit-PatchSet: 1 Gerrit-Owner: Jacob Garber <jgarber1@ualberta.ca> Gerrit-MessageType: newchange
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33861 ) Change subject: util/ifdtool: Enable -Wmissing-prototypes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/33861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc31144024f785a42cbad78bf2c965d08dcc5178 Gerrit-Change-Number: 33861 Gerrit-PatchSet: 1 Gerrit-Owner: Jacob Garber <jgarber1@ualberta.ca> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Fri, 28 Jun 2019 19:04:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33861 ) Change subject: util/ifdtool: Enable -Wmissing-prototypes ...................................................................... util/ifdtool: Enable -Wmissing-prototypes Change-Id: Idc31144024f785a42cbad78bf2c965d08dcc5178 Signed-off-by: Jacob Garber <jgarber1@ualberta.ca> Reviewed-on: https://review.coreboot.org/c/coreboot/+/33861 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Martin Roth <martinroth@google.com> --- M util/ifdtool/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/util/ifdtool/Makefile b/util/ifdtool/Makefile index e1188b2..4cddfc5 100644 --- a/util/ifdtool/Makefile +++ b/util/ifdtool/Makefile @@ -18,7 +18,7 @@ CC = gcc INSTALL = /usr/bin/env install PREFIX = /usr/local -CFLAGS = -O2 -g -Wall -W -Werror -I../../src/commonlib/include +CFLAGS = -O2 -g -Wall -W -Wmissing-prototypes -Werror -I../../src/commonlib/include LDFLAGS = OBJS = ifdtool.o -- To view, visit https://review.coreboot.org/c/coreboot/+/33861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc31144024f785a42cbad78bf2c965d08dcc5178 Gerrit-Change-Number: 33861 Gerrit-PatchSet: 2 Gerrit-Owner: Jacob Garber <jgarber1@ualberta.ca> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: merged
participants (2)
-
Jacob Garber (Code Review) -
Martin Roth (Code Review)