Change in coreboot[master]: Documentation/mainboard/amd: Add padmelon doucumentation and images
Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon doucumentation and images ......................................................................
Documentation/mainboard/amd: Add padmelon doucumentation and images
Extract publicly available information and pictures from padmelon manual, and make them available to coreboot community. Add information on programming SPI.
BUG=none. TEST=none.
Change-Id: I1a684c1acd3fb9441df71e2bc0fffa6131148b98 Signed-off-by: Richard Spiegel richard.spiegel@silverbackltd.com --- A Documentation/mainboard/amd/Padmelon.md A Documentation/mainboard/amd/padmelon/padmelon.jpg A Documentation/mainboard/amd/padmelon/padmelon_components.jpg A Documentation/mainboard/amd/padmelon/padmelon_io.jpg A Documentation/mainboard/amd/padmelon/padmelon_io_description.jpg M Documentation/soc/amd/index.md A Documentation/soc/amd/merlinfalcon.md 7 files changed, 95 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/34493/1
diff --git a/Documentation/mainboard/amd/Padmelon.md b/Documentation/mainboard/amd/Padmelon.md new file mode 100644 index 0000000..2868b05 --- /dev/null +++ b/Documentation/mainboard/amd/Padmelon.md @@ -0,0 +1,66 @@ +# Padmelon board + +## Specs (Merlin Falcon) + +* Two 260-pin DDR4 SO-DIMM slots, 1.2V DDR4-1333/1600/1866/2133 SO-DIMMs + Supports 4GB, 8GB and 16GB DDR4 unbuffered ECC (Merlin Falcon)SO-DIMMs +* Can use Prairie Falcon, Brown Falcon, Merlin Falcon, though coreboot code + is specific for Merlin Falcon SOC. Some specs change if not Merlin Falcon. +* One half mini PCI-Express slot on back side of mainboard +* One PCI Express® 3.0 x8 slot +* Two SATA3 ports with 6Gb/s data transfer rate +* Two USB 2.0 ports at rear panel +* Two USB 3.0* ports at rear panel +* Dual Gigabit Ethernet from Realtek RTL8111F Gigabit controller +* Supports 6-channel High-Definition audio from Realtek ALC662 codec +* One soldered down SPI flash with dediprog header + +## Picture padmelon components mistakes. + +The picture was extracted from manual, however, the numbering on the padmelon board is misplaced. +Of real importance is that (6) is actually the dediprog header to flash the BIOS. +(16) is actually 2 mux chips that acts like a bridge between the SPI and the CPU or the dediprog +header. The bridge will connect the SPI to the header if and only if no power is applied to the CPU, +thugh the board itself can be connected to a power supply that is connected to AC. With or without +AC connected, provided CPU is not powered, SPI can be programmed using dediprog. Once CPU is powered, +dediprog is protected from harm (even if still connected to the header) because the mux will float +the pins. The mux should be the first place to be investigated if you are unable to program the SPI. + +## Flashing coreboot + ++---------------------+--------------------+ +| Type | Value | ++=====================+====================+ +| Socketed flash | no | ++---------------------+--------------------+ +| Model | Macronix MX256435E | ++---------------------+--------------------+ +| Size | 8 MiB | ++---------------------+--------------------+ +| In circuit flashing | no, use dediprog | ++---------------------+--------------------+ +| Package | SOIC-8 | ++---------------------+--------------------+ +| Write protection | No | ++---------------------+--------------------+ +``` + +## Technology + ++---------------+------------------------------+ +| SoC | :doc:`../../soc/amd/index` | ++---------------+------------------------------+ +| CPU | Merlin Falcon SOC | ++---------------+------------------------------+ + +## Pictures + ++----------------------------+----------------------------------------+ +|padmelon.jpg | Motherboard with components identified | ++----------------------------+----------------------------------------+ +|padmelon_components.jpg | Identifying components | ++----------------------------+----------------------------------------+ +|padmelon_io.jpg | Back panel picture | ++----------------------------+----------------------------------------+ +|padmelon_io_description.jpg | Back panel description | ++----------------------------+----------------------------------------+ diff --git a/Documentation/mainboard/amd/padmelon/padmelon.jpg b/Documentation/mainboard/amd/padmelon/padmelon.jpg new file mode 100644 index 0000000..1723f5e --- /dev/null +++ b/Documentation/mainboard/amd/padmelon/padmelon.jpg Binary files differ diff --git a/Documentation/mainboard/amd/padmelon/padmelon_components.jpg b/Documentation/mainboard/amd/padmelon/padmelon_components.jpg new file mode 100644 index 0000000..5574d8a --- /dev/null +++ b/Documentation/mainboard/amd/padmelon/padmelon_components.jpg Binary files differ diff --git a/Documentation/mainboard/amd/padmelon/padmelon_io.jpg b/Documentation/mainboard/amd/padmelon/padmelon_io.jpg new file mode 100644 index 0000000..0a515f7 --- /dev/null +++ b/Documentation/mainboard/amd/padmelon/padmelon_io.jpg Binary files differ diff --git a/Documentation/mainboard/amd/padmelon/padmelon_io_description.jpg b/Documentation/mainboard/amd/padmelon/padmelon_io_description.jpg new file mode 100644 index 0000000..341e610 --- /dev/null +++ b/Documentation/mainboard/amd/padmelon/padmelon_io_description.jpg Binary files differ diff --git a/Documentation/soc/amd/index.md b/Documentation/soc/amd/index.md index 7945b48..84d070b 100644 --- a/Documentation/soc/amd/index.md +++ b/Documentation/soc/amd/index.md @@ -4,5 +4,6 @@
## Technology
+- [Merlin Falcon](merlinfalcon.md) - [Family 17h](family17h.md)
diff --git a/Documentation/soc/amd/merlinfalcon.md b/Documentation/soc/amd/merlinfalcon.md new file mode 100644 index 0000000..e8a36be --- /dev/null +++ b/Documentation/soc/amd/merlinfalcon.md @@ -0,0 +1,28 @@ +# AMD Merlin Falcon in coreboot + +## Abstract + +Merlin Falcon is a family 15h Models 60-6F SOC, more specifically, 00660F01. + +## Introduction + +Family 15h products are x86-based designs. This documentation assumes +familiarity with x86, its reset state and its early initialization +requirements. + +AMD has historically required an NDA for access to the PSP +specification<sup>1</sup>. coreboot relies on util/amdfwtool to build +the structures and add various other firmware to the final image. + +Support in coreboot for modern AMD products is based on AMD’s +reference code: AMD Generic Encapsulated Software Architecture +(AGESA<sup>TM</sup>). AGESA contains the technology for enabling DRAM, +configuring proprietary core logic, assistance with generating ACPI +tables, and other features. + +## Additional Definitions + +* PSP, Platform Security Processor: Onboard ARM processor that runs +alongside the main x86 processor; may be viewed as analogous to the +Intel<sup>R</sup> Management Engine +* FCH, Fusion Control Hub, the logical southbridge within the SOC
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon doucumentation and images ......................................................................
Patch Set 1:
smaller JPEGs please
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon doucumentation and images ......................................................................
Patch Set 1:
Patch Set 1:
smaller JPEGs please
What's the maximum size? Can I actually add a zip file instead of the JPG files?
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon doucumentation and images ......................................................................
Patch Set 1:
(3 comments)
Thank you for writing documentation.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... File Documentation/soc/amd/merlinfalcon.md:
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... PS1, Line 14: <sup>1</sup> Is there a reference?
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... PS1, Line 19: <sup>TM</sup> Is that needed in coreboot? If yes, I‘d prefer UTF-8 characters: ™
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... PS1, Line 27: <sup>R</sup> Are these symbols needed in the coreboot documentation?
Ⓡ
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon doucumentation and images ......................................................................
Patch Set 1:
Patch Set 1: What's the maximum size?
There's not a maximum size per-se, but usually I managed to shrink images proposed for Documentation from 200-300kb to 50kb with no significant loss in fidelity.
Remember that any file we add to the master branch will remain in the repo _permanently_, still around long after we removed it from the tree (e.g. because we retired its support because nobody has a working board anymore).
Can I actually add a zip file instead of the JPG files?
You couldn't include them into the page from a zip. Also, zipping jpeg usually helps _very_ little since it's compressed already.
Check out jpegoptim, a simple console tool to reduce jpeg file sizes, and look at its quality settings. You can usually get by with a quality setting between 60 and 80 for PCB photos and still have a pretty good picture.
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon doucumentation and images ......................................................................
Patch Set 1:
(3 comments)
Will check the tool for reducing jpeg size.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... File Documentation/soc/amd/merlinfalcon.md:
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... PS1, Line 14: <sup>1</sup>
Is there a reference?
Not anymore... I copied from family 177h and adapted, and did not noticed this reference... will remove.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... PS1, Line 19: <sup>TM</sup>
Is that needed in coreboot? If yes, I‘d prefer UTF-8 characters: ™
Again, copied from family 17h (which uses AGESA v9). I don't know if it's needed, and I don't have the proper editor/reader to know what <sup></sup> does, nor do I know if UFT-8 would work. That's one reason I copied from family 17h... I was sure that if <sup> was used there, than it should work here too. That said, if you want me to it, I will. I would wait for someone else opinion before I remove the <sup></sup>.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... PS1, Line 27: <sup>R</sup>
Are these symbols needed in the coreboot documentation? […]
Again, I don't know. I would assume so from a legal stand point.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon doucumentation and images ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34493/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34493/1//COMMIT_MSG@7 PS1, Line 7: doucumentation documentation
Hello HAOUAS Elyes, Paul Menzel, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34493
to look at the new patch set (#2).
Change subject: Documentation/mainboard/amd: Add padmelon doucumentation and images ......................................................................
Documentation/mainboard/amd: Add padmelon doucumentation and images
Extract publicly available information and pictures from padmelon manual, and make them available to coreboot community. Add information on programming SPI.
BUG=none. TEST=none.
Change-Id: I1a684c1acd3fb9441df71e2bc0fffa6131148b98 Signed-off-by: Richard Spiegel richard.spiegel@silverbackltd.com --- A Documentation/mainboard/amd/Padmelon.md A Documentation/mainboard/amd/padmelon/padmelon.jpg A Documentation/mainboard/amd/padmelon/padmelon_components.jpg A Documentation/mainboard/amd/padmelon/padmelon_io.jpg A Documentation/mainboard/amd/padmelon/padmelon_io_description.jpg M Documentation/soc/amd/index.md A Documentation/soc/amd/merlinfalcon.md 7 files changed, 95 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/34493/2
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon doucumentation and images ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34493/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34493/1//COMMIT_MSG@7 PS1, Line 7: doucumentation
documentation
Oops...
Hello HAOUAS Elyes, Paul Menzel, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34493
to look at the new patch set (#3).
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Documentation/mainboard/amd: Add padmelon documentation and images
Extract publicly available information and pictures from padmelon manual, and make them available to coreboot community. Add information on programming SPI.
BUG=none. TEST=none.
Change-Id: I1a684c1acd3fb9441df71e2bc0fffa6131148b98 Signed-off-by: Richard Spiegel richard.spiegel@silverbackltd.com --- A Documentation/mainboard/amd/Padmelon.md A Documentation/mainboard/amd/padmelon/padmelon.jpg A Documentation/mainboard/amd/padmelon/padmelon_components.jpg A Documentation/mainboard/amd/padmelon/padmelon_io.jpg A Documentation/mainboard/amd/padmelon/padmelon_io_description.jpg M Documentation/soc/amd/index.md A Documentation/soc/amd/merlinfalcon.md 7 files changed, 95 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/34493/3
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Patch Set 3:
(9 comments)
https://review.coreboot.org/c/coreboot/+/34493/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34493/1//COMMIT_MSG@7 PS1, Line 7: doucumentation documentation
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/Padmelon.md:
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... PS1, Line 20: The picture was extracted from manual, however, the numbering on the padmelon board is misplaced. All markdown lines need to be wrapped at a maximum of 72 characters. https://doc.coreboot.org/getting_started/writing_documentation.html#basic-an...
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... PS1, Line 40: no, use dediprog Now I'm curious about what "in circuit flashing" means.
1) I'd assume you can flash it from the host. 2) If you can flash with dediprog and the host, then what else qualifies as in-circuit?
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon.jpg:
PS1: Images should have a max width of 700 pixels: https://doc.coreboot.org/getting_started/writing_documentation.html#basic-an...
What's the copyright on this photo? Maybe you can take your own photos instead of using these that are probably not publicly distributable.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon_components.jpg:
PS1: This might be better included as text.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon_io.jpg:
PS1: Again, take your own photo? If you need help labeling it, I could help with that.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon_io_description.jpg:
PS1: Again, text instead of an image?
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/index... File Documentation/soc/amd/index.md:
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/index... PS1, Line 5: ## Technology Make the merlin falcon documentation a separate commit?
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... File Documentation/soc/amd/merlinfalcon.md:
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... PS1, Line 3: ## Abstract Add links via the internet archive?
https://web.archive.org/web/20190617113113/https://developer.amd.com/resourc...
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Patch Set 3:
(10 comments)
https://review.coreboot.org/c/coreboot/+/34493/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34493/1//COMMIT_MSG@7 PS1, Line 7: doucumentation
Oops...
Done
https://review.coreboot.org/c/coreboot/+/34493/1//COMMIT_MSG@7 PS1, Line 7: doucumentation
documentation
Already done.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/Padmelon.md:
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... PS1, Line 20: The picture was extracted from manual, however, the numbering on the padmelon board is misplaced.
All markdown lines need to be wrapped at a maximum of 72 characters. […]
Ok. Will fix, but also change the text as I'll take my own pictures.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... PS1, Line 40: no, use dediprog
Now I'm curious about what "in circuit flashing" means. […]
I'm not sure, as I copied some of it from a board that looked like having very complete documentation. Maybe I should change it to "Flash programming" and "dediprog header"
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon.jpg:
PS1:
Images should have a max width of 700 pixels: […]
Will take my own picture. Might need help labeling.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon_components.jpg:
PS1:
This might be better included as text.
Will do.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon_io.jpg:
PS1:
Again, take your own photo? If you need help labeling it, I could help with that.
Will do.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon_io_description.jpg:
PS1:
Again, text instead of an image?
Will do.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/index... File Documentation/soc/amd/index.md:
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/index... PS1, Line 5: ## Technology
Make the merlin falcon documentation a separate commit?
Sure
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... File Documentation/soc/amd/merlinfalcon.md:
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... PS1, Line 3: ## Abstract
Add links via the internet archive? […]
Thanks, nice link.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Patch Set 3:
(8 comments)
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... File Documentation/mainboard/amd/Padmelon.md:
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 1: # Padmelon board file needs to be reference from other *.md
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 16: * One soldered down SPI flash with dediprog header please provide a picture and description where to find the header. Everything else isn't important for firmware developers.
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 20: The picture was extracted from manual, however, the numbering on the padmelon board is misplaced. do you own the copyright on it? which license was it published under?
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 26: dediprog is protected from harm (even if still connected to the header) because the mux will float limit to 80 chars per line
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 31: +---------------------+--------------------+ all tables needs to be embedded in ```eval_rst
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 40: | In circuit flashing | no, use dediprog | you desolder it every time you want to flash?
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 59: padmelon please use proper markdown to include pictures
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/soc/amd/merli... File Documentation/soc/amd/merlinfalcon.md:
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/soc/amd/merli... PS3, Line 14: specification<sup>1</sup>. coreboot relies on util/amdfwtool to build that's not markdown
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Patch Set 3:
(8 comments)
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... File Documentation/mainboard/amd/Padmelon.md:
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 1: # Padmelon board
file needs to be reference from other *. […]
From an index.md?
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 16: * One soldered down SPI flash with dediprog header
please provide a picture and description where to find the header. […]
Already did, but picture will be replaced by a new one.
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 20: The picture was extracted from manual, however, the numbering on the padmelon board is misplaced.
do you own the copyright on it? which license was it published under?
Picture will be replaced by one I myself will take.
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 26: dediprog is protected from harm (even if still connected to the header) because the mux will float
limit to 80 chars per line
Will do.
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 31: +---------------------+--------------------+
all tables needs to be embedded in ```eval_rst
will do.
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 40: | In circuit flashing | no, use dediprog |
you desolder it every time you want to flash?
No, there's a header. The text (both sides) will be replaced with something more obvious.
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 59: padmelon
please use proper markdown to include pictures
Will do.
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/soc/amd/merli... File Documentation/soc/amd/merlinfalcon.md:
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/soc/amd/merli... PS3, Line 14: specification<sup>1</sup>. coreboot relies on util/amdfwtool to build
that's not markdown
Will remove it.
Hello HAOUAS Elyes, Paul Menzel, build bot (Jenkins), Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34493
to look at the new patch set (#4).
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Documentation/mainboard/amd: Add padmelon documentation and images
Create documentation on padmelon, including how to program the SPI. Also include an index.md pointing to the documentation, as currently there's no maiboard documentation folder for AMD.
BUG=none. TEST=none.
Change-Id: I1a684c1acd3fb9441df71e2bc0fffa6131148b98 Signed-off-by: Richard Spiegel richard.spiegel@silverbackltd.com --- A Documentation/mainboard/amd/index.md A Documentation/mainboard/amd/padmelon/padmelon.jpg A Documentation/mainboard/amd/padmelon/padmelon.md A Documentation/mainboard/amd/padmelon/padmelon_io.jpg 4 files changed, 86 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/34493/4
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Patch Set 4:
(16 comments)
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/Padmelon.md:
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... PS1, Line 20: The picture was extracted from manual, however, the numbering on the padmelon board is misplaced.
Ok. Will fix, but also change the text as I'll take my own pictures.
Done
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... PS1, Line 40: no, use dediprog
I'm not sure, as I copied some of it from a board that looked like having very complete documentatio […]
Done
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... File Documentation/mainboard/amd/Padmelon.md:
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 20: The picture was extracted from manual, however, the numbering on the padmelon board is misplaced.
Picture will be replaced by one I myself will take.
Done
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 26: dediprog is protected from harm (even if still connected to the header) because the mux will float
Will do.
Done
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 31: +---------------------+--------------------+
will do.
Done
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 40: | In circuit flashing | no, use dediprog |
No, there's a header. The text (both sides) will be replaced with something more obvious.
Done
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 59: padmelon
Will do.
Done
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon.jpg:
PS1:
Will take my own picture. Might need help labeling.
Done
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon_components.jpg:
PS1:
Will do.
Done
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon_io.jpg:
PS1:
Will do.
Done
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon_io_description.jpg:
PS1:
Will do.
Done
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/index... File Documentation/soc/amd/index.md:
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/index... PS1, Line 5: ## Technology
Sure
Done: 34561
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... File Documentation/soc/amd/merlinfalcon.md:
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... PS1, Line 14: <sup>1</sup>
Not anymore... I copied from family 177h and adapted, and did not noticed this reference... […]
Moved to 34561 and solved there.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... PS1, Line 19: <sup>TM</sup>
Again, copied from family 17h (which uses AGESA v9). […]
Moved to 34561 and replaced with _**TM**_
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... PS1, Line 27: <sup>R</sup>
Again, I don't know. I would assume so from a legal stand point.
Moved to 34561, but still present there.
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/soc/amd/merli... File Documentation/soc/amd/merlinfalcon.md:
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/soc/amd/merli... PS3, Line 14: specification<sup>1</sup>. coreboot relies on util/amdfwtool to build
Will remove it.
Moved to 34561 and removed there.
Hello HAOUAS Elyes, Paul Menzel, build bot (Jenkins), Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34493
to look at the new patch set (#5).
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Documentation/mainboard/amd: Add padmelon documentation and images
Create documentation on padmelon, including how to program the SPI. Also include an index.md pointing to the documentation, as currently there's no maiboard documentation folder for AMD.
BUG=none. TEST=none.
Change-Id: I1a684c1acd3fb9441df71e2bc0fffa6131148b98 Signed-off-by: Richard Spiegel richard.spiegel@silverbackltd.com --- A Documentation/mainboard/amd/index.md A Documentation/mainboard/amd/padmelon/padmelon.jpg A Documentation/mainboard/amd/padmelon/padmelon.md A Documentation/mainboard/amd/padmelon/padmelon_io.jpg 4 files changed, 87 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/34493/5
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... File Documentation/mainboard/amd/Padmelon.md:
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 1: # Padmelon board
From an index. […]
Done
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Patch Set 5:
Please resume reviewing.
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Patch Set 5:
Ping...
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Patch Set 5:
Ping... review please.
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Patch Set 5:
Ping... please review
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34493/5/Documentation/mainboard/amd... File Documentation/mainboard/amd/index.md:
https://review.coreboot.org/c/coreboot/+/34493/5/Documentation/mainboard/amd... PS5, Line 3: platforms "platforms" is a bit ambiguous here. Mainboards, maybe?
https://review.coreboot.org/c/coreboot/+/34493/5/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon.md:
https://review.coreboot.org/c/coreboot/+/34493/5/Documentation/mainboard/amd... PS5, Line 8: wil will
https://review.coreboot.org/c/coreboot/+/34493/5/Documentation/mainboard/amd... PS5, Line 14: * what's the asterisk about?
https://review.coreboot.org/c/coreboot/+/34493/5/Documentation/mainboard/amd... PS5, Line 16: Supports drop the word for consistency with the other bullet points
https://review.coreboot.org/c/coreboot/+/34493/5/Documentation/mainboard/amd... PS5, Line 19: Maiboard Mainboard
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34493/5/Documentation/mainboard/amd... File Documentation/mainboard/amd/index.md:
https://review.coreboot.org/c/coreboot/+/34493/5/Documentation/mainboard/amd... PS5, Line 3: platforms
"platforms" is a bit ambiguous here. […]
Done
https://review.coreboot.org/c/coreboot/+/34493/5/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon.md:
https://review.coreboot.org/c/coreboot/+/34493/5/Documentation/mainboard/amd... PS5, Line 8: wil
will
Done
https://review.coreboot.org/c/coreboot/+/34493/5/Documentation/mainboard/amd... PS5, Line 14: *
what's the asterisk about?
Oops... removed
https://review.coreboot.org/c/coreboot/+/34493/5/Documentation/mainboard/amd... PS5, Line 16: Supports
drop the word for consistency with the other bullet points
Done
https://review.coreboot.org/c/coreboot/+/34493/5/Documentation/mainboard/amd... PS5, Line 19: Maiboard
Mainboard
Ack
Hello HAOUAS Elyes, Kerry Brown, Paul Menzel, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34493
to look at the new patch set (#6).
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Documentation/mainboard/amd: Add padmelon documentation and images
Create documentation on padmelon, including how to program the SPI. Also include an index.md pointing to the documentation, as currently there's no maiboard documentation folder for AMD.
BUG=none. TEST=none.
Change-Id: I1a684c1acd3fb9441df71e2bc0fffa6131148b98 Signed-off-by: Richard Spiegel richard.spiegel@silverbackltd.com --- A Documentation/mainboard/amd/index.md A Documentation/mainboard/amd/padmelon/padmelon.jpg A Documentation/mainboard/amd/padmelon/padmelon.md A Documentation/mainboard/amd/padmelon/padmelon_io.jpg 4 files changed, 87 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/34493/6
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Patch Set 6: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Documentation/mainboard/amd: Add padmelon documentation and images
Create documentation on padmelon, including how to program the SPI. Also include an index.md pointing to the documentation, as currently there's no maiboard documentation folder for AMD.
BUG=none. TEST=none.
Change-Id: I1a684c1acd3fb9441df71e2bc0fffa6131148b98 Signed-off-by: Richard Spiegel richard.spiegel@silverbackltd.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34493 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- A Documentation/mainboard/amd/index.md A Documentation/mainboard/amd/padmelon/padmelon.jpg A Documentation/mainboard/amd/padmelon/padmelon.md A Documentation/mainboard/amd/padmelon/padmelon_io.jpg 4 files changed, 87 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/Documentation/mainboard/amd/index.md b/Documentation/mainboard/amd/index.md new file mode 100644 index 0000000..7a33de8 --- /dev/null +++ b/Documentation/mainboard/amd/index.md @@ -0,0 +1,7 @@ +# AMD platforms documentation + +This section contains documentation about specific AMD mainboards. + +## Mainboard + +- [padmelon](padmelon/padmelon.md) diff --git a/Documentation/mainboard/amd/padmelon/padmelon.jpg b/Documentation/mainboard/amd/padmelon/padmelon.jpg new file mode 100644 index 0000000..76ee578 --- /dev/null +++ b/Documentation/mainboard/amd/padmelon/padmelon.jpg Binary files differ diff --git a/Documentation/mainboard/amd/padmelon/padmelon.md b/Documentation/mainboard/amd/padmelon/padmelon.md new file mode 100644 index 0000000..f606f47 --- /dev/null +++ b/Documentation/mainboard/amd/padmelon/padmelon.md @@ -0,0 +1,80 @@ +# Padmelon board + +## Specs (with Merlin Falcon SOC) + +* Two 260-pin DDR4 SO-DIMM slots, 1.2V DDR4-1333/1600/1866/2133 SO-DIMMs + Supports 4GB, 8GB and 16GB DDR4 unbuffered ECC (Merlin Falcon)SO-DIMMs +* Can use Prairie Falcon, Brown Falcon, Merlin Falcon, though coreboot + code is specific for Merlin Falcon SOC. Some specs will change if not + using Merlin Falcon. +* One half mini PCI-Express slot on back side of mainboard +* One PCI Express® 3.0 x8 slot +* Two SATA3 ports with 6Gb/s data transfer rate +* Two USB 2.0 ports at rear panel +* Two USB 3.0 ports at rear panel +* Dual Gigabit Ethernet from Realtek RTL8111F Gigabit controller +* 6-channel High-Definition audio from Realtek ALC662 codec +* One soldered down SPI flash with dediprog header + +## Mainboard + +![mainboard][padmelon] + +Three items are marked in this picture +1. dediprog header +2. memory dimms, address 0xA0 and 0xA4 +3. SATA cables connected to motherboard + +## Back panel + +![back panel][padmelon_io] + +* The lower serial port is UART A (debug serial) + +## Flashing coreboot + +```eval_rst ++---------------------+--------------------+ +| Type | Value | ++=====================+====================+ +| Socketed flash | no | ++---------------------+--------------------+ +| Model | Macronix MX256435E | ++---------------------+--------------------+ +| Size | 8 MiB | ++---------------------+--------------------+ +| Flash programing | dediprog header | ++---------------------+--------------------+ +| Package | SOIC-8 | ++---------------------+--------------------+ +| Write protection | No | ++---------------------+--------------------+ +``` + +## Technology + +```eval_rst ++---------------+------------------------------+ +| Fan control | Using fintek F81803A | ++---------------+------------------------------+ +| CPU | Merlin Falcon (see reference)| ++---------------+------------------------------+ +``` + +## Description of pictures within this document + +```eval_rst ++----------------------------+----------------------------------------+ +|padmelon.jpg | Motherboard with components identified | ++----------------------------+----------------------------------------+ +|padmelon_io.jpg | Back panel picture | ++----------------------------+----------------------------------------+ +``` + +## Reference + +[Merlin Falcon BKDG][merlinfalcon] + +[merlinfalcon]: ../../soc/amd/family15h.md +[padmelon]: padmelon.jpg +[padmelon_io]: padmelon_io.jpg diff --git a/Documentation/mainboard/amd/padmelon/padmelon_io.jpg b/Documentation/mainboard/amd/padmelon/padmelon_io.jpg new file mode 100644 index 0000000..ed715d4 --- /dev/null +++ b/Documentation/mainboard/amd/padmelon/padmelon_io.jpg Binary files differ
-
Martin Roth (Code Review) -
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)
-
Richard Spiegel (Code Review)