9 comments:
Patch Set #1, Line 7: doucumentation
documentation
File Documentation/mainboard/amd/Padmelon.md:
Patch Set #1, Line 20: The picture was extracted from manual, however, the numbering on the padmelon board is misplaced.
All markdown lines need to be wrapped at a maximum of 72 characters.
https://doc.coreboot.org/getting_started/writing_documentation.html#basic-and-simple-rules
Patch Set #1, Line 40: no, use dediprog
Now I'm curious about what "in circuit flashing" means.
1) I'd assume you can flash it from the host.
2) If you can flash with dediprog and the host, then what else qualifies as in-circuit?
File Documentation/mainboard/amd/padmelon/padmelon.jpg:
Images should have a max width of 700 pixels:
https://doc.coreboot.org/getting_started/writing_documentation.html#basic-and-simple-rules
What's the copyright on this photo? Maybe you can take your own photos instead of using these that are probably not publicly distributable.
File Documentation/mainboard/amd/padmelon/padmelon_components.jpg:
This might be better included as text.
File Documentation/mainboard/amd/padmelon/padmelon_io.jpg:
Again, take your own photo? If you need help labeling it, I could help with that.
File Documentation/mainboard/amd/padmelon/padmelon_io_description.jpg:
Again, text instead of an image?
File Documentation/soc/amd/index.md:
Patch Set #1, Line 5: ## Technology
Make the merlin falcon documentation a separate commit?
File Documentation/soc/amd/merlinfalcon.md:
Patch Set #1, Line 3: ## Abstract
Add links via the internet archive?
https://web.archive.org/web/20190617113113/https://developer.amd.com/resources/developer-guides-manuals/
To view, visit change 34493. To unsubscribe, or for help writing mail filters, visit settings.